8332015: since-checker - Add @ since tags to jdk.httpserver

[nizarbenalla]

Please review this simple change, aiming to fix current uses of @since in the source code
-The constructor BasicAuthenticator(java.lang.String,java.nio.charset.Charset) needs an @since 14 instead of 9.
-com.sun.net.httpserver.spi: package-info.java does not contain an @since.
Thanks in advance.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Warning

 ⚠️ Found leading lowercase letter in issue title for 8332015: since-checker - Add @ since tags to jdk.httpserver

Issue

• JDK-8332015: since-checker - Add @ since tags to jdk.httpserver (Sub-task - P4)

Reviewers

• Alan Bateman (@AlanBateman - Reviewer)
• Daniel Fuchs (@dfuch - Reviewer)
• Michael McMahon (@Michael-Mc-Mahon - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/19168/head:pull/19168
$ git checkout pull/19168

Update a local copy of the PR:
$ git checkout pull/19168
$ git pull https://git.openjdk.org/jdk.git pull/19168/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 19168

View PR using the GUI difftool:
$ git pr show -t 19168

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/19168.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back nizarbenalla! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@nizarbenalla This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8332015: since-checker - Add @ since tags to jdk.httpserver

Reviewed-by: alanb, dfuchs, michaelm

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 354 new commits pushed to the master branch:

• 0f4154a: 8331193: Return references when possible in GrowableArray
• 64bbae7: 8333394: C2: assert(bol->is_Opaque4() || bol->is_OpaqueInitializedAssertionPredicate()) failed: Opaque node of non-null-check or of Initialized Assertion Predicate
• c7495fb: 8333444: Parallel: Inline PSParallelCompact::mark_obj
• 454660d: 8332900: RISC-V: refactor nativeInst_riscv.cpp and macroAssembler_riscv.cpp
• 67d6f3c: 8332905: C2 SuperWord: bad AD file, with RotateRightV and first operand not a pack
• ca30726: 8332866: Crash in ImageIO JPEG decoding when MEM_STATS in enabled
• 29e10e4: 8332547: Unloaded signature classes in DirectMethodHandles
• c7d2a5c: 8314070: javax.print: Support IPP output-bin attribute extension
• d230b30: 8333398: Uncomment the commented test in test/jdk/java/util/jar/JarFile/mrjar/MultiReleaseJarAPI.java
• 1512011: 8332123: [nmt] Move mallocLimit code to the nmt subdir
• ... and 344 more: https://git.openjdk.org/jdk/compare/8af606fb8cdb3a6ecdfe4cddd79f228b64d5fc80...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@AlanBateman, @dfuch, @Michael-Mc-Mahon) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[openjdk]

@nizarbenalla The following label will be automatically applied to this pull request:

• net

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (363bcf94)
• 00: Full (d35d602f)

[liach]

Seems you changed the header of the wrong file

[nizarbenalla]

Ah, thanks

[AlanBateman]

The HTTP server was added in JDK 6. The 2-arg constructor was added to BasicAuthenticator via JDK-8199849 in JDK 14. So I think this looks right.

[dfuch]

This looks right to me but please wait for @Michael-Mc-Mahon to confirm before integrating.

[nizarbenalla]

Sure, thanks Daniel, Alan.

[Michael-Mc-Mahon]

Looks fine.

[nizarbenalla]

/integrate

[openjdk]

@nizarbenalla
Your change (at version 363bcf9) is now ready to be sponsored by a Committer.

[Michael-Mc-Mahon]

/sponsor

[openjdk]

Going to push as commit 9ee741d.
Since your change was applied there have been 354 commits pushed to the master branch:

• 0f4154a: 8331193: Return references when possible in GrowableArray
• 64bbae7: 8333394: C2: assert(bol->is_Opaque4() || bol->is_OpaqueInitializedAssertionPredicate()) failed: Opaque node of non-null-check or of Initialized Assertion Predicate
• c7495fb: 8333444: Parallel: Inline PSParallelCompact::mark_obj
• 454660d: 8332900: RISC-V: refactor nativeInst_riscv.cpp and macroAssembler_riscv.cpp
• 67d6f3c: 8332905: C2 SuperWord: bad AD file, with RotateRightV and first operand not a pack
• ca30726: 8332866: Crash in ImageIO JPEG decoding when MEM_STATS in enabled
• 29e10e4: 8332547: Unloaded signature classes in DirectMethodHandles
• c7d2a5c: 8314070: javax.print: Support IPP output-bin attribute extension
• d230b30: 8333398: Uncomment the commented test in test/jdk/java/util/jar/JarFile/mrjar/MultiReleaseJarAPI.java
• 1512011: 8332123: [nmt] Move mallocLimit code to the nmt subdir
• ... and 344 more: https://git.openjdk.org/jdk/compare/8af606fb8cdb3a6ecdfe4cddd79f228b64d5fc80...master

Your commit was automatically rebased without conflicts.

[openjdk]

@Michael-Mc-Mahon @nizarbenalla Pushed as commit 9ee741d.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.