Skip to content

Conversation

@xiaotaonan
Copy link
Contributor

@xiaotaonan xiaotaonan commented May 10, 2024

Remove -XX:+UseEmptySlotsInSupers.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8330699: Remove -XX:+UseEmptySlotsInSupers (Enhancement - P4)(⚠️ The fixVersion in this issue is [24] but the fixVersion in .jcheck/conf is 23, a new backport will be created when this pr is integrated.)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/19169/head:pull/19169
$ git checkout pull/19169

Update a local copy of the PR:
$ git checkout pull/19169
$ git pull https://git.openjdk.org/jdk.git pull/19169/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 19169

View PR using the GUI difftool:
$ git pr show -t 19169

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/19169.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented May 10, 2024

👋 Welcome back xiaotaonan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented May 10, 2024

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot added the rfr Pull request is ready for review label May 10, 2024
@openjdk
Copy link

openjdk bot commented May 10, 2024

@xiaotaonan The following label will be automatically applied to this pull request:

  • hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-runtime hotspot-runtime-dev@openjdk.org label May 10, 2024
@mlbridge
Copy link

mlbridge bot commented May 10, 2024

Webrevs

@liach
Copy link
Member

liach commented May 10, 2024

Depends on #18787, also redundant period in title.

@xiaotaonan xiaotaonan changed the title 8330699: Remove -XX:+UseEmptySlotsInSupers. 8330699: Remove -XX:+UseEmptySlotsInSupers May 10, 2024
Copy link
Contributor

@coleenp coleenp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This option was deprecated in JDK 23 so cannot be removed until 24, but the removal is really to make the option obsolete. See the comments above your change in arguments.cpp. The line should not be removed in arguments.cpp. This change is wrong.

There is code that uses this option, that needs to be adjusted in the absence of this option. I don't think this change compiles. If you turn on GHA, in your settings you should see that this doesn't compile.

This RFE is assigned to me. I would appreciate if you closed this PR and let me make this change.

@xiaotaonan xiaotaonan closed this May 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hotspot-runtime hotspot-runtime-dev@openjdk.org rfr Pull request is ready for review

Development

Successfully merging this pull request may close these issues.

3 participants