8259025: Record compact constructor using Objects.requireNonNull

[lgxbslgx]

Hi all,

Currently, the method Attr::lambdaEnv doesn't set the lambdaEnv.info.isLambda to true and lets the caller set it. But not all the callers remember to set it. In this bug, DefferredAttr::attribSpeculativeLambda uses Attr::lambdaEnv and doesn't set lambdaEnv.info.isLambda to true. So when Attr::visitReturn uses !env.info.isLambda to judge if it is in the lambda environment, it gets the wrong information and generates an error message.

This patch moves lambdaEnv.info.isLambda = true; into Attr::lambdaEnv to solve the problem and adds a corresponding test case. Thank you for taking the time to review.

Best Regards.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8259025: Record compact constructor using Objects.requireNonNull

Reviewers

• Attila Szegedi (@szegedi - Reviewer)

Download

$ git fetch https://git.openjdk.java.net/jdk pull/1917/head:pull/1917
$ git checkout pull/1917

[bridgekeeper]

👋 Welcome back lgxbslgx! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@lgxbslgx The following label will be automatically applied to this pull request:

• compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (d1357b1)

[szegedi]

Looks good, thanks for fixing this!

[openjdk]

@lgxbslgx This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8259025: Record compact constructor using Objects.requireNonNull

Reviewed-by: attila

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 103 new commits pushed to the master branch:

• b72de3c: 8259385: Cleanup unused assignment
• 9154f64: 8254973: CompletableFuture.ThreadPerTaskExecutor does not throw NPE in #execute
• e7c1740: 8258187: IllegalMonitorStateException in ArrayBlockingQueue
• 11d5b04: 8258217: PriorityBlockingQueue constructor spec and behavior mismatch
• 65ca5c6: 8048109: JToggleButton does not fire actionPerformed under certain conditions
• 81db63e: 8259517: Incorrect test path in test cases
• 270014a: 8234131: Miscellaneous changes imported from jsr166 CVS 2021-01
• 63e3bd7: 8246677: LinkedTransferQueue and SynchronousQueue synchronization updates
• 5cfa8c9: 8246585: ForkJoin updates
• 6472104: 6278172: TextComponent.getSelectedText() throws StringIndexOutOfBoundsException
• ... and 93 more: https://git.openjdk.java.net/jdk/compare/f5ee356540d7aa4a7663c0d5d74f5fdb0726b426...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@szegedi) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[lgxbslgx]

/integrate

[openjdk]

@lgxbslgx
Your change (at version d1357b1) is now ready to be sponsored by a Committer.

[szegedi]

/sponsor

[openjdk]

@szegedi @lgxbslgx Since your change was applied there have been 115 commits pushed to the master branch:

• 23801da: 8259482: jni_Set/GetField_probe are the same as their _nh versions
• 01b2804: 8237578: JDK-8214339 (SSLSocketImpl wraps SocketException) appears to not be fully fixed
• 1bd015f: 8258407: Split up CompileJavaModules.gmk into make/modules/$M/Java.gmk
• 2354882: 8250768: javac should be adapted to changes in JEP 12
• 18a37f9: 8259368: Zero: UseCompressedClassPointers does not depend on UseCompressedOops
• a03e22b: 8253910: UseCompressedClassPointers depends on UseCompressedOops in vmError.cpp
• e0d748d: 8258606: os::print_signal_handlers() should resolve the function name of the handlers
• bd34418: 8258445: Move make/templates to make/data
• d21a0ea: 8258449: Move make/hotspot/symbols to make/data
• 3974fd4: 8259451: Zero: skip serviceability/sa tests, set vm.hasSA to false
• ... and 105 more: https://git.openjdk.java.net/jdk/compare/f5ee356540d7aa4a7663c0d5d74f5fdb0726b426...master

Your commit was automatically rebased without conflicts.

Pushed as commit 33fbc10.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.