Skip to content

Conversation

@AlanBateman
Copy link
Contributor

@AlanBateman AlanBateman commented May 10, 2024

In preparation for JEP 471 and JEP 472, provide access to the initial value of System.err from JavaLangAccess. The initial value of System.in is already exposed to code in java.base with this shared secret.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8332029: Provide access to initial value of stderr via JavaLangAccess (Enhancement - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/19171/head:pull/19171
$ git checkout pull/19171

Update a local copy of the PR:
$ git checkout pull/19171
$ git pull https://git.openjdk.org/jdk.git pull/19171/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 19171

View PR using the GUI difftool:
$ git pr show -t 19171

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/19171.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented May 10, 2024

👋 Welcome back alanb! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented May 10, 2024

@AlanBateman This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8332029: Provide access to initial value of stderr via JavaLangAccess

Reviewed-by: jpai, bpb, mcimadamore

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 17 new commits pushed to the master branch:

  • 1b476f5: 8293345: SunPKCS11 provider checks on PKCS11 Mechanism are problematic
  • 1c5f150: 8331734: Atomic MemorySegment VarHandle operations fails for element layouts
  • 65abf24: 8331866: Add warnings for locale data dependence
  • d215bc4: 8332066: AArch64: Math test failures since JDK-8331558
  • d11e70a: 8331646: Add specific regression leap year tests
  • f95c937: 8331577: RISC-V: C2 CountLeadingZerosV
  • 675fbe6: 8331993: Add counting leading/trailing zero tests for Integer
  • 242446b: 8331931: JFR: Avoid loading regex classes during startup
  • 45792c5: 8331352: error: template-id not allowed for constructor/destructor in C++20
  • 1547a69: 8327696: [TESTBUG] "javax/swing/JTable/KeyBoardNavigation/KeyBoardNavigation.java" test instruction needs to be corrected
  • ... and 7 more: https://git.openjdk.org/jdk/compare/b9a142a2243676b3f4fe288e7a28f4957a4d1edd...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk
Copy link

openjdk bot commented May 10, 2024

@AlanBateman The following labels will be automatically applied to this pull request:

  • core-libs
  • security

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added security security-dev@openjdk.org core-libs core-libs-dev@openjdk.org labels May 10, 2024
@AlanBateman
Copy link
Contributor Author

/label remove security

@openjdk openjdk bot removed the security security-dev@openjdk.org label May 10, 2024
@openjdk
Copy link

openjdk bot commented May 10, 2024

@AlanBateman
The security label was successfully removed.

@AlanBateman AlanBateman marked this pull request as ready for review May 10, 2024 13:18
@openjdk openjdk bot added the rfr Pull request is ready for review label May 10, 2024
@mlbridge
Copy link

mlbridge bot commented May 10, 2024

Webrevs

Copy link
Member

@jaikiran jaikiran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change looks OK to me.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label May 10, 2024
Copy link
Member

@bplb bplb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@AlanBateman
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented May 11, 2024

Going to push as commit 32c7681.
Since your change was applied there have been 21 commits pushed to the master branch:

  • f9a1d33: 8332020: jwebserver tool prints invalid URL in case of IPv6 address binding
  • b87a7e9: 8144100: Incorrect case-sensitive equality in com.sun.net.httpserver.BasicAuthenticator
  • 1dac34f: 8331098: [Aarch64] Fix crash in Arrays.equals() intrinsic with -CCP
  • 5e8e8ef: 8315431: ArchiveHeapWriter::get_filler_size_at() cannot handle buffer expansion
  • 1b476f5: 8293345: SunPKCS11 provider checks on PKCS11 Mechanism are problematic
  • 1c5f150: 8331734: Atomic MemorySegment VarHandle operations fails for element layouts
  • 65abf24: 8331866: Add warnings for locale data dependence
  • d215bc4: 8332066: AArch64: Math test failures since JDK-8331558
  • d11e70a: 8331646: Add specific regression leap year tests
  • f95c937: 8331577: RISC-V: C2 CountLeadingZerosV
  • ... and 11 more: https://git.openjdk.org/jdk/compare/b9a142a2243676b3f4fe288e7a28f4957a4d1edd...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label May 11, 2024
@openjdk openjdk bot closed this May 11, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels May 11, 2024
@openjdk
Copy link

openjdk bot commented May 11, 2024

@AlanBateman Pushed as commit 32c7681.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core-libs core-libs-dev@openjdk.org integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

4 participants