-
Notifications
You must be signed in to change notification settings - Fork 6.1k
8332029: Provide access to initial value of stderr via JavaLangAccess #19171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
👋 Welcome back alanb! A progress list of the required criteria for merging this PR into |
|
@AlanBateman This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 17 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
|
@AlanBateman The following labels will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command. |
|
/label remove security |
|
@AlanBateman |
jaikiran
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The change looks OK to me.
bplb
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
|
/integrate |
|
Going to push as commit 32c7681.
Your commit was automatically rebased without conflicts. |
|
@AlanBateman Pushed as commit 32c7681. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
In preparation for JEP 471 and JEP 472, provide access to the initial value of System.err from JavaLangAccess. The initial value of System.in is already exposed to code in java.base with this shared secret.
Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/19171/head:pull/19171$ git checkout pull/19171Update a local copy of the PR:
$ git checkout pull/19171$ git pull https://git.openjdk.org/jdk.git pull/19171/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 19171View PR using the GUI difftool:
$ git pr show -t 19171Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/19171.diff
Webrev
Link to Webrev Comment