Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8332064: Implementation of Structured Concurrency (Third Preview) #19175

Closed
wants to merge 2 commits into from

Conversation

AlanBateman
Copy link
Contributor

@AlanBateman AlanBateman commented May 10, 2024

There aren't any API or implementations changes in third preview but the JEP number/title needs to be bumped for the javadoc page.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8332064: Implementation of Structured Concurrency (Third Preview) (Enhancement - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/19175/head:pull/19175
$ git checkout pull/19175

Update a local copy of the PR:
$ git checkout pull/19175
$ git pull https://git.openjdk.org/jdk.git pull/19175/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 19175

View PR using the GUI difftool:
$ git pr show -t 19175

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/19175.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented May 10, 2024

👋 Welcome back alanb! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented May 10, 2024

@AlanBateman This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8332064: Implementation of Structured Concurrency (Third Preview)

Reviewed-by: jpai, bpb, mcimadamore

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 20 new commits pushed to the master branch:

  • be1d374: 8332825: ubsan: guardedMemory.cpp:35:11: runtime error: null pointer passed as argument 2, which is declared to never be null
  • ed81a47: 8327964: Simplify BigInteger.implMultiplyToLen intrinsic
  • 08face8: 8332890: Module imports don't work inside the same module
  • 793fd72: 8332956: Problem list CodeCacheFullCountTest.java until JDK-8332954 is fixed
  • 891d5ae: 8332683: G1: G1CardSetArray::EntryDataType [2] triggers ubsan runtime errors
  • f3d6fbf: 8330847: G1 accesses uninitialized memory when predicting eden copy time
  • 1b8dea4: 8332894: ubsan: vmError.cpp:2090:26: runtime error: division by zero
  • 0e7ea39: 8332678: Serial: Remove use of should_clear_all_soft_refs in serial folder
  • 72fbfe1: 8330577: G1 sometimes sends jdk.G1HeapRegionTypeChange for non-changes
  • 0889155: 8332885: Clarify failure_handler self-tests
  • ... and 10 more: https://git.openjdk.org/jdk/compare/985b9ce79a2d620a8b8675d1ae6c9730d72a757f...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk
Copy link

openjdk bot commented May 10, 2024

@AlanBateman The following labels will be automatically applied to this pull request:

  • compiler
  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added core-libs core-libs-dev@openjdk.org compiler compiler-dev@openjdk.org labels May 10, 2024
@AlanBateman AlanBateman marked this pull request as ready for review May 10, 2024 13:25
@openjdk openjdk bot added the rfr Pull request is ready for review label May 10, 2024
@mlbridge
Copy link

mlbridge bot commented May 10, 2024

Webrevs

@openjdk openjdk bot added the ready Pull request is ready to be integrated label May 10, 2024
@AlanBateman
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented May 28, 2024

Going to push as commit e708d13.
Since your change was applied there have been 28 commits pushed to the master branch:

  • 7b52d0a: 8332265: RISC-V: Materialize pointers faster by using a temp register
  • aa4c83a: 8332505: JEP 457: ClassRemapper forgets to remap bootstrap method references
  • cabe337: 8331921: Hotspot assembler files should use common logic to setup exported functions
  • 2edb6d9: 8330386: Replace Opaque4Node of Initialized Assertion Predicate with new OpaqueInitializedAssertionPredicateNode
  • 1850914: 8332864: Parallel: Merge ParMarkBitMapClosure into MoveAndUpdateClosure
  • 2f2cf38: 8332883: Some simple cleanup in vectornode.cpp
  • b5e1615: 8292955: Collections.checkedMap Map.merge does not properly check key and value
  • 86eb5d9: 8329958: Windows x86 build fails: downcallLinker.cpp(36) redefinition
  • be1d374: 8332825: ubsan: guardedMemory.cpp:35:11: runtime error: null pointer passed as argument 2, which is declared to never be null
  • ed81a47: 8327964: Simplify BigInteger.implMultiplyToLen intrinsic
  • ... and 18 more: https://git.openjdk.org/jdk/compare/985b9ce79a2d620a8b8675d1ae6c9730d72a757f...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label May 28, 2024
@openjdk openjdk bot closed this May 28, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels May 28, 2024
@openjdk
Copy link

openjdk bot commented May 28, 2024

@AlanBateman Pushed as commit e708d13.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compiler compiler-dev@openjdk.org core-libs core-libs-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

4 participants