-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8332096: hotspot-ide-project fails with this-escape #19186
Conversation
👋 Welcome back amenkov! A progress list of the required criteria for merging this PR into |
@alexmenkov This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 12 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
@alexmenkov The following labels will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command. |
/integrate |
Going to push as commit 37c4778.
Your commit was automatically rebased without conflicts. |
@alexmenkov Pushed as commit 37c4778. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
The change fixes
make hotspot-ide-project
which fails withProgress
Warning
8332096: hotspot-ide-project fails with this-escape
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/19186/head:pull/19186
$ git checkout pull/19186
Update a local copy of the PR:
$ git checkout pull/19186
$ git pull https://git.openjdk.org/jdk.git pull/19186/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 19186
View PR using the GUI difftool:
$ git pr show -t 19186
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/19186.diff
Webrev
Link to Webrev Comment