Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8332100: Add missing @since to KeyValue::EC_TYPE in java.xml.crypto #19190

Closed
wants to merge 1 commit into from

Conversation

nizarbenalla
Copy link
Member

@nizarbenalla nizarbenalla commented May 11, 2024

Simple code cleanup. I split my changes into 1 PR per module to make reviewing simpler.
This was added back in JDK 13 and should have an @since
If you're reviewing this change, thanks!


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8332100: Add missing @<!---->since to KeyValue::EC_TYPE in java.xml.crypto (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/19190/head:pull/19190
$ git checkout pull/19190

Update a local copy of the PR:
$ git checkout pull/19190
$ git pull https://git.openjdk.org/jdk.git pull/19190/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 19190

View PR using the GUI difftool:
$ git pr show -t 19190

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/19190.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented May 11, 2024

👋 Welcome back nizarbenalla! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented May 11, 2024

@nizarbenalla This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8332100: Add missing `@since` to KeyValue::EC_TYPE in `java.xml.crypto`

Reviewed-by: mullan

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 61 new commits pushed to the master branch:

  • 1484153: 8332080: Update troff man page for javadoc
  • 391bbbc: 8330584: IGV: XML does not save all node properties
  • adaa509: 8327499: MethodHandleStatics.traceLambdaForm includes methods that cannot be generated
  • 5a8df41: 8331535: Incorrect prompt for Console.readLine
  • 3e3f7cf: 8330387: Crash with a different types patterns (primitive vs generic) in instanceof
  • d517d2d: 8331764: C2 SuperWord: refactor _align_to_ref/_mem_ref_for_main_loop_alignment
  • 5053b70: 8278255: Add more warning text in ReentrantLock and ReentrantReadWriteLock
  • 32c7681: 8332029: Provide access to initial value of stderr via JavaLangAccess
  • f9a1d33: 8332020: jwebserver tool prints invalid URL in case of IPv6 address binding
  • b87a7e9: 8144100: Incorrect case-sensitive equality in com.sun.net.httpserver.BasicAuthenticator
  • ... and 51 more: https://git.openjdk.org/jdk/compare/8af606fb8cdb3a6ecdfe4cddd79f228b64d5fc80...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@seanjmullan) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk
Copy link

openjdk bot commented May 11, 2024

@nizarbenalla The following label will be automatically applied to this pull request:

  • security

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the security security-dev@openjdk.org label May 11, 2024
@nizarbenalla nizarbenalla reopened this May 12, 2024
@nizarbenalla nizarbenalla marked this pull request as ready for review May 12, 2024 18:52
@openjdk openjdk bot added the rfr Pull request is ready for review label May 12, 2024
@mlbridge
Copy link

mlbridge bot commented May 12, 2024

Webrevs

@nizarbenalla
Copy link
Member Author

Thanks!

/integrate

@openjdk openjdk bot added ready Pull request is ready to be integrated sponsor Pull request is ready to be sponsored labels May 13, 2024
@openjdk
Copy link

openjdk bot commented May 13, 2024

@nizarbenalla
Your change (at version e8a1bac) is now ready to be sponsored by a Committer.

@seanjmullan
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented May 13, 2024

Going to push as commit abf54bb.
Since your change was applied there have been 61 commits pushed to the master branch:

  • 1484153: 8332080: Update troff man page for javadoc
  • 391bbbc: 8330584: IGV: XML does not save all node properties
  • adaa509: 8327499: MethodHandleStatics.traceLambdaForm includes methods that cannot be generated
  • 5a8df41: 8331535: Incorrect prompt for Console.readLine
  • 3e3f7cf: 8330387: Crash with a different types patterns (primitive vs generic) in instanceof
  • d517d2d: 8331764: C2 SuperWord: refactor _align_to_ref/_mem_ref_for_main_loop_alignment
  • 5053b70: 8278255: Add more warning text in ReentrantLock and ReentrantReadWriteLock
  • 32c7681: 8332029: Provide access to initial value of stderr via JavaLangAccess
  • f9a1d33: 8332020: jwebserver tool prints invalid URL in case of IPv6 address binding
  • b87a7e9: 8144100: Incorrect case-sensitive equality in com.sun.net.httpserver.BasicAuthenticator
  • ... and 51 more: https://git.openjdk.org/jdk/compare/8af606fb8cdb3a6ecdfe4cddd79f228b64d5fc80...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label May 13, 2024
@openjdk openjdk bot closed this May 13, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels May 13, 2024
@openjdk
Copy link

openjdk bot commented May 13, 2024

@seanjmullan @nizarbenalla Pushed as commit abf54bb.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@nizarbenalla nizarbenalla deleted the JDK-8332100 branch September 19, 2024 00:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated security security-dev@openjdk.org
Development

Successfully merging this pull request may close these issues.

2 participants