-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8332102: Add @since
to package-info of jdk.security.jarsigner
#19191
Conversation
👋 Welcome back nizarbenalla! A progress list of the required criteria for merging this PR into |
@nizarbenalla This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 8 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@wangweij) but any other Committer may sponsor as well. ➡️ To flag this PR as ready for integration with the above commit message, type |
@nizarbenalla The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks!
You're welcome /integrate |
@nizarbenalla |
/sponsor |
Going to push as commit ff4bf1c.
Your commit was automatically rebased without conflicts. |
@wangweij @nizarbenalla Pushed as commit ff4bf1c. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Code cleanup. The package was added back in 8056174.
Thanks to anyone reviewing this change. I split my changes into 1 PR per module to make reviewing simpler.
Progress
Issue
@<!---->since
to package-info ofjdk.security.jarsigner
(Bug - P4)Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/19191/head:pull/19191
$ git checkout pull/19191
Update a local copy of the PR:
$ git checkout pull/19191
$ git pull https://git.openjdk.org/jdk.git pull/19191/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 19191
View PR using the GUI difftool:
$ git pr show -t 19191
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/19191.diff
Webrev
Link to Webrev Comment