Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8253028: SA core file tests still time out on OSX with "java.io.IOException: App waiting timeout" #192

Closed
wants to merge 1 commit into from

Conversation

@plummercj
Copy link
Contributor

@plummercj plummercj commented Sep 15, 2020

Some SA core file testing requires longer timeouts since core files can on occasion take a very long time to produce on OSX.

I'd like to treat this as a trival change.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8253028: SA core file tests still time out on OSX with "java.io.IOException: App waiting timeout"

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/192/head:pull/192
$ git checkout pull/192

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Sep 15, 2020

👋 Welcome back cjplummer! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Sep 15, 2020

@plummercj The following label will be automatically applied to this pull request: serviceability.

When this pull request is ready to be reviewed, an RFR email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label (add|remove) "label" command.

Loading

@plummercj plummercj changed the title 8253028: SA core file tests still time out on OSX with "java.io.IOExc… 8253028: SA core file tests still time out on OSX with "java.io.IOException: App waiting timeout" Sep 15, 2020
@plummercj plummercj marked this pull request as ready for review Sep 15, 2020
@openjdk openjdk bot added the rfr label Sep 15, 2020
@mlbridge
Copy link

@mlbridge mlbridge bot commented Sep 15, 2020

Webrevs

Loading

@plummercj
Copy link
Contributor Author

@plummercj plummercj commented Sep 15, 2020

/test

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Sep 15, 2020

A test job has been started with id: github.com-149121954-192-692925066

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Sep 15, 2020

@plummercj your test job with id github.com-149121954-192-692925066 for commits up until 58d69da has finished.

Loading

@plummercj
Copy link
Contributor Author

@plummercj plummercj commented Sep 17, 2020

Ping! This change is trivial. Thanks!

Loading

Copy link

@alexmenkov alexmenkov left a comment

Agreed that this is trivial change

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Sep 17, 2020

@plummercj This change now passes all automated pre-integration checks. In addition to the automated checks, the change must also fulfill all project specific requirements

After integration, the commit message will be:

8253028: SA core file tests still time out on OSX with "java.io.IOException: App waiting timeout"

Reviewed-by: amenkov
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /issue command.

Since the source branch of this PR was last updated there have been 56 commits pushed to the master branch:

  • 6c3e483: 8253313: xmlstream.hpp missing from vmIntrinsics.cpp
  • 0a1dc50: 8253271: vm_version_x86.hpp should not include globals_extension.hpp
  • 1e39649: 8243066: Move VM_INTRINSICS_DO into its own vmIntrinsics.hpp file
  • 12dfe1c: 8253262: Allocate in DumpRegion is not thread safe
  • 3570f5a: 8252041: G1: Fix incorrect uses of HeapRegionManager::max_length
  • 24765e4: 8253285: Some java/util/StringJoiner tests do not explicitly specify required -XX:+CompactStrings
  • 81e2cf8: 8251397: NPE on ClassValue.ClassValueMap.cacheArray
  • cca3a26: 8252996: Thread safety problem in java.net.ProxySelector
  • a4c6a99: 8252593: [TESTBUG] serviceability/jvmti/GetLocalVariable/GetLocalWithoutSuspendTest.java failed with JVMTI_ERROR_INVALID_SLOT
  • a67f890: 8253050: jfr disassemble command processes --max-chunks incorrectly
  • ... and 46 more: https://git.openjdk.java.net/jdk/compare/68da63dcdead52418b41f80d381b105ce71a8162...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid automatic rebasing, please merge master into your branch, and then specify the current head hash when integrating, like this: /integrate 6c3e483b56094c0bd2cfe8c96604b7c805cb08b3.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

Loading

@openjdk openjdk bot added the ready label Sep 17, 2020
@plummercj
Copy link
Contributor Author

@plummercj plummercj commented Sep 17, 2020

/integrate

Loading

@openjdk openjdk bot closed this Sep 17, 2020
@openjdk openjdk bot added integrated and removed ready rfr labels Sep 17, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Sep 17, 2020

@plummercj Since your change was applied there have been 56 commits pushed to the master branch:

  • 6c3e483: 8253313: xmlstream.hpp missing from vmIntrinsics.cpp
  • 0a1dc50: 8253271: vm_version_x86.hpp should not include globals_extension.hpp
  • 1e39649: 8243066: Move VM_INTRINSICS_DO into its own vmIntrinsics.hpp file
  • 12dfe1c: 8253262: Allocate in DumpRegion is not thread safe
  • 3570f5a: 8252041: G1: Fix incorrect uses of HeapRegionManager::max_length
  • 24765e4: 8253285: Some java/util/StringJoiner tests do not explicitly specify required -XX:+CompactStrings
  • 81e2cf8: 8251397: NPE on ClassValue.ClassValueMap.cacheArray
  • cca3a26: 8252996: Thread safety problem in java.net.ProxySelector
  • a4c6a99: 8252593: [TESTBUG] serviceability/jvmti/GetLocalVariable/GetLocalWithoutSuspendTest.java failed with JVMTI_ERROR_INVALID_SLOT
  • a67f890: 8253050: jfr disassemble command processes --max-chunks incorrectly
  • ... and 46 more: https://git.openjdk.java.net/jdk/compare/68da63dcdead52418b41f80d381b105ce71a8162...master

Your commit was automatically rebased without conflicts.

Pushed as commit d4269fd.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Loading

@plummercj plummercj deleted the bugfix branch Oct 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants