-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8332032: C2: Remove ExpandSubTypeCheckAtParseTime flag #19205
Conversation
👋 Welcome back xiaotaonan! A progress list of the required criteria for merging this PR into |
❗ This change is not yet ready to be integrated. |
@xiaotaonan The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
/signed |
You are already a known contributor! |
Hi @xiaotaonan, please first ask in JBS if you can take over RFEs/bugs that are already assigned like this one, especially if it has just been filed. This PR misses the entire context why this flag should be removed and what the pros/cons and trade-offs are. I planned to do some more offline discussions first before proposing the actual PR to remove this flag since it is now related to an otherwise hard-to-fix bug in Valhalla. |
OK. |
The reviewers (maybe me) of the corresponding area will review your patch. So I don't think you need to CC me especially. |
Thanks for your understanding and letting me taking this PR over - I will propose this change again later this week (we first also need to update some internal stress jobs that use this flag). |
C2: Remove ExpandSubTypeCheckAtParseTime flag
Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/19205/head:pull/19205
$ git checkout pull/19205
Update a local copy of the PR:
$ git checkout pull/19205
$ git pull https://git.openjdk.org/jdk.git pull/19205/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 19205
View PR using the GUI difftool:
$ git pr show -t 19205
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/19205.diff
Webrev
Link to Webrev Comment