Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8332032: C2: Remove ExpandSubTypeCheckAtParseTime flag #19205

Closed
wants to merge 1 commit into from

Conversation

xiaotaonan
Copy link

@xiaotaonan xiaotaonan commented May 12, 2024

C2: Remove ExpandSubTypeCheckAtParseTime flag


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8332032: C2: Remove ExpandSubTypeCheckAtParseTime flag (Enhancement - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/19205/head:pull/19205
$ git checkout pull/19205

Update a local copy of the PR:
$ git checkout pull/19205
$ git pull https://git.openjdk.org/jdk.git pull/19205/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 19205

View PR using the GUI difftool:
$ git pr show -t 19205

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/19205.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented May 12, 2024

👋 Welcome back xiaotaonan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented May 12, 2024

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot added the rfr Pull request is ready for review label May 12, 2024
@openjdk
Copy link

openjdk bot commented May 12, 2024

@xiaotaonan The following label will be automatically applied to this pull request:

  • hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-compiler hotspot-compiler-dev@openjdk.org label May 12, 2024
@mlbridge
Copy link

mlbridge bot commented May 12, 2024

Webrevs

@xiaotaonan
Copy link
Author

@lgxbslgx

@xiaotaonan
Copy link
Author

/signed

@bridgekeeper
Copy link

bridgekeeper bot commented May 13, 2024

You are already a known contributor!

@chhagedorn
Copy link
Member

chhagedorn commented May 13, 2024

Hi @xiaotaonan, please first ask in JBS if you can take over RFEs/bugs that are already assigned like this one, especially if it has just been filed. This PR misses the entire context why this flag should be removed and what the pros/cons and trade-offs are. I planned to do some more offline discussions first before proposing the actual PR to remove this flag since it is now related to an otherwise hard-to-fix bug in Valhalla.

@xiaotaonan
Copy link
Author

please first ask in JBS if you can take over RFEs/bugs that are already assigned like this one, especially if it has just been filed. This PR misses the entire context why this flag should be removed and what the pros/cons and trade-offs are. I planned to do some more offline discussions first before proposing the actual PR to remove this flag since it is now related to an otherwise hard-to-fix bug in Valhalla.

OK.

@xiaotaonan xiaotaonan closed this May 13, 2024
@lgxbslgx
Copy link
Member

@lgxbslgx

The reviewers (maybe me) of the corresponding area will review your patch. So I don't think you need to CC me especially.

@chhagedorn
Copy link
Member

please first ask in JBS if you can take over RFEs/bugs that are already assigned like this one, especially if it has just been filed. This PR misses the entire context why this flag should be removed and what the pros/cons and trade-offs are. I planned to do some more offline discussions first before proposing the actual PR to remove this flag since it is now related to an otherwise hard-to-fix bug in Valhalla.

OK.

Thanks for your understanding and letting me taking this PR over - I will propose this change again later this week (we first also need to update some internal stress jobs that use this flag).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-compiler hotspot-compiler-dev@openjdk.org rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

3 participants