8193942: Regression automated test '/open/test/jdk/javax/swing/JFrame/8175301/ScaledFrameBackgroundTest.java' fails

[prsadhuk]

This test use to fail in macos in mach5 nightly testing long time back. It used to fail in ubuntu17.10 due to unsupported wayland display mode. Recent run of this test on supported platforms does not fail.
Modified the test slightly to be consistent with other test regarding robot delays, moved frame to center of screen.
Mach5 job running several iterations of the test in all platforms is ok. Link in JBS.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8193942: Regression automated test '/open/test/jdk/javax/swing/JFrame/8175301/ScaledFrameBackgroundTest.java' fails

Reviewers

• Sergey Bylokhov (@mrserb - Reviewer)

Download

$ git fetch https://git.openjdk.java.net/jdk pull/1923/head:pull/1923
$ git checkout pull/1923

[bridgekeeper]

👋 Welcome back psadhukhan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@prsadhuk The following label will be automatically applied to this pull request:

• swing

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (ef7f090)

[mrserb]

Please check that the test will work if the Windows uses 125% , see https://bugs.openjdk.java.net/browse/JDK-8193942?focusedCommentId=14150509&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-14150509

[prsadhuk]

Yes, it works

reason: User specified action: run main/othervm -Dsun.java2d.uiScale=1.25 -Dsun.java2d.d3d=true ScaledFrameBackgroundTest
Mode: othervm [/othervm specified]
Additional options from @modules: --add-modules java.desktop
elapsed time (seconds): 6.049
----------configuration:(3/43)----------
Boot Layer
  add modules: java.desktop

----------System.out:(0/0)----------
----------System.err:(1/16)----------
STATUS:Passed.

[mrserb]

reason: User specified action: run main/othervm -Dsun.java2d.uiScale=1.25 -Dsun.java2d.d3d=true

You have set it via the property, but the bug was reported on the system where the 125% dpi was set in the windows settings and the test was run as-is.

[prsadhuk]

I have tried that as well. In fact, my windows display setting is 125% and it worked without this property change in uiscale.

[mrserb]

Thank you for your confirmation. Looks fine.

[openjdk]

@prsadhuk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8193942: Regression automated test '/open/test/jdk/javax/swing/JFrame/8175301/ScaledFrameBackgroundTest.java' fails

Reviewed-by: serb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 8 new commits pushed to the master branch:

• 5ea9607: 8258459: Decouple gc_globals.hpp from globals.hpp
• 2499ac3: 8259069: Fields could be final
• f0aae81: 8259020: null-check of g1 write_ref_field_pre_entry is not necessary
• e6f9926: 8257809: JNI warnings from Toolkit JPEG image decoding
• 9d160aa: 8257815: Replace global log2 functions with efficient implementations
• f80c63b: 8258490: Shenandoah: Full GC does not need to remark threads and drain SATB buffers
• 7f04d23: 8258800: Deprecate -XX:+AlwaysLockClassLoader
• d679caa: 8196466: javax/swing/JFileChooser/8062561/bug8062561.java fails

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[prsadhuk]

/integrate

[openjdk]

@prsadhuk Since your change was applied there have been 26 commits pushed to the master branch:

• 52d3fee: 8258813: [TESTBUG] Fix incorrect Vector API test output message
• 8b45497: 8259037: livenmethods cannot find hsdis library
• 7d76966: 8255757: Javac emits duplicate pool entries on array::clone
• cf9908b: 8258937: Remove JVM IgnoreRewrites flag
• 4d3d599: 8259223: Simplify boolean expression in the SunJSSE provider
• 1b60acd: 8259252: Shenandoah: Shenandoah build failed on AArch64 after JDK-8258459
• 7ddc2b5: 8258852: Arrays.asList() for single item could be replaced with List.of()
• 85bac8c: 8259021: SharedSecrets should avoid double racy reads from non-volatile fields
• d5aa49d: 8259236: C2 compilation fails with assert(is_power_of_2(value)) failed: value must be a power of 2: 8000000000000000
• 82bdbfd: 8258857: Zero: non-PCH release build fails after JDK-8258074
• ... and 16 more: https://git.openjdk.java.net/jdk/compare/a2a3f4a3dcdf3aa7eb9f17d892d1ffe729733330...master

Your commit was automatically rebased without conflicts.

Pushed as commit 32538b5.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.