Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8332253: Linux arm32 build fails after 8292591 #19237

Closed
wants to merge 1 commit into from

Conversation

mrserb
Copy link
Member

@mrserb mrserb commented May 14, 2024

The build on arm32 may fail during cross-compilation if the toolchain is old.

The raw constant "389" is described here and here

Also verified by the next code example: test.c

Note: similar bugs in the past: #10771 and #10721


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8332253: Linux arm32 build fails after 8292591 (Bug - P3)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/19237/head:pull/19237
$ git checkout pull/19237

Update a local copy of the PR:
$ git checkout pull/19237
$ git pull https://git.openjdk.org/jdk.git pull/19237/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 19237

View PR using the GUI difftool:
$ git pr show -t 19237

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/19237.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented May 14, 2024

👋 Welcome back serb! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented May 14, 2024

@mrserb This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8332253: Linux arm32 build fails after 8292591

Reviewed-by: stuefe, dholmes, shade

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 7 new commits pushed to the master branch:

  • 2f10a31: 8302850: Implement C1 clone intrinsic that reuses arraycopy code for primitive arrays
  • c642f44: 8329839: Cleanup ZPhysicalMemoryBacking trace logging
  • d04ac14: 8332236: javac crashes with module imports and implicitly declared class
  • 4e77cf8: 8330795: C2: assert((uint)type <= T_CONFLICT && _zero_type[type] != nullptr) failed: bad type with -XX:-UseCompressedClassPointers
  • 7b4ba7f: 8325932: Replace ATTRIBUTE_NORETURN with direct [[noreturn]]
  • 0bb5ae6: 8332248: (fc) java/nio/channels/FileChannel/BlockDeviceSize.java failed with RuntimeException
  • 4d32c60: 8322008: Exclude some CDS tests from running with -Xshare:off

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk
Copy link

openjdk bot commented May 14, 2024

@mrserb The following label will be automatically applied to this pull request:

  • hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-runtime hotspot-runtime-dev@openjdk.org label May 14, 2024
@mrserb mrserb marked this pull request as ready for review May 14, 2024 22:02
@openjdk openjdk bot added the rfr Pull request is ready for review label May 14, 2024
@mlbridge
Copy link

mlbridge bot commented May 14, 2024

Webrevs

@dholmes-ora
Copy link
Member

How old a tool chain are we talking about? This issue would have been around since 09/2022 and nobody has complained?

@mrserb
Copy link
Member Author

mrserb commented May 15, 2024

How old a tool chain are we talking about?

According to the docs, it was added in Linux 4.3+(release date 2015), and updated in Linux 5.10(release date is 2020).

This issue would have been around since 09/2022 and nobody has complained?

It works fine for JDK 17, so probably people have not migrated to JDK 21+ yet.

Copy link
Member

@tstuefe tstuefe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@openjdk openjdk bot added the ready Pull request is ready to be integrated label May 15, 2024
@tstuefe
Copy link
Member

tstuefe commented May 15, 2024

How old a tool chain are we talking about? This issue would have been around since 09/2022 and nobody has complained?

You need to cross build to notice, that is pretty rare, most outsiders build natively. And you need an old tool chain, appearantly.
I build arm32 often as cross-compilation, certainly after 2022, and have not noticed an error.

Copy link
Member

@dholmes-ora dholmes-ora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay seems harmless enough.

@mrserb
Copy link
Member Author

mrserb commented May 16, 2024

/integrate

@openjdk
Copy link

openjdk bot commented May 16, 2024

Going to push as commit 95f79c6.
Since your change was applied there have been 23 commits pushed to the master branch:

  • b687aa5: 8332176: Refactor ClassListParser::parse()
  • 4083255: 8316138: Add GlobalSign 2 TLS root certificates
  • 43b109b: 8330066: HeapDumpPath and HeapDumpGzipLevel VM options do not mention HeapDumpBeforeFullGC and HeapDumpAfterFullGC
  • 7cff04f: 8330276: Console methods with explicit Locale
  • 8a4315f: 8331987: Enhance stacktrace clarity for CompletableFuture CancellationException
  • 491b3b4: 8332256: Shenandoah: Do not visit heap threads during shutdown
  • 9c02c8d: 8332255: Shenandoah: Remove duplicate definition of init mark closure
  • 42ccb74: 8331940: ClassFile API ArrayIndexOutOfBoundsException with certain class files
  • 61aff6d: 8332112: Update nsk.share.Log to don't print summary during VM shutdown hook
  • 30bb066: 8332003: Clarify javadoc for MemoryLayout::offsetHandle
  • ... and 13 more: https://git.openjdk.org/jdk/compare/e91492ab4333c61f39b50eb428fa932131a5b908...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label May 16, 2024
@openjdk openjdk bot closed this May 16, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels May 16, 2024
@openjdk
Copy link

openjdk bot commented May 16, 2024

@mrserb Pushed as commit 95f79c6.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@mrserb mrserb deleted the JDK-8332253 branch May 16, 2024 02:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-runtime hotspot-runtime-dev@openjdk.org integrated Pull request has been integrated
4 participants