Skip to content

8332255: Shenandoah: Remove duplicate definition of init mark closure #19238

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

earthling-amzn
Copy link
Contributor

@earthling-amzn earthling-amzn commented May 14, 2024


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8332255: Shenandoah: Remove duplicate definition of init mark closure (Task - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/19238/head:pull/19238
$ git checkout pull/19238

Update a local copy of the PR:
$ git checkout pull/19238
$ git pull https://git.openjdk.org/jdk.git pull/19238/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 19238

View PR using the GUI difftool:
$ git pr show -t 19238

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/19238.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented May 14, 2024

👋 Welcome back wkemper! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented May 14, 2024

@earthling-amzn This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8332255: Shenandoah: Remove duplicate definition of init mark closure

Reviewed-by: shade, kdnilsen

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 14 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk
Copy link

openjdk bot commented May 14, 2024

@earthling-amzn The following labels will be automatically applied to this pull request:

  • hotspot-gc
  • shenandoah

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added hotspot-gc hotspot-gc-dev@openjdk.org shenandoah shenandoah-dev@openjdk.org rfr Pull request is ready for review labels May 14, 2024
@mlbridge
Copy link

mlbridge bot commented May 14, 2024

Webrevs

Copy link
Member

@shipilev shipilev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, gotta love the C++ flexibility. Nice catch, looks fine.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label May 15, 2024
@earthling-amzn
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented May 15, 2024

Going to push as commit 9c02c8d.
Since your change was applied there have been 16 commits pushed to the master branch:

  • 42ccb74: 8331940: ClassFile API ArrayIndexOutOfBoundsException with certain class files
  • 61aff6d: 8332112: Update nsk.share.Log to don't print summary during VM shutdown hook
  • 30bb066: 8332003: Clarify javadoc for MemoryLayout::offsetHandle
  • c4867c6: 8329273: C2 SuperWord: Some basic MemorySegment IR tests
  • 8032d64: 8332245: C2: missing record_for_ign() call in GraphKit::must_be_not_null()
  • fa043ae: 8294880: Review running time of jdk/internal/shellsupport/doc/JavadocHelperTest.java
  • a5005c8: 8330814: Cleanups for KeepAliveCache tests
  • 1a94447: 8332111: [BACKOUT] A way to align already compiled methods with compiler directives
  • 957eb61: 8331429: [JVMCI] Cleanup JVMCIRuntime allocation routines
  • 2f10a31: 8302850: Implement C1 clone intrinsic that reuses arraycopy code for primitive arrays
  • ... and 6 more: https://git.openjdk.org/jdk/compare/e91492ab4333c61f39b50eb428fa932131a5b908...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label May 15, 2024
@openjdk openjdk bot closed this May 15, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels May 15, 2024
@openjdk
Copy link

openjdk bot commented May 15, 2024

@earthling-amzn Pushed as commit 9c02c8d.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-gc hotspot-gc-dev@openjdk.org integrated Pull request has been integrated shenandoah shenandoah-dev@openjdk.org
Development

Successfully merging this pull request may close these issues.

3 participants