8307778: com/sun/jdi/cds tests fail with jtreg's Virtual test thread factory

[jaikiran]

Can I please get a review of this change which removes the test/jdk/com/sun/jdi/cds/ tests from being problem listed when jtreg launches these tests through a virtual thread?

These tests aren't actually incompatible with virtual threads. The real issue is that in https://bugs.openjdk.org/browse/JDK-8305608, a test infrastructure class test/jdk/com/sun/jdi/VMConnection.java was changed to use the test.class.path system property instead of the previously used test.classes.

That change missed out updating the test/jdk/com/sun/jdi/cds/ tests to pass along the classpath through the test.class.path system property. As a result these tests still use the old test.classes system property to pass around the test classpath and thus causes these tests to fail. The reason why this only impacts virtual threads is noted by Chris in this JBS comment https://bugs.openjdk.org/browse/JDK-8305608?focusedId=14572100&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14572100.

The commit in this PR updates the CDSJDITest to pass along test.class.path instead of test.classes. The CDSJDITest is only used in the tests under test/jdk/com/sun/jdi/cds/, so nothing else should be impacted by this change.

I ran these changes against both launching with platform thread as well as virtual thread and these tests now pass in both these cases.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Warning

 ⚠️ Found leading lowercase letter in issue title for 8307778: com/sun/jdi/cds tests fail with jtreg's Virtual test thread factory

Issue

• JDK-8307778: com/sun/jdi/cds tests fail with jtreg's Virtual test thread factory (Bug - P4)

Reviewers

• David Holmes (@dholmes-ora - Reviewer)
• Serguei Spitsyn (@sspitsyn - Reviewer)
• Chris Plummer (@plummercj - Reviewer)
• Leonid Mesnik (@lmesnik - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/19244/head:pull/19244
$ git checkout pull/19244

Update a local copy of the PR:
$ git checkout pull/19244
$ git pull https://git.openjdk.org/jdk.git pull/19244/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 19244

View PR using the GUI difftool:
$ git pr show -t 19244

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/19244.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back jpai! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@jaikiran This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8307778: com/sun/jdi/cds tests fail with jtreg's Virtual test thread factory

Reviewed-by: dholmes, sspitsyn, cjplummer, lmesnik

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 25 new commits pushed to the master branch:

• b687aa5: 8332176: Refactor ClassListParser::parse()
• 4083255: 8316138: Add GlobalSign 2 TLS root certificates
• 43b109b: 8330066: HeapDumpPath and HeapDumpGzipLevel VM options do not mention HeapDumpBeforeFullGC and HeapDumpAfterFullGC
• 7cff04f: 8330276: Console methods with explicit Locale
• 8a4315f: 8331987: Enhance stacktrace clarity for CompletableFuture CancellationException
• 491b3b4: 8332256: Shenandoah: Do not visit heap threads during shutdown
• 9c02c8d: 8332255: Shenandoah: Remove duplicate definition of init mark closure
• 42ccb74: 8331940: ClassFile API ArrayIndexOutOfBoundsException with certain class files
• 61aff6d: 8332112: Update nsk.share.Log to don't print summary during VM shutdown hook
• 30bb066: 8332003: Clarify javadoc for MemoryLayout::offsetHandle
• ... and 15 more: https://git.openjdk.org/jdk/compare/5a4415a6bddb25cbd5b87ff8ad1a06179c2e452e...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@jaikiran The following label will be automatically applied to this pull request:

• serviceability

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (2f0e92d4)

[dholmes-ora]

Looks good.

Thanks

[sspitsyn]

Looks good.

[plummercj]

Changes look good. I think the CR needs a better title. Something that mentions "Virtual". Also, it's not the "test factory" we are talking about here. It is the "test thread factory".

[jaikiran]

Thank you all for the reviews.

I think the CR needs a better title. Something that mentions "Virtual". Also, it's not the "test factory" we are talking about here. It is the "test thread factory".

I have now updated the title of the JBS issue (and this PR) to "com/sun/jdi/cds tests fail with jtreg's Virtual test thread factory". No other changes have been done. I'll integrate this in a few hours from now.

[jaikiran]

/integrate

[openjdk]

Going to push as commit fe8a2af.
Since your change was applied there have been 26 commits pushed to the master branch:

• 95f79c6: 8332253: Linux arm32 build fails after 8292591
• b687aa5: 8332176: Refactor ClassListParser::parse()
• 4083255: 8316138: Add GlobalSign 2 TLS root certificates
• 43b109b: 8330066: HeapDumpPath and HeapDumpGzipLevel VM options do not mention HeapDumpBeforeFullGC and HeapDumpAfterFullGC
• 7cff04f: 8330276: Console methods with explicit Locale
• 8a4315f: 8331987: Enhance stacktrace clarity for CompletableFuture CancellationException
• 491b3b4: 8332256: Shenandoah: Do not visit heap threads during shutdown
• 9c02c8d: 8332255: Shenandoah: Remove duplicate definition of init mark closure
• 42ccb74: 8331940: ClassFile API ArrayIndexOutOfBoundsException with certain class files
• 61aff6d: 8332112: Update nsk.share.Log to don't print summary during VM shutdown hook
• ... and 16 more: https://git.openjdk.org/jdk/compare/5a4415a6bddb25cbd5b87ff8ad1a06179c2e452e...master

Your commit was automatically rebased without conflicts.

[openjdk]

@jaikiran Pushed as commit fe8a2af.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.