8331851: Add specific regression leap year tests for Calendar.roll()

[serhiysachkov]

Add specific regression tests for Calendar.roll() method to explicitly various leap year test scenarios. This is inspired by the ambiguity which occurred in leap year unaware test creation as in case with Calendar.add() in swing component test case as detailed in (https://bugs.openjdk.org/browse/JDK-8327088).

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8331851: Add specific regression leap year tests for Calendar.roll() (Task - P4)

Reviewers

• Naoto Sato (@naotoj - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/19247/head:pull/19247
$ git checkout pull/19247

Update a local copy of the PR:
$ git checkout pull/19247
$ git pull https://git.openjdk.org/jdk.git pull/19247/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 19247

View PR using the GUI difftool:
$ git pr show -t 19247

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/19247.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back serhiysachkov! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@serhiysachkov This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8331851: Add specific regression leap year tests for Calendar.roll()

Reviewed-by: naoto

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 51 new commits pushed to the master branch:

• b92bd67: 8332403: Anachronistic reference to Netscape Communicator in Swing API docs
• 8acdd2d: 8330565: C2: Multiple crashes with CTW after JDK-8316991
• 0a58cff: 8298405: Implement JEP 467: Markdown Documentation Comments
• 39a55e9: 8324809: compiler can crash with SOE while proving if two recursive types are disjoint
• b7ae0ae: 8328572: JFR: Use Class.forPrimitiveName(String)
• e611151: 8331281: RISC-V: C2: Support vector-scalar and vector-immediate bitwise logic instructions
• 44bdf99: 8332239: Improve CSS for block tags
• 9bb6169: 8317621: --add-script should support JavaScript modules
• 4eb1eaf: 8329617: Update stylesheet for specs and tool documentation
• d4c2edf: 8331855: Convert jdk.jdeps jdeprscan and jdeps to use the Classfile API
• ... and 41 more: https://git.openjdk.org/jdk/compare/2f10a316ff0c5a4c124b94f6fabb38fb119d2c82...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@naotoj) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[openjdk]

@serhiysachkov The following labels will be automatically applied to this pull request:

• core-libs
• i18n

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (0fff95ba)

[naotoj]

LGTM. I might want to remove those test case names as they are apparent from the parameters, but it's OK.

[serhiysachkov]

/integrate

[openjdk]

@serhiysachkov
Your change (at version 0fff95b) is now ready to be sponsored by a Committer.

[mahendrachhipa]

/sponsor

[openjdk]

Going to push as commit d6b7f9b.
Since your change was applied there have been 51 commits pushed to the master branch:

• b92bd67: 8332403: Anachronistic reference to Netscape Communicator in Swing API docs
• 8acdd2d: 8330565: C2: Multiple crashes with CTW after JDK-8316991
• 0a58cff: 8298405: Implement JEP 467: Markdown Documentation Comments
• 39a55e9: 8324809: compiler can crash with SOE while proving if two recursive types are disjoint
• b7ae0ae: 8328572: JFR: Use Class.forPrimitiveName(String)
• e611151: 8331281: RISC-V: C2: Support vector-scalar and vector-immediate bitwise logic instructions
• 44bdf99: 8332239: Improve CSS for block tags
• 9bb6169: 8317621: --add-script should support JavaScript modules
• 4eb1eaf: 8329617: Update stylesheet for specs and tool documentation
• d4c2edf: 8331855: Convert jdk.jdeps jdeprscan and jdeps to use the Classfile API
• ... and 41 more: https://git.openjdk.org/jdk/compare/2f10a316ff0c5a4c124b94f6fabb38fb119d2c82...master

Your commit was automatically rebased without conflicts.

[openjdk]

@mahendrachhipa @serhiysachkov Pushed as commit d6b7f9b.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.