Skip to content

8316138: Add GlobalSign 2 TLS root certificates #19252

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

rhalade
Copy link
Member

@rhalade rhalade commented May 15, 2024

This PR is to add two new TLS root certificates from GlobalSign. This CA has gone through https://www.oracle.com/java/technologies/javase/carootcertsprogram.html process.

The release-note is at JDK-8331979


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8316138: Add GlobalSign 2 TLS root certificates (Enhancement - P3)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/19252/head:pull/19252
$ git checkout pull/19252

Update a local copy of the PR:
$ git checkout pull/19252
$ git pull https://git.openjdk.org/jdk.git pull/19252/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 19252

View PR using the GUI difftool:
$ git pr show -t 19252

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/19252.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented May 15, 2024

👋 Welcome back rhalade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented May 15, 2024

@rhalade This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8316138: Add GlobalSign 2 TLS root certificates

Reviewed-by: mullan

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 106 new commits pushed to the master branch:

  • 43b109b: 8330066: HeapDumpPath and HeapDumpGzipLevel VM options do not mention HeapDumpBeforeFullGC and HeapDumpAfterFullGC
  • 7cff04f: 8330276: Console methods with explicit Locale
  • 8a4315f: 8331987: Enhance stacktrace clarity for CompletableFuture CancellationException
  • 491b3b4: 8332256: Shenandoah: Do not visit heap threads during shutdown
  • 9c02c8d: 8332255: Shenandoah: Remove duplicate definition of init mark closure
  • 42ccb74: 8331940: ClassFile API ArrayIndexOutOfBoundsException with certain class files
  • 61aff6d: 8332112: Update nsk.share.Log to don't print summary during VM shutdown hook
  • 30bb066: 8332003: Clarify javadoc for MemoryLayout::offsetHandle
  • c4867c6: 8329273: C2 SuperWord: Some basic MemorySegment IR tests
  • 8032d64: 8332245: C2: missing record_for_ign() call in GraphKit::must_be_not_null()
  • ... and 96 more: https://git.openjdk.org/jdk/compare/3b8227ba24c7bc05a8ea23801e3816e8fc80de4e...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the rfr Pull request is ready for review label May 15, 2024
@openjdk
Copy link

openjdk bot commented May 15, 2024

@rhalade The following label will be automatically applied to this pull request:

  • security

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the security security-dev@openjdk.org label May 15, 2024
@mlbridge
Copy link

mlbridge bot commented May 15, 2024

Webrevs

@openjdk openjdk bot added the ready Pull request is ready to be integrated label May 15, 2024
@rhalade
Copy link
Member Author

rhalade commented May 15, 2024

/integrate

@openjdk
Copy link

openjdk bot commented May 15, 2024

Going to push as commit 4083255.
Since your change was applied there have been 106 commits pushed to the master branch:

  • 43b109b: 8330066: HeapDumpPath and HeapDumpGzipLevel VM options do not mention HeapDumpBeforeFullGC and HeapDumpAfterFullGC
  • 7cff04f: 8330276: Console methods with explicit Locale
  • 8a4315f: 8331987: Enhance stacktrace clarity for CompletableFuture CancellationException
  • 491b3b4: 8332256: Shenandoah: Do not visit heap threads during shutdown
  • 9c02c8d: 8332255: Shenandoah: Remove duplicate definition of init mark closure
  • 42ccb74: 8331940: ClassFile API ArrayIndexOutOfBoundsException with certain class files
  • 61aff6d: 8332112: Update nsk.share.Log to don't print summary during VM shutdown hook
  • 30bb066: 8332003: Clarify javadoc for MemoryLayout::offsetHandle
  • c4867c6: 8329273: C2 SuperWord: Some basic MemorySegment IR tests
  • 8032d64: 8332245: C2: missing record_for_ign() call in GraphKit::must_be_not_null()
  • ... and 96 more: https://git.openjdk.org/jdk/compare/3b8227ba24c7bc05a8ea23801e3816e8fc80de4e...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label May 15, 2024
@openjdk openjdk bot closed this May 15, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels May 15, 2024
@openjdk
Copy link

openjdk bot commented May 15, 2024

@rhalade Pushed as commit 4083255.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated security security-dev@openjdk.org
Development

Successfully merging this pull request may close these issues.

2 participants