Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8332424: Update IANA Language Subtag Registry to Version 2024-05-16 #19286

Conversation

justin-curtis-lu
Copy link
Member

@justin-curtis-lu justin-curtis-lu commented May 17, 2024

Please review this PR which is a trivial update to the IANA sub tag registry to version 2024-05-16. Locale tests pass as expected after update.

Associated announcement -> https://mm.icann.org/pipermail/ietf-languages-announcements/2024-May/000091.html


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8332424: Update IANA Language Subtag Registry to Version 2024-05-16 (Enhancement - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/19286/head:pull/19286
$ git checkout pull/19286

Update a local copy of the PR:
$ git checkout pull/19286
$ git pull https://git.openjdk.org/jdk.git pull/19286/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 19286

View PR using the GUI difftool:
$ git pr show -t 19286

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/19286.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented May 17, 2024

👋 Welcome back jlu! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented May 17, 2024

@justin-curtis-lu This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8332424: Update IANA Language Subtag Registry to Version 2024-05-16

Reviewed-by: naoto, iris

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • 0a58cff: 8298405: Implement JEP 467: Markdown Documentation Comments

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title JDK-8332424: Update IANA Language Subtag Registry to Version 2024-05-16 8332424: Update IANA Language Subtag Registry to Version 2024-05-16 May 17, 2024
@openjdk openjdk bot added the rfr Pull request is ready for review label May 17, 2024
@openjdk
Copy link

openjdk bot commented May 17, 2024

@justin-curtis-lu The following labels will be automatically applied to this pull request:

  • core-libs
  • i18n

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added core-libs core-libs-dev@openjdk.org i18n i18n-dev@openjdk.org labels May 17, 2024
@mlbridge
Copy link

mlbridge bot commented May 17, 2024

Webrevs

Copy link
Member

@naotoj naotoj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@openjdk openjdk bot added the ready Pull request is ready to be integrated label May 17, 2024
@justin-curtis-lu
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Jun 3, 2024

Going to push as commit 6dac8d6.
Since your change was applied there have been 215 commits pushed to the master branch:

  • 9686e80: 8333103: Re-examine the console provider loading
  • 4de6207: 8333229: Parallel: Rename ParMarkBitMap::_region_start to _heap_start
  • 1f9e629: 8333434: IGV: Print loop node for PHASE_BEFORE/AFTER_CLOOPS
  • 27af19d: 8332586: Avoid cloning empty arrays in java.lang.reflect.{Method,Constructor}
  • 1c514b3: 8325435: [macos] Menu or JPopupMenu not closed when main window is resized
  • d07e530: 8333128: Linux x86_32 configure fail with --with-hsdis=binutils --with-binutils-src
  • f0bffbc: 8333301: Remove static builds using --enable-static-build
  • b101586: 8332514: Allow class space size to be larger than 3GB
  • 5ed0d52: 8332936: Test vmTestbase/metaspace/gc/watermark_70_80/TestDescription.java fails with no GC's recorded
  • 91101f0: 8333353: Delete extra empty line in CodeBlob.java
  • ... and 205 more: https://git.openjdk.org/jdk/compare/39a55e97799b5328da85aaa66c8d23175b305691...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jun 3, 2024
@openjdk openjdk bot closed this Jun 3, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jun 3, 2024
@openjdk
Copy link

openjdk bot commented Jun 3, 2024

@justin-curtis-lu Pushed as commit 6dac8d6.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core-libs core-libs-dev@openjdk.org i18n i18n-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

3 participants