Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8331683: Clean up GetCarrierThread #19289

Closed
wants to merge 1 commit into from

Conversation

alexmenkov
Copy link

@alexmenkov alexmenkov commented May 18, 2024

JVMTI GetCarrierThread extension function was introduced by loom for testing.
It's used by several tests in hotspot/jtreg/serviceability.

Testings: tier1..tier6


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8331683: Clean up GetCarrierThread (Enhancement - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/19289/head:pull/19289
$ git checkout pull/19289

Update a local copy of the PR:
$ git checkout pull/19289
$ git pull https://git.openjdk.org/jdk.git pull/19289/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 19289

View PR using the GUI difftool:
$ git pr show -t 19289

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/19289.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented May 18, 2024

👋 Welcome back amenkov! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented May 18, 2024

@alexmenkov This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8331683: Clean up GetCarrierThread

Reviewed-by: sspitsyn, cjplummer

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 104 new commits pushed to the master branch:

  • 52eda79: 8332538: Switch off JIT memory limit check for TestAlignVectorFuzzer.java
  • d999b81: 8331572: Allow using OopMapCache outside of STW GC phases
  • 8291c94: 8331224: ClassCastException in ObjectInputStream hides ClassNotFoundException
  • 42e3c84: 8332086: Remove the usage of ServiceLoader in j.u.r.RandomGeneratorFactory
  • 5cf8288: 8332153: RISC-V: enable tests and add comment for vector shift instruct (shared by vectorization and Vector API)
  • ae9ad86: 8331934: [s390x] Add support for primitive array C1 clone intrinsic
  • 3479b46: 8332595: Serial: Remove unused TenuredGeneration::should_collect
  • 9bfae88: 8332297: annotation processor that generates records sometimes fails due to NPE in javac
  • 4e169d1: 8332401: G1: TestFromCardCacheIndex.java with -XX:GCCardSizeInBytes=128 triggers underflow assertion
  • 7ffc999: 8332498: [aarch64, x86] improving OpToAssembly output for partialSubtypeCheckConstSuper Instruct
  • ... and 94 more: https://git.openjdk.org/jdk/compare/5e8e8ef6565e82a23626fe16893f93870dae1012...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title JDK-8331683: Clean up GetCarrierThread 8331683: Clean up GetCarrierThread May 18, 2024
@openjdk openjdk bot added the rfr Pull request is ready for review label May 18, 2024
@openjdk
Copy link

openjdk bot commented May 18, 2024

@alexmenkov The following labels will be automatically applied to this pull request:

  • hotspot
  • serviceability

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added serviceability serviceability-dev@openjdk.org hotspot hotspot-dev@openjdk.org labels May 18, 2024
@mlbridge
Copy link

mlbridge bot commented May 18, 2024

Webrevs

Copy link
Contributor

@sspitsyn sspitsyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label May 20, 2024
@alexmenkov
Copy link
Author

/integrate

@openjdk
Copy link

openjdk bot commented May 24, 2024

Going to push as commit 424eb60.
Since your change was applied there have been 142 commits pushed to the master branch:

  • 9b1d6d6: 8316328: Test jdk/jfr/event/oldobject/TestSanityDefault.java times out for some heap sizes
  • f8a3e4e: 8328998: Encoding support for Intel APX extended general-purpose registers
  • ddd73b4: 8332082: Shenandoah: Use consistent tests to determine when pre-write barrier is active
  • 0a9d1f8: 8332749: Broken link in MemorySegment.Scope.html
  • c9a7b97: 8332829: [BACKOUT] C2: crash in compiled code because of dependency on removed range check CastIIs
  • 7fd9d6c: 8332340: Add JavacBench as a test case for CDS
  • 417d174: 8331348: Some incremental builds deposit files in the make directory
  • 303ac9f: 8332671: Logging for pretouching thread stacks shows wrong memory range
  • 90758f6: 8332808: Always set java.io.tmpdir to a suitable value in the build
  • e19a421: 8332720: ubsan: instanceKlass.cpp:3550:76: runtime error: member call on null pointer of type 'struct Array'
  • ... and 132 more: https://git.openjdk.org/jdk/compare/5e8e8ef6565e82a23626fe16893f93870dae1012...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label May 24, 2024
@openjdk openjdk bot closed this May 24, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels May 24, 2024
@openjdk
Copy link

openjdk bot commented May 24, 2024

@alexmenkov Pushed as commit 424eb60.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@alexmenkov alexmenkov deleted the GetCarrierThread branch May 24, 2024 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot hotspot-dev@openjdk.org integrated Pull request has been integrated serviceability serviceability-dev@openjdk.org
Development

Successfully merging this pull request may close these issues.

3 participants