-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8332495: java/util/logging/LoggingDeadlock2.java fails with AssertionError: Some tests failed #19298
Conversation
…Error: Some tests failed
👋 Welcome back aboldtch! A progress list of the required criteria for merging this PR into |
@xmas92 This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the ➡️ To integrate this PR with the above commit message to the |
Webrevs
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The change looks OK to me. The copyright year on the file will need an update.
Thanks for the reviews. |
Going to push as commit 9f77793.
Your commit was automatically rebased without conflicts. |
Improve
java/util/logging/LoggingDeadlock2.java
stderr parsing by ignoring deprecated warnings. Testing non-generational ZGC requires the use of a deprecated option.Progress
Warning
8332495: java/util/logging/LoggingDeadlock2.java fails with AssertionError: Some tests failed
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/19298/head:pull/19298
$ git checkout pull/19298
Update a local copy of the PR:
$ git checkout pull/19298
$ git pull https://git.openjdk.org/jdk.git pull/19298/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 19298
View PR using the GUI difftool:
$ git pr show -t 19298
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/19298.diff
Webrev
Link to Webrev Comment