Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8332495: java/util/logging/LoggingDeadlock2.java fails with AssertionError: Some tests failed #19298

Closed
wants to merge 2 commits into from

Conversation

xmas92
Copy link
Member

@xmas92 xmas92 commented May 20, 2024

Improve java/util/logging/LoggingDeadlock2.java stderr parsing by ignoring deprecated warnings. Testing non-generational ZGC requires the use of a deprecated option.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Warning

 ⚠️ Found leading lowercase letter in issue title for 8332495: java/util/logging/LoggingDeadlock2.java fails with AssertionError: Some tests failed

Issue

  • JDK-8332495: java/util/logging/LoggingDeadlock2.java fails with AssertionError: Some tests failed (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/19298/head:pull/19298
$ git checkout pull/19298

Update a local copy of the PR:
$ git checkout pull/19298
$ git pull https://git.openjdk.org/jdk.git pull/19298/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 19298

View PR using the GUI difftool:
$ git pr show -t 19298

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/19298.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented May 20, 2024

👋 Welcome back aboldtch! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented May 20, 2024

@xmas92 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8332495: java/util/logging/LoggingDeadlock2.java fails with AssertionError: Some tests failed

Reviewed-by: jpai, stefank

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the rfr Pull request is ready for review label May 20, 2024
@openjdk
Copy link

openjdk bot commented May 20, 2024

@xmas92 The following label will be automatically applied to this pull request:

  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the core-libs core-libs-dev@openjdk.org label May 20, 2024
@mlbridge
Copy link

mlbridge bot commented May 20, 2024

Webrevs

Copy link
Member

@jaikiran jaikiran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change looks OK to me. The copyright year on the file will need an update.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label May 20, 2024
@xmas92
Copy link
Member Author

xmas92 commented May 21, 2024

Thanks for the reviews.
/integrate

@openjdk
Copy link

openjdk bot commented May 21, 2024

Going to push as commit 9f77793.
Since your change was applied there have been 5 commits pushed to the master branch:

  • fb45bab: 8075917: The regression-swing case failed as the text on label is not painted red with the GTK L&F
  • 6e80512: 8332545: Fix handling of HTML5 entities in Markdown comments
  • b78613b: 8332154: Memory leak in SynchronousQueue
  • 7652f98: 8331885: C2: meet between unloaded and speculative types is not symmetric
  • d6b7f9b: 8331851: Add specific regression leap year tests for Calendar.roll()

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label May 21, 2024
@openjdk openjdk bot closed this May 21, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels May 21, 2024
@openjdk
Copy link

openjdk bot commented May 21, 2024

@xmas92 Pushed as commit 9f77793.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core-libs core-libs-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

3 participants