Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8259049: Uninitialized variable after JDK-8257513 #1930

Closed
wants to merge 1 commit into from

Conversation

@chhagedorn
Copy link
Member

@chhagedorn chhagedorn commented Jan 4, 2021

Fixing missing initialization to prevent possible compiler warnings. The initialization is not required for correctness, though.

Thanks,
Christian


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8259049: Uninitialized variable after JDK-8257513

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/1930/head:pull/1930
$ git checkout pull/1930

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Jan 4, 2021

👋 Welcome back chagedorn! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

Loading

@openjdk openjdk bot added the rfr label Jan 4, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jan 4, 2021

@chhagedorn The following label will be automatically applied to this pull request:

  • hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

Loading

@mlbridge
Copy link

@mlbridge mlbridge bot commented Jan 4, 2021

Webrevs

Loading

Copy link
Contributor

@vnkozlov vnkozlov left a comment

Trivial.

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Jan 4, 2021

@chhagedorn This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8259049: Uninitialized variable after JDK-8257513

Reviewed-by: kvn, thartmann

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 11 new commits pushed to the master branch:

  • db6f393: 8251944: Add Shenandoah test config to compiler/gcbarriers/UnsafeIntrinsicsTest.java
  • 3817c32: 8258534: Epsilon: clean up unused includes
  • 17d1645: 8258751: Improve ExceptionHandlerTable dump
  • dd8996c: 8258946: Fix optimization-unstable code involving signed integer overflow
  • 5ea9607: 8258459: Decouple gc_globals.hpp from globals.hpp
  • 2499ac3: 8259069: Fields could be final
  • f0aae81: 8259020: null-check of g1 write_ref_field_pre_entry is not necessary
  • e6f9926: 8257809: JNI warnings from Toolkit JPEG image decoding
  • 9d160aa: 8257815: Replace global log2 functions with efficient implementations
  • f80c63b: 8258490: Shenandoah: Full GC does not need to remark threads and drain SATB buffers
  • ... and 1 more: https://git.openjdk.java.net/jdk/compare/d679caa28d5b2c8e9a385d57323f2f03a77ec1ba...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

Loading

@openjdk openjdk bot added the ready label Jan 4, 2021
@chhagedorn
Copy link
Member Author

@chhagedorn chhagedorn commented Jan 5, 2021

Thanks @vnkozlov and @TobiHartmann !

Loading

@chhagedorn
Copy link
Member Author

@chhagedorn chhagedorn commented Jan 5, 2021

/integrate

Loading

@openjdk openjdk bot closed this Jan 5, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Jan 5, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jan 5, 2021

@chhagedorn Since your change was applied there have been 11 commits pushed to the master branch:

  • db6f393: 8251944: Add Shenandoah test config to compiler/gcbarriers/UnsafeIntrinsicsTest.java
  • 3817c32: 8258534: Epsilon: clean up unused includes
  • 17d1645: 8258751: Improve ExceptionHandlerTable dump
  • dd8996c: 8258946: Fix optimization-unstable code involving signed integer overflow
  • 5ea9607: 8258459: Decouple gc_globals.hpp from globals.hpp
  • 2499ac3: 8259069: Fields could be final
  • f0aae81: 8259020: null-check of g1 write_ref_field_pre_entry is not necessary
  • e6f9926: 8257809: JNI warnings from Toolkit JPEG image decoding
  • 9d160aa: 8257815: Replace global log2 functions with efficient implementations
  • f80c63b: 8258490: Shenandoah: Full GC does not need to remark threads and drain SATB buffers
  • ... and 1 more: https://git.openjdk.java.net/jdk/compare/d679caa28d5b2c8e9a385d57323f2f03a77ec1ba...master

Your commit was automatically rebased without conflicts.

Pushed as commit 9f15164.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Loading

@chhagedorn chhagedorn deleted the JDK-8259049 branch Jan 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants