Skip to content

Conversation

@dougxc
Copy link
Member

@dougxc dougxc commented May 22, 2024

This PR adds a few extra JVMCI events that should help diagnose crashes when translating an exception between the HotSpot and libgraal heaps.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8332735: [JVMCI] Add extra JVMCI events for exception translation (Enhancement - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/19350/head:pull/19350
$ git checkout pull/19350

Update a local copy of the PR:
$ git checkout pull/19350
$ git pull https://git.openjdk.org/jdk.git pull/19350/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 19350

View PR using the GUI difftool:
$ git pr show -t 19350

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/19350.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented May 22, 2024

👋 Welcome back dnsimon! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented May 22, 2024

@dougxc This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8332735: [JVMCI] Add extra JVMCI events for exception translation

Reviewed-by: never

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 22 new commits pushed to the master branch:

  • c2180d1: 8315767: InetAddress: constructing objects from BSD literal addresses
  • 2a11e0d: 8332743: Update comment related to JDK-8320522
  • 6829d9a: 8332122: [nmt] Totals for malloc should show total peak
  • 9d332e6: 8307193: Several Swing jtreg tests use class.forName on L&F classes
  • 98f6a80: 8332490: JMH org.openjdk.bench.java.util.zip.InflaterInputStreams.inflaterInputStreamRead OOM
  • 3d4185a: 8332739: Problemlist compiler/codecache/CheckLargePages until JDK-8332654 is fixed
  • c4557a7: 8332463: Byte conditional pattern case element dominates short constant case element
  • d59c12f: 8329718: Incorrect @since tags in elements in jdk.compiler and java.compiler
  • b4d1454: 8332740: [BACKOUT] JDK-8331081 'internal proprietary API' diagnostics if --system is configured to an earlier JDK version
  • 37c4778: 8332096: hotspot-ide-project fails with this-escape
  • ... and 12 more: https://git.openjdk.org/jdk/compare/d999b81e7110751be402012e1ed41b3256f5895e...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk
Copy link

openjdk bot commented May 22, 2024

@dougxc The following labels will be automatically applied to this pull request:

  • graal
  • hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added graal graal-dev@openjdk.org hotspot-compiler hotspot-compiler-dev@openjdk.org labels May 22, 2024
@dougxc dougxc marked this pull request as ready for review May 22, 2024 16:46
@openjdk openjdk bot added the rfr Pull request is ready for review label May 22, 2024
@mlbridge
Copy link

mlbridge bot commented May 22, 2024

Webrevs

Copy link
Contributor

@tkrodriguez tkrodriguez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@openjdk openjdk bot added the ready Pull request is ready to be integrated label May 22, 2024
@dougxc
Copy link
Member Author

dougxc commented May 23, 2024

Thanks for the review.

/integrate

@openjdk
Copy link

openjdk bot commented May 23, 2024

Going to push as commit 612ae92.
Since your change was applied there have been 25 commits pushed to the master branch:

  • 1ea76d3: 8332675: test/hotspot/jtreg/gc/testlibrary/Helpers.java compileClass javadoc does not match after 8321812
  • 94af3c2: 8329203: Parallel: Investigate Mark-Compact for Full GC to decrease memory usage
  • 1e5a278: 8332676: Remove unused BarrierSetAssembler::incr_allocated_bytes
  • c2180d1: 8315767: InetAddress: constructing objects from BSD literal addresses
  • 2a11e0d: 8332743: Update comment related to JDK-8320522
  • 6829d9a: 8332122: [nmt] Totals for malloc should show total peak
  • 9d332e6: 8307193: Several Swing jtreg tests use class.forName on L&F classes
  • 98f6a80: 8332490: JMH org.openjdk.bench.java.util.zip.InflaterInputStreams.inflaterInputStreamRead OOM
  • 3d4185a: 8332739: Problemlist compiler/codecache/CheckLargePages until JDK-8332654 is fixed
  • c4557a7: 8332463: Byte conditional pattern case element dominates short constant case element
  • ... and 15 more: https://git.openjdk.org/jdk/compare/d999b81e7110751be402012e1ed41b3256f5895e...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label May 23, 2024
@openjdk openjdk bot closed this May 23, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels May 23, 2024
@openjdk
Copy link

openjdk bot commented May 23, 2024

@dougxc Pushed as commit 612ae92.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

graal graal-dev@openjdk.org hotspot-compiler hotspot-compiler-dev@openjdk.org integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

2 participants