8332740: [BACKOUT] JDK-8331081 'internal proprietary API' diagnostics if --system is configured to an earlier JDK version

[dcubed-ojdk]

This reverts commit 2170e99.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8332740: [BACKOUT] JDK-8331081 'internal proprietary API' diagnostics if --system is configured to an earlier JDK version (Bug - P1)

Reviewers

• Mikael Vidstedt (@vidmik - Reviewer)
• Phil Race (@prrace - Reviewer)
• Jan Lahoda (@lahodaj - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/19352/head:pull/19352
$ git checkout pull/19352

Update a local copy of the PR:
$ git checkout pull/19352
$ git pull https://git.openjdk.org/jdk.git pull/19352/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 19352

View PR using the GUI difftool:
$ git pr show -t 19352

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/19352.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back dcubed! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[dcubed-ojdk]

/label add hotspot-runtime
/label add compiler

[openjdk]

@dcubed-ojdk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8332740: [BACKOUT] JDK-8331081 'internal proprietary API' diagnostics if --system is configured to an earlier JDK version

Reviewed-by: mikael, prr, jlahoda

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@dcubed-ojdk
The hotspot-runtime label was successfully added.

[openjdk]

@dcubed-ojdk
The compiler label was successfully added.

[dcubed-ojdk]

@vidmik - Thanks for the lightning fast review! I'm gonna hold off until I get a single
passed Tier1 build task with the [BACKOUT] that previously failed.

[prrace]

I got unlucky and just synced in this breakage to my local repo. It would be good to see it backed out.

[mlbridge]

Webrevs

• 00: Full (1429bc75)

[lahodaj]

Looks good. Sorry for the trouble.

[dcubed-ojdk]

@prrace and @lahodaj - Thanks for the reviews.

macosx-aarch64-open-debug has passed so I am...

/integrate

[openjdk]

Going to push as commit b4d1454.

[openjdk]

@dcubed-ojdk Pushed as commit b4d1454.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.