Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8259048: (tz) Upgrade time-zone data to tzdata2020f #1937

Closed
wants to merge 3 commits into from

Conversation

@kiranoracle
Copy link

@kiranoracle kiranoracle commented Jan 4, 2021

Hi Guys,

Updating the summary as tzdata2020f is available and includes tzdata2020e changes also.

Please review the integration of tzdata2020f to JDK.

Details regarding the change can be viewed at - https://mm.icann.org/pipermail/tz-announce/2020-December/000064.html
Bug: https://bugs.openjdk.java.net/browse/JDK-8259048

tzdata2020e - Most of the changes are about correcting past timestamps and Australia/Currie timezone is removed.
tzdata2020f - No changes to the data since 2020e.

Regression Tests pass along with JCK.

Please let me know if the changes are good to push.

Thanks,
Kiran


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8259048: (tz) Upgrade time-zone data to tzdata2020f

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/1937/head:pull/1937
$ git checkout pull/1937

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Jan 4, 2021

👋 Welcome back kravikumar! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Jan 4, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jan 4, 2021

@kiranoracle The following labels will be automatically applied to this pull request:

  • build
  • i18n

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@mlbridge
Copy link

@mlbridge mlbridge bot commented Jan 4, 2021

Webrevs

@kiranoracle
Copy link
Author

@kiranoracle kiranoracle commented Jan 4, 2021

/label remove build

@openjdk openjdk bot removed the build label Jan 4, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jan 4, 2021

@kiranoracle
The build label was successfully removed.

@kiranoracle
Copy link
Author

@kiranoracle kiranoracle commented Jan 4, 2021

/label add core-libs

@openjdk openjdk bot added the core-libs label Jan 4, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jan 4, 2021

@kiranoracle
The core-libs label was successfully added.

naotoj
naotoj approved these changes Jan 4, 2021
Copy link
Member

@naotoj naotoj left a comment

Looks good.
IIUC, 2020f is already out, and the 2020e-2020f diff does not seem to include any data change. Would you change this PR to incorporate 2020f?

@openjdk
Copy link

@openjdk openjdk bot commented Jan 4, 2021

@kiranoracle This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8259048: (tz) Upgrade time-zone data to tzdata2020f

Reviewed-by: naoto, erikj

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 8 new commits pushed to the master branch:

  • 5855d52: 8259651: [macOS] Replace JNF_COCOA_ENTER/EXIT macros
  • 360c722: 8259729: Missed JNFInstanceOf -> IsInstanceOf conversion
  • b78cd63: 8259846: [BACKOUT] JDK-8259278 Optimize Vector API slice and unslice operations
  • eb7fa00: 8259216: javadoc omits method receiver for any nested type annotation
  • bcf20a0: 8259777: Incorrect predication condition generated by ADLC
  • bbac91a: 8257959: Add gtest run with -XX:+UseLargePages
  • 707bce0: 8257212: (bf spec) Clarify byte order of the buffer returned by CharBuffer.subsequence(int,int)
  • 0ec2c96: 8259820: JShell does not handle -source 8 properly

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Jan 4, 2021
erikj79
erikj79 approved these changes Jan 4, 2021
@kiranoracle kiranoracle changed the title 8258878: (tz) Upgrade time-zone data to tzdata2020e 8259048: (tz) Upgrade time-zone data to tzdata2020f Jan 15, 2021
@kiranoracle
Copy link
Author

@kiranoracle kiranoracle commented Jan 15, 2021

Looks good.
IIUC, 2020f is already out, and the 2020e-2020f diff does not seem to include any data change. Would you change this PR to incorporate 2020f?

Hi @naotoj ,

I have updated the VERSION and PR title to incorporate tzdata2020f, please let me know if the changes are good to push.

naotoj
naotoj approved these changes Jan 15, 2021
@kiranoracle
Copy link
Author

@kiranoracle kiranoracle commented Jan 15, 2021

/integrate

@openjdk openjdk bot closed this Jan 15, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Jan 15, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jan 15, 2021

@kiranoracle Since your change was applied there have been 10 commits pushed to the master branch:

  • 9aa5672: 8259068: Streamline class loader locking
  • 27a39c8: 8193031: Collections.addAll is likely to perform worse than Collection.addAll
  • 5855d52: 8259651: [macOS] Replace JNF_COCOA_ENTER/EXIT macros
  • 360c722: 8259729: Missed JNFInstanceOf -> IsInstanceOf conversion
  • b78cd63: 8259846: [BACKOUT] JDK-8259278 Optimize Vector API slice and unslice operations
  • eb7fa00: 8259216: javadoc omits method receiver for any nested type annotation
  • bcf20a0: 8259777: Incorrect predication condition generated by ADLC
  • bbac91a: 8257959: Add gtest run with -XX:+UseLargePages
  • 707bce0: 8257212: (bf spec) Clarify byte order of the buffer returned by CharBuffer.subsequence(int,int)
  • 0ec2c96: 8259820: JShell does not handle -source 8 properly

Your commit was automatically rebased without conflicts.

Pushed as commit fe84ecd.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants