8321292: SerialGC: NewSize vs InitialHeapSize check has an off-by-one error

[tschatzl]

Hi all,

please review this change to the warning message to improve the understanding why the change is needed.
I tried to make the message similar to surrounding ones, adding actual values.

Testing: local compilation, manual testing

Thanks,
Thomas

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8321292: SerialGC: NewSize vs InitialHeapSize check has an off-by-one error (Bug - P5)

Reviewers

• Albert Mingkun Yang (@albertnetymk - Reviewer) ⚠️ Review applies to 68e42bc8
• Ivan Walulya (@walulyai - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/19384/head:pull/19384
$ git checkout pull/19384

Update a local copy of the PR:
$ git checkout pull/19384
$ git pull https://git.openjdk.org/jdk.git pull/19384/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 19384

View PR using the GUI difftool:
$ git pr show -t 19384

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/19384.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back tschatzl! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@tschatzl This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8321292: SerialGC: NewSize vs InitialHeapSize check has an off-by-one error

Reviewed-by: ayang, iwalulya

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@tschatzl The following label will be automatically applied to this pull request:

• hotspot-gc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (b4f08c95)
• 00: Full (68e42bc8)

[albertnetymk]

The local var name is a bit odd, maybe revised_new_size?

[tschatzl]

The local var name is a bit odd, maybe revised_new_size?

I got it from smaller_max_new_size a bit below.

[tschatzl]

Thanks @albertnetymk @walulyai for your reviews
/integrate

[openjdk]

Going to push as commit a083364.
Since your change was applied there have been 21 commits pushed to the master branch:

• 16dba04: 8332589: ubsan: unix/native/libjava/ProcessImpl_md.c:562:5: runtime error: null pointer passed as argument 2, which is declared to never be null
• 4e8deb3: 8332922: Test java/io/IO/IO.java fails when /usr/bin/expect not exist
• 08d5100: 8332724: x86 MacroAssembler may over-align code
• 97ee2ff: 8332416: Add more font selection options to Font2DTest
• 985b9ce: 8330694: Rename 'HeapRegion' to 'G1HeapRegion'
• 05f13e7: 8329667: [macos] Issue with JTree related fix for JDK-8317771
• 7bf1989: 8320575: generic type information lost on mandated parameters of record's compact constructors
• 253508b: 8332303: Better JMX interoperability with older JDKs, after removing Subject Delegation
• ebc520e: 8332841: GenShen: Pull shared members from control thread into common base class
• 236432d: 8332084: Ensure JdkConsoleImpl.restoreEcho visibility in a shutdown hook
• ... and 11 more: https://git.openjdk.org/jdk/compare/239c1b33b47de43369673f33d9449e1904477ce0...master

Your commit was automatically rebased without conflicts.

[openjdk]

@tschatzl Pushed as commit a083364.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.