-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8079167: Fix documentation for G1SATBBufferEnqueueingThresholdPercent == 0 #19385
8079167: Fix documentation for G1SATBBufferEnqueueingThresholdPercent == 0 #19385
Conversation
Hi all, please review this change to the documentation of `G1SATBBufferEnqueueingThresholdPercent`: since the filtering is necessary to facilitate termination (see comments in CR), we can't completely disable filtering and the text is just misleading. Testing: local compilation Thanks, Thomas
👋 Welcome back tschatzl! A progress list of the required criteria for merging this PR into |
@tschatzl This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the ➡️ To integrate this PR with the above commit message to the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
Thanks @kimbarrett @walulyai for your reviews |
Going to push as commit 61db2f5.
Your commit was automatically rebased without conflicts. |
Hi all,
please review this change to the documentation of
G1SATBBufferEnqueueingThresholdPercent
: sincethe filtering is necessary to facilitate termination (see comments in CR), we can't completely disable filtering and the text is just misleading.
Testing: local compilation
Thanks,
Thomas
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/19385/head:pull/19385
$ git checkout pull/19385
Update a local copy of the PR:
$ git checkout pull/19385
$ git pull https://git.openjdk.org/jdk.git pull/19385/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 19385
View PR using the GUI difftool:
$ git pr show -t 19385
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/19385.diff
Webrev
Link to Webrev Comment