Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8079167: Fix documentation for G1SATBBufferEnqueueingThresholdPercent == 0 #19385

Conversation

tschatzl
Copy link
Contributor

@tschatzl tschatzl commented May 24, 2024

Hi all,

please review this change to the documentation of G1SATBBufferEnqueueingThresholdPercent: since
the filtering is necessary to facilitate termination (see comments in CR), we can't completely disable filtering and the text is just misleading.

Testing: local compilation

Thanks,
Thomas


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8079167: Fix documentation for G1SATBBufferEnqueueingThresholdPercent == 0 (Bug - P5)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/19385/head:pull/19385
$ git checkout pull/19385

Update a local copy of the PR:
$ git checkout pull/19385
$ git pull https://git.openjdk.org/jdk.git pull/19385/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 19385

View PR using the GUI difftool:
$ git pr show -t 19385

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/19385.diff

Webrev

Link to Webrev Comment

Hi all,

  please review this change to the documentation of `G1SATBBufferEnqueueingThresholdPercent`: since
the filtering is necessary to facilitate termination (see comments in CR), we can't completely
disable filtering and the text is just misleading.

Testing: local compilation

Thanks,
  Thomas
@bridgekeeper
Copy link

bridgekeeper bot commented May 24, 2024

👋 Welcome back tschatzl! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented May 24, 2024

@tschatzl This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8079167: Fix documentation for G1SATBBufferEnqueueingThresholdPercent == 0

Reviewed-by: kbarrett, iwalulya

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title 8079167 8079167: Fix documentation for G1SATBBufferEnqueueingThresholdPercent == 0 May 24, 2024
@openjdk openjdk bot added the rfr Pull request is ready for review label May 24, 2024
@openjdk
Copy link

openjdk bot commented May 24, 2024

@tschatzl The following label will be automatically applied to this pull request:

  • hotspot-gc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-gc hotspot-gc-dev@openjdk.org label May 24, 2024
@mlbridge
Copy link

mlbridge bot commented May 24, 2024

Webrevs

Copy link

@kimbarrett kimbarrett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label May 24, 2024
@tschatzl
Copy link
Contributor Author

Thanks @kimbarrett @walulyai for your reviews
/integrate

@openjdk
Copy link

openjdk bot commented May 27, 2024

Going to push as commit 61db2f5.
Since your change was applied there have been 22 commits pushed to the master branch:

  • a083364: 8321292: SerialGC: NewSize vs InitialHeapSize check has an off-by-one error
  • 16dba04: 8332589: ubsan: unix/native/libjava/ProcessImpl_md.c:562:5: runtime error: null pointer passed as argument 2, which is declared to never be null
  • 4e8deb3: 8332922: Test java/io/IO/IO.java fails when /usr/bin/expect not exist
  • 08d5100: 8332724: x86 MacroAssembler may over-align code
  • 97ee2ff: 8332416: Add more font selection options to Font2DTest
  • 985b9ce: 8330694: Rename 'HeapRegion' to 'G1HeapRegion'
  • 05f13e7: 8329667: [macos] Issue with JTree related fix for JDK-8317771
  • 7bf1989: 8320575: generic type information lost on mandated parameters of record's compact constructors
  • 253508b: 8332303: Better JMX interoperability with older JDKs, after removing Subject Delegation
  • ebc520e: 8332841: GenShen: Pull shared members from control thread into common base class
  • ... and 12 more: https://git.openjdk.org/jdk/compare/239c1b33b47de43369673f33d9449e1904477ce0...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label May 27, 2024
@openjdk openjdk bot closed this May 27, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels May 27, 2024
@openjdk
Copy link

openjdk bot commented May 27, 2024

@tschatzl Pushed as commit 61db2f5.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@tschatzl tschatzl deleted the submit/8079167-G1SATBBufferEnqueueingThresholdPercent-documentation branch June 11, 2024 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-gc hotspot-gc-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

3 participants