8332898: failure_handler: log directory of commands

[LudwikJaniuk]

Also log the directory in which the command used by failure_handler was executed. While often the same, it isn't always, and so it this should simplify troubleshooting for someone looking at this at a glance without being a failure_handler expert.

Example output after this change:

----------------------------------------
[2024-05-24 14:26:46] [/usr/bin/pmap, -p, 2233017] timeout=20000 in /<my-absolute-project-dir>/JTwork/scratch
----------------------------------------

before:

----------------------------------------
[2024-05-24 14:26:46] [/usr/bin/pmap, -p, 2233017] timeout=20000
----------------------------------------

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Warning

 ⚠️ Found leading lowercase letter in issue title for 8332898: failure_handler: log directory of commands

Issue

• JDK-8332898: failure_handler: log directory of commands (Enhancement - P4)

Reviewers

• Leonid Mesnik (@lmesnik - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/19396/head:pull/19396
$ git checkout pull/19396

Update a local copy of the PR:
$ git checkout pull/19396
$ git pull https://git.openjdk.org/jdk.git pull/19396/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 19396

View PR using the GUI difftool:
$ git pr show -t 19396

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/19396.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back lujaniuk! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@LudwikJaniuk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8332898: failure_handler: log directory of commands

Reviewed-by: lmesnik

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 13 new commits pushed to the master branch:

• 97ee2ff: 8332416: Add more font selection options to Font2DTest
• 985b9ce: 8330694: Rename 'HeapRegion' to 'G1HeapRegion'
• 05f13e7: 8329667: [macos] Issue with JTree related fix for JDK-8317771
• 7bf1989: 8320575: generic type information lost on mandated parameters of record's compact constructors
• 253508b: 8332303: Better JMX interoperability with older JDKs, after removing Subject Delegation
• ebc520e: 8332841: GenShen: Pull shared members from control thread into common base class
• 236432d: 8332084: Ensure JdkConsoleImpl.restoreEcho visibility in a shutdown hook
• b3b3366: 8332631: Update nsk.share.jpda.BindServer to don't use finalization
• f66a586: 8332641: Update nsk.share.jpda.Jdb to don't use finalization
• cd3e4c0: 8326734: text-decoration applied to lost when mixed with or
• ... and 3 more: https://git.openjdk.org/jdk/compare/0c934ff4e2fb53a72ad25a080d956745a5649f9b...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@LudwikJaniuk The following label will be automatically applied to this pull request:

• core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (6d82e892)

[LudwikJaniuk]

/integrate

[openjdk]

Going to push as commit 7f0ad51.
Since your change was applied there have been 21 commits pushed to the master branch:

• 617edf3: 8332497: javac prints an AssertionError when annotation processing runs on program with module imports
• ffa4bad: 8332527: ZGC: generalize object cloning logic
• a3a367e: 8332871: Parallel: Remove public bits APIs in ParMarkBitMap
• 61db2f5: 8079167: Fix documentation for G1SATBBufferEnqueueingThresholdPercent == 0
• a083364: 8321292: SerialGC: NewSize vs InitialHeapSize check has an off-by-one error
• 16dba04: 8332589: ubsan: unix/native/libjava/ProcessImpl_md.c:562:5: runtime error: null pointer passed as argument 2, which is declared to never be null
• 4e8deb3: 8332922: Test java/io/IO/IO.java fails when /usr/bin/expect not exist
• 08d5100: 8332724: x86 MacroAssembler may over-align code
• 97ee2ff: 8332416: Add more font selection options to Font2DTest
• 985b9ce: 8330694: Rename 'HeapRegion' to 'G1HeapRegion'
• ... and 11 more: https://git.openjdk.org/jdk/compare/0c934ff4e2fb53a72ad25a080d956745a5649f9b...master

Your commit was automatically rebased without conflicts.

[openjdk]

@LudwikJaniuk Pushed as commit 7f0ad51.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.