Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8253040 : Remove unused Matcher::regnum_to_fpu_offset() #194

Closed
wants to merge 2 commits into from
Closed

8253040 : Remove unused Matcher::regnum_to_fpu_offset() #194

wants to merge 2 commits into from

Conversation

JohnTortugo
Copy link
Contributor

@JohnTortugo JohnTortugo commented Sep 15, 2020

Relates to: https://bugs.openjdk.java.net/browse/JDK-8253040
Tested on: x86_64 - Linux - Tier1

Remove unused method Matcher::regnum_to_fpu_offset() from source base.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8253040: Remove unused Matcher::regnum_to_fpu_offset()

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/194/head:pull/194
$ git checkout pull/194

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 15, 2020

👋 Welcome back JohnTortugo! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Sep 15, 2020
@openjdk
Copy link

openjdk bot commented Sep 15, 2020

@JohnTortugo The following label will be automatically applied to this pull request: hotspot-compiler.

When this pull request is ready to be reviewed, an RFR email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label (add|remove) "label" command.

@openjdk openjdk bot added the hotspot-compiler hotspot-compiler-dev@openjdk.org label Sep 15, 2020
@mlbridge
Copy link

mlbridge bot commented Sep 15, 2020

Webrevs

Copy link
Contributor

@adityamandaleeka adityamandaleeka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

@iwanowww iwanowww left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@openjdk
Copy link

openjdk bot commented Sep 15, 2020

@JohnTortugo This change now passes all automated pre-integration checks. In addition to the automated checks, the change must also fulfill all project specific requirements

After integration, the commit message will be:

8253040: Remove unused Matcher::regnum_to_fpu_offset()

Reviewed-by: adityam, vlivanov
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /issue command.

Since the source branch of this PR was last updated there have been 19 commits pushed to the master branch:

  • 7c564e1: 8253146: C2: Purge unused MachCallNode::_arg_size field
  • 2caa20a: 8250668: Clean up method_oop names in adlc
  • 57f92d2: 8220483: Calendar.setTime(Date date) throws NPE with Date date = null
  • 65bfe09: 8253147: The javax/swing/JPopupMenu/7154841/bug7154841.java fail on big screens
  • fc36328: 8253034: Update symbol generation to accomodate Git as the SCM
  • 4020682: 8172366: Support SHA-3 based signatures
  • 46598c8: 8253177: outputStream not declared in markWord.hpp
  • 5191f31: 8251495: Remove the implNote in the DOM package description added by JDK-8249643
  • 65d6c10: 8252933: com.sun.tools.jdi.ObjectReferenceImpl#validateAssignment always requests referenceType
  • 74851c5: 8253169: [BACKOUT] Improve large object handling during evacuation
  • ... and 9 more: https://git.openjdk.java.net/jdk/compare/ac9d1b08ee4a9f54cd75a4115adffcc4c0fb105d...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid automatic rebasing, please merge master into your branch, and then specify the current head hash when integrating, like this: /integrate 7c564e13eeec3a9ad0291ca30b514c060106d940.

As you do not have Committer status in this projectan existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@iwanowww) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Sep 15, 2020
@JohnTortugo
Copy link
Contributor Author

/integrate

@JohnTortugo
Copy link
Contributor Author

@iwanowww - Can you please merge this PR?

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Sep 16, 2020
@openjdk
Copy link

openjdk bot commented Sep 16, 2020

@JohnTortugo
Your change (at version 039b327) is now ready to be sponsored by a Committer.

@shipilev
Copy link
Member

/sponsor

@openjdk openjdk bot closed this Sep 16, 2020
@openjdk openjdk bot added integrated Pull request has been integrated and removed sponsor Pull request is ready to be sponsored ready Pull request is ready to be integrated rfr Pull request is ready for review labels Sep 16, 2020
@openjdk
Copy link

openjdk bot commented Sep 16, 2020

@shipilev @JohnTortugo Since your change was applied there have been 19 commits pushed to the master branch:

  • 7c564e1: 8253146: C2: Purge unused MachCallNode::_arg_size field
  • 2caa20a: 8250668: Clean up method_oop names in adlc
  • 57f92d2: 8220483: Calendar.setTime(Date date) throws NPE with Date date = null
  • 65bfe09: 8253147: The javax/swing/JPopupMenu/7154841/bug7154841.java fail on big screens
  • fc36328: 8253034: Update symbol generation to accomodate Git as the SCM
  • 4020682: 8172366: Support SHA-3 based signatures
  • 46598c8: 8253177: outputStream not declared in markWord.hpp
  • 5191f31: 8251495: Remove the implNote in the DOM package description added by JDK-8249643
  • 65d6c10: 8252933: com.sun.tools.jdi.ObjectReferenceImpl#validateAssignment always requests referenceType
  • 74851c5: 8253169: [BACKOUT] Improve large object handling during evacuation
  • ... and 9 more: https://git.openjdk.java.net/jdk/compare/ac9d1b08ee4a9f54cd75a4115adffcc4c0fb105d...master

Your commit was automatically rebased without conflicts.

Pushed as commit fbf4699.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-compiler hotspot-compiler-dev@openjdk.org integrated Pull request has been integrated
4 participants