Skip to content

8259044: JVM lacks data type qualifier when using -XX:+PrintAssembly with AArch64-Neon backend #1941

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

Wanghuang-Huawei
Copy link

@Wanghuang-Huawei Wanghuang-Huawei commented Jan 5, 2021

For instace: in the implentation of VectorMaskCmp & VectorStoreMask :

$jtreg -vmoptions:"-XX:+PrintAssembly" ./Int128VectorTests.java

Before fixing:

0dc ldrq V17,[R10, #16] # vector (128 bits)
0e0 cmeq V16, V16, V17 # vector cmp (4I)
0e4 xtn V16, V16 # 4S to 4H
xtn V16, V16 # 4H to 4B
negr V16, V16 # store mask (4S to 4B)

Here, the output lacks data type qualifiers like T4S in cmeq V16, V16, V17.

Expect:

0dc ldrq V16,[R10, #16] # vector (128 bits)
0e0 cmeq V16, T4S, V16, V18 # vector cmp (4I)
0e4 xtn V16, T4H, V16, T4S # 4S to 4H
xtn V16, T8B, V16, T8H # 4H to 4B
negr V16, T8B, V16 # store mask (4S to 4B)


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8259044: JVM lacks data type qualifier when using -XX:+PrintAssembly with AArch64-Neon backend

Reviewers

Contributors

  • He Xuejin <hexuejin2@huawei.com>

Download

$ git fetch https://git.openjdk.java.net/jdk pull/1941/head:pull/1941
$ git checkout pull/1941

@Wanghuang-Huawei
Copy link
Author

/contributor add He Xuejin hexuejin2@huawei.com

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 5, 2021

👋 Welcome back whuang! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jan 5, 2021
@openjdk
Copy link

openjdk bot commented Jan 5, 2021

@Wanghuang-Huawei
Contributor He Xuejin <hexuejin2@huawei.com> successfully added.

@openjdk
Copy link

openjdk bot commented Jan 5, 2021

@Wanghuang-Huawei The following label will be automatically applied to this pull request:

  • hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-compiler hotspot-compiler-dev@openjdk.org label Jan 5, 2021
@mlbridge
Copy link

mlbridge bot commented Jan 5, 2021

Webrevs

Copy link

@nsjian nsjian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

theRealAph
theRealAph approved these changes Jan 11, 2021
@openjdk
Copy link

openjdk bot commented Jan 11, 2021

@Wanghuang-Huawei This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8259044: JVM lacks data type qualifier when using -XX:+PrintAssembly with AArch64-Neon backend

Co-authored-by: He Xuejin <hexuejin2@huawei.com>
Reviewed-by: njian, aph

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 123 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@nsjian, @theRealAph) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jan 11, 2021
@Wanghuang-Huawei
Copy link
Author

/

Looks good to me.

Thank you for your review.

@Wanghuang-Huawei
Copy link
Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Jan 12, 2021
@openjdk
Copy link

openjdk bot commented Jan 12, 2021

@Wanghuang-Huawei
Your change (at version cbef1cb) is now ready to be sponsored by a Committer.

@RealFYang
Copy link
Member

/sponsor

@openjdk openjdk bot closed this Jan 12, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed sponsor Pull request is ready to be sponsored ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jan 12, 2021
@openjdk
Copy link

openjdk bot commented Jan 12, 2021

@RealFYang @Wanghuang-Huawei Since your change was applied there have been 123 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

Pushed as commit ae0532e.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-compiler hotspot-compiler-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

4 participants