8259044: JVM lacks data type qualifier when using -XX:+PrintAssembly with AArch64-Neon backend

[Wanghuang-Huawei]

For instace: in the implentation of VectorMaskCmp & VectorStoreMask :

$jtreg -vmoptions:"-XX:+PrintAssembly" ./Int128VectorTests.java

Before fixing:

0dc ldrq V17,[R10, #16] # vector (128 bits)
0e0 cmeq V16, V16, V17 # vector cmp (4I)
0e4 xtn V16, V16 # 4S to 4H
xtn V16, V16 # 4H to 4B
negr V16, V16 # store mask (4S to 4B)

Here， the output lacks data type qualifiers like T4S in cmeq V16, V16, V17.

Expect:

0dc ldrq V16,[R10, #16] # vector (128 bits)
0e0 cmeq V16, T4S, V16, V18 # vector cmp (4I)
0e4 xtn V16, T4H, V16, T4S # 4S to 4H
xtn V16, T8B, V16, T8H # 4H to 4B
negr V16, T8B, V16 # store mask (4S to 4B)

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8259044: JVM lacks data type qualifier when using -XX:+PrintAssembly with AArch64-Neon backend

Reviewers

• Ningsheng Jian (@nsjian - Committer)
• Andrew Haley (@theRealAph - Reviewer)

Contributors

• He Xuejin <hexuejin2@huawei.com>

Download

$ git fetch https://git.openjdk.java.net/jdk pull/1941/head:pull/1941
$ git checkout pull/1941

[Wanghuang-Huawei]

/contributor add He Xuejin hexuejin2@huawei.com

[bridgekeeper]

👋 Welcome back whuang! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@Wanghuang-Huawei
Contributor He Xuejin <hexuejin2@huawei.com> successfully added.

[openjdk]

@Wanghuang-Huawei The following label will be automatically applied to this pull request:

• hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (cbef1cb)

[nsjian]

Looks good to me.

[openjdk]

@Wanghuang-Huawei This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8259044: JVM lacks data type qualifier when using -XX:+PrintAssembly with AArch64-Neon backend

Co-authored-by: He Xuejin <hexuejin2@huawei.com>
Reviewed-by: njian, aph

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 123 new commits pushed to the master branch:

• b378f54: Merge
• 2cb271e: 8253996: Javac error on jdk16 build 18: invalid flag: -Xdoclint:-missing
• d60a937: 8259028: ClassCastException when using custom filesystem with wrapper FileChannel impl
• e05f36f: 8259043: More Zero architectures need linkage with libatomic
• 020ec84: 8259429: Update reference to README.md
• fb68395: 8259014: (so) ServerSocketChannel.bind(UnixDomainSocketAddress)/SocketChannel.bind(UnixDomainSocketAddress) will have unknown user and group owner (win)
• b6d51e1: 8259585: Accessible actions do not work on mac os x
• 022bc9f: 8258422: Cleanup unnecessary null comparison before instanceof check in java.base
• ff54b77: 8259439: Apply java.io.Serial annotations in java.datatransfer
• 712ea25: 8258925: configure script failed on WSL
• ... and 113 more: https://git.openjdk.java.net/jdk/compare/2499ac3db5c4a336059263a929031b4eef2d0f0a...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@nsjian, @theRealAph) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[Wanghuang-Huawei]

/

Looks good to me.

Thank you for your review.

[Wanghuang-Huawei]

/integrate

[openjdk]

@Wanghuang-Huawei
Your change (at version cbef1cb) is now ready to be sponsored by a Committer.

[RealFYang]

/sponsor

[openjdk]

@RealFYang @Wanghuang-Huawei Since your change was applied there have been 123 commits pushed to the master branch:

• b378f54: Merge
• 2cb271e: 8253996: Javac error on jdk16 build 18: invalid flag: -Xdoclint:-missing
• d60a937: 8259028: ClassCastException when using custom filesystem with wrapper FileChannel impl
• e05f36f: 8259043: More Zero architectures need linkage with libatomic
• 020ec84: 8259429: Update reference to README.md
• fb68395: 8259014: (so) ServerSocketChannel.bind(UnixDomainSocketAddress)/SocketChannel.bind(UnixDomainSocketAddress) will have unknown user and group owner (win)
• b6d51e1: 8259585: Accessible actions do not work on mac os x
• 022bc9f: 8258422: Cleanup unnecessary null comparison before instanceof check in java.base
• ff54b77: 8259439: Apply java.io.Serial annotations in java.datatransfer
• 712ea25: 8258925: configure script failed on WSL
• ... and 113 more: https://git.openjdk.java.net/jdk/compare/2499ac3db5c4a336059263a929031b4eef2d0f0a...master

Your commit was automatically rebased without conflicts.

Pushed as commit ae0532e.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.