-
Notifications
You must be signed in to change notification settings - Fork 5.8k
8259044: JVM lacks data type qualifier when using -XX:+PrintAssembly with AArch64-Neon backend #1941
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…with AArch64-Neon backend
/contributor add He Xuejin hexuejin2@huawei.com |
👋 Welcome back whuang! A progress list of the required criteria for merging this PR into |
@Wanghuang-Huawei |
@Wanghuang-Huawei The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
@Wanghuang-Huawei This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 123 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@nsjian, @theRealAph) but any other Committer may sponsor as well. ➡️ To flag this PR as ready for integration with the above commit message, type |
/
Thank you for your review. |
/integrate |
@Wanghuang-Huawei |
/sponsor |
@RealFYang @Wanghuang-Huawei Since your change was applied there have been 123 commits pushed to the
Your commit was automatically rebased without conflicts. Pushed as commit ae0532e. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
For instace: in the implentation of VectorMaskCmp & VectorStoreMask :
$jtreg -vmoptions:"-XX:+PrintAssembly" ./Int128VectorTests.java
Before fixing:
0dc ldrq V17,[R10, #16] # vector (128 bits)
0e0 cmeq V16, V16, V17 # vector cmp (4I)
0e4 xtn V16, V16 # 4S to 4H
xtn V16, V16 # 4H to 4B
negr V16, V16 # store mask (4S to 4B)
Here, the output lacks data type qualifiers like T4S in
cmeq V16, V16, V17
.Expect:
0dc ldrq V16,[R10, #16] # vector (128 bits)
0e0 cmeq V16, T4S, V16, V18 # vector cmp (4I)
0e4 xtn V16, T4H, V16, T4S # 4S to 4H
xtn V16, T8B, V16, T8H # 4H to 4B
negr V16, T8B, V16 # store mask (4S to 4B)
Progress
Issue
Reviewers
Contributors
<hexuejin2@huawei.com>
Download
$ git fetch https://git.openjdk.java.net/jdk pull/1941/head:pull/1941
$ git checkout pull/1941