8332904: ubsan ppc64le: c1_LIRGenerator_ppc.cpp:581:21: runtime error: signed integer overflow: 9223372036854775807 + 1 cannot be represented in type 'long int'

[MBaesken]

When using ubsan on Linux ppc64le we run into some overflows like this one

c1_LIRGenerator_ppc.cpp:581:21: runtime error: signed integer overflow: 9223372036854775807 + 1 cannot be represented in type 'long int'

Seems we have to add casts to get defined behavior.
There are similar places in the coding as well.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Warning

 ⚠️ Found leading lowercase letter in issue title for 8332904: ubsan ppc64le: c1_LIRGenerator_ppc.cpp:581:21: runtime error: signed integer overflow: 9223372036854775807 + 1 cannot be represented in type 'long int'

Issue

• JDK-8332904: ubsan ppc64le: c1_LIRGenerator_ppc.cpp:581:21: runtime error: signed integer overflow: 9223372036854775807 + 1 cannot be represented in type 'long int' (Bug - P4)

Reviewers

• Martin Doerr (@TheRealMDoerr - Reviewer)
• Joachim Kern (@JoKern65 - Author)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/19413/head:pull/19413
$ git checkout pull/19413

Update a local copy of the PR:
$ git checkout pull/19413
$ git pull https://git.openjdk.org/jdk.git pull/19413/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 19413

View PR using the GUI difftool:
$ git pr show -t 19413

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/19413.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back mbaesken! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@MBaesken This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8332904: ubsan ppc64le: c1_LIRGenerator_ppc.cpp:581:21: runtime error: signed integer overflow: 9223372036854775807 + 1 cannot be represented in type 'long int'

Reviewed-by: mdoerr, jkern

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 24 new commits pushed to the master branch:

• 3d4eb15: 8302744: Refactor Hotspot container detection code
• 2cca83b: 8332880: JFR GCHelper class recognizes "Archive" regions as valid
• b8ae11e: 8332960: ubsan: classListParser.hpp:159:12: runtime error: load of value 2101478704, which is not a valid value for type 'ParseMode'
• 9a83dfe: 8332431: NullPointerException in JTable of SwingSet2
• 01060ad: 8325083: jdk/incubator/vector/Double512VectorTests.java crashes in Assembler::vex_prefix_and_encode
• 673f767: 8285506: Unify os::vsnprintf implementations
• 91ab088: 8333116: test/jdk/tools/jpackage/share/ServiceTest.java test fails
• 9ac8d05: 8332228: TypePollution.java: Unrecognized VM option 'UseSecondarySuperCache'
• 91caec0: 8330542: Template for Creating Strict JAXP Configuration File
• da6aa2a: 8332849: Update doc/testing.{md,html} (spelling and stale information)
• ... and 14 more: https://git.openjdk.org/jdk/compare/be1d374bc54d43aae3b3c1feace22d38fe2156b6...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@MBaesken The following label will be automatically applied to this pull request:

• hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (349a641d)

[TheRealMDoerr]

Thank you for fixing it!

[MBaesken]

Hi Martin, thanks for the review !
May I get a second review ?

[JoKern65]

LGTM

[MBaesken]

Thanks for the reviews !

/integrate

[openjdk]

Going to push as commit 9b64ece.
Since your change was applied there have been 24 commits pushed to the master branch:

• 3d4eb15: 8302744: Refactor Hotspot container detection code
• 2cca83b: 8332880: JFR GCHelper class recognizes "Archive" regions as valid
• b8ae11e: 8332960: ubsan: classListParser.hpp:159:12: runtime error: load of value 2101478704, which is not a valid value for type 'ParseMode'
• 9a83dfe: 8332431: NullPointerException in JTable of SwingSet2
• 01060ad: 8325083: jdk/incubator/vector/Double512VectorTests.java crashes in Assembler::vex_prefix_and_encode
• 673f767: 8285506: Unify os::vsnprintf implementations
• 91ab088: 8333116: test/jdk/tools/jpackage/share/ServiceTest.java test fails
• 9ac8d05: 8332228: TypePollution.java: Unrecognized VM option 'UseSecondarySuperCache'
• 91caec0: 8330542: Template for Creating Strict JAXP Configuration File
• da6aa2a: 8332849: Update doc/testing.{md,html} (spelling and stale information)
• ... and 14 more: https://git.openjdk.org/jdk/compare/be1d374bc54d43aae3b3c1feace22d38fe2156b6...master

Your commit was automatically rebased without conflicts.

[openjdk]

@MBaesken Pushed as commit 9b64ece.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.