New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8259223: Simplify boolean expression in the SunJSSE provider #1942
Conversation
|
@XueleiFan The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
Webrevs
|
@@ -820,7 +820,7 @@ public String getValidator() { | |||
if (!preferred && checkResult == CheckResult.OK && keyIndex == 0) { | |||
preferred = true; | |||
} | |||
if (preferred && (findAll == false)) { | |||
if (preferred && (!findAll)) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor comment - remove the parenthesis around !findAll.
@@ -614,7 +614,7 @@ CheckResult check(X509Certificate cert, Date date, | |||
// exchange and not ephemeral ECDH. We leave it in | |||
// for now until there are signs that this check | |||
// causes problems for real world EC certificates. | |||
if ((this == SERVER) && (getBit(ku, 4) == false)) { | |||
if ((this == SERVER) && (!getBit(ku, 4))) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You could remove the inner parenthesis around this == SERVER
and !getBit(ku, 4)
, which would make it consistent with the style used on line 584.
@XueleiFan This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 10 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the
|
/integrate |
@XueleiFan Since your change was applied there have been 13 commits pushed to the
Your commit was automatically rebased without conflicts. Pushed as commit 4d3d599. |
There are some boolean expressions that could be improved for better readability in the SunJSSE provider implementation. For example:
Code cleanup, no new regression test.
Bug: https://bugs.openjdk.java.net/browse/JDK-8259223
Progress
Issue
Reviewers
Download
$ git fetch https://git.openjdk.java.net/jdk pull/1942/head:pull/1942
$ git checkout pull/1942