Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8333093: Incorrect comment in zAddress_aarch64.cpp #19428

Closed
wants to merge 1 commit into from

Conversation

ashu-mehra
Copy link
Contributor

@ashu-mehra ashu-mehra commented May 28, 2024

This PR is just updating the comments, so no need for any testing.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8333093: Incorrect comment in zAddress_aarch64.cpp (Bug - P5)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/19428/head:pull/19428
$ git checkout pull/19428

Update a local copy of the PR:
$ git checkout pull/19428
$ git pull https://git.openjdk.org/jdk.git pull/19428/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 19428

View PR using the GUI difftool:
$ git pr show -t 19428

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/19428.diff

Webrev

Link to Webrev Comment

Signed-off-by: Ashutosh Mehra <asmehra@redhat.com>
@bridgekeeper
Copy link

bridgekeeper bot commented May 28, 2024

👋 Welcome back asmehra! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented May 28, 2024

@ashu-mehra This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8333093: Incorrect comment in zAddress_aarch64.cpp

Reviewed-by: stefank

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • 4754f05: 8333035: Parallel: Remove ParMarkBitMap::IterationStatus

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the rfr Pull request is ready for review label May 28, 2024
@openjdk
Copy link

openjdk bot commented May 28, 2024

@ashu-mehra The following label will be automatically applied to this pull request:

  • hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot hotspot-dev@openjdk.org label May 28, 2024
@mlbridge
Copy link

mlbridge bot commented May 28, 2024

Webrevs

@openjdk openjdk bot added the ready Pull request is ready to be integrated label May 28, 2024
@ashu-mehra
Copy link
Contributor Author

As this is just a change in comments, merging it with one approval.

@ashu-mehra
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented May 28, 2024

Going to push as commit 51ae08f.
Since your change was applied there has been 1 commit pushed to the master branch:

  • 4754f05: 8333035: Parallel: Remove ParMarkBitMap::IterationStatus

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label May 28, 2024
@openjdk openjdk bot closed this May 28, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels May 28, 2024
@openjdk
Copy link

openjdk bot commented May 28, 2024

@ashu-mehra Pushed as commit 51ae08f.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@openjdk
Copy link

openjdk bot commented May 28, 2024

@ashu-mehra the backport was successfully created on the branch backport-ashu-mehra-51ae08f7 in my personal fork of openjdk/jdk21u-dev. To create a pull request with this backport targeting openjdk/jdk21u-dev:master, just click the following link:

➡️ Create pull request

The title of the pull request is automatically filled in correctly and below you find a suggestion for the pull request body:

Hi all,

This pull request contains a backport of commit 51ae08f7 from the openjdk/jdk repository.

The commit being backported was authored by Ashutosh Mehra on 28 May 2024 and was reviewed by Stefan Karlsson.

Thanks!

If you need to update the source branch of the pull then run the following commands in a local clone of your personal fork of openjdk/jdk21u-dev:

$ git fetch https://github.com/openjdk-bots/jdk21u-dev.git backport-ashu-mehra-51ae08f7:backport-ashu-mehra-51ae08f7
$ git checkout backport-ashu-mehra-51ae08f7
# make changes
$ git add paths/to/changed/files
$ git commit --message 'Describe additional changes made'
$ git push https://github.com/openjdk-bots/jdk21u-dev.git backport-ashu-mehra-51ae08f7

@ashu-mehra
Copy link
Contributor Author

/backport jdk22u

@openjdk
Copy link

openjdk bot commented May 30, 2024

@ashu-mehra the backport was successfully created on the branch backport-ashu-mehra-51ae08f7 in my personal fork of openjdk/jdk22u. To create a pull request with this backport targeting openjdk/jdk22u:master, just click the following link:

➡️ Create pull request

The title of the pull request is automatically filled in correctly and below you find a suggestion for the pull request body:

Hi all,

This pull request contains a backport of commit 51ae08f7 from the openjdk/jdk repository.

The commit being backported was authored by Ashutosh Mehra on 28 May 2024 and was reviewed by Stefan Karlsson.

Thanks!

If you need to update the source branch of the pull then run the following commands in a local clone of your personal fork of openjdk/jdk22u:

$ git fetch https://github.com/openjdk-bots/jdk22u.git backport-ashu-mehra-51ae08f7:backport-ashu-mehra-51ae08f7
$ git checkout backport-ashu-mehra-51ae08f7
# make changes
$ git add paths/to/changed/files
$ git commit --message 'Describe additional changes made'
$ git push https://github.com/openjdk-bots/jdk22u.git backport-ashu-mehra-51ae08f7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot hotspot-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants