Skip to content

Conversation

@zifeihan
Copy link
Member

@zifeihan zifeihan commented May 29, 2024

Implementation of primitive array C1 clone intrinsic (https://bugs.openjdk.org/browse/JDK-8333154) for linux-riscv64.

Correctness testing:

  • Run make test TEST="hotspot_compiler" JTREG="JAVA_OPTIONS=-XX:TieredStopAtLevel=1" (fastdebug)
  • Run tier1-3 tests on SOPHON SG2042 (release)

Performance testing:

Without Patch:

make test TEST="micro:java.lang.ArrayClone" MICRO="JAVA_OPTIONS=-XX:TieredStopAtLevel=1"

Benchmark                 (size)  Mode  Cnt     Score     Error  Units
ArrayClone.byteArraycopy       0  avgt   15    90.089 ±   7.122  ns/op
ArrayClone.byteArraycopy      10  avgt   15   146.000 ±  11.761  ns/op
ArrayClone.byteArraycopy     100  avgt   15   289.382 ±  23.903  ns/op
ArrayClone.byteArraycopy    1000  avgt   15   767.864 ±  56.721  ns/op
ArrayClone.byteClone           0  avgt   15   735.692 ±  26.641  ns/op
ArrayClone.byteClone          10  avgt   15   810.810 ±  34.563  ns/op
ArrayClone.byteClone         100  avgt   15  1055.917 ±  93.574  ns/op
ArrayClone.byteClone        1000  avgt   15  1564.465 ± 140.941  ns/op
ArrayClone.intArraycopy        0  avgt   15    93.732 ±   8.468  ns/op
ArrayClone.intArraycopy       10  avgt   15   214.168 ±  34.526  ns/op
ArrayClone.intArraycopy      100  avgt   15   613.363 ±  45.415  ns/op
ArrayClone.intArraycopy     1000  avgt   15  1759.611 ±  59.010  ns/op
ArrayClone.intClone            0  avgt   15   680.100 ±  24.375  ns/op
ArrayClone.intClone           10  avgt   15   835.979 ±  75.154  ns/op
ArrayClone.intClone          100  avgt   15  1337.354 ±  86.182  ns/op
ArrayClone.intClone         1000  avgt   15  2696.280 ± 207.418  ns/op
Finished running test 'micro:java.lang.ArrayClone'

With Patch:

make test TEST="micro:java.lang.ArrayClone" MICRO="JAVA_OPTIONS=-XX:TieredStopAtLevel=1"

Benchmark                 (size)  Mode  Cnt     Score     Error  Units
ArrayClone.byteArraycopy       0  avgt   15    89.410 ±   5.112  ns/op
ArrayClone.byteArraycopy      10  avgt   15   141.125 ±   8.711  ns/op
ArrayClone.byteArraycopy     100  avgt   15   277.098 ±  12.925  ns/op
ArrayClone.byteArraycopy    1000  avgt   15   770.188 ±  83.034  ns/op
ArrayClone.byteClone           0  avgt   15    94.367 ±   7.088  ns/op
ArrayClone.byteClone          10  avgt   15   151.804 ±  16.497  ns/op
ArrayClone.byteClone         100  avgt   15   296.284 ±  17.893  ns/op
ArrayClone.byteClone        1000  avgt   15   790.517 ±  28.765  ns/op
ArrayClone.intArraycopy        0  avgt   15    93.688 ±   7.050  ns/op
ArrayClone.intArraycopy       10  avgt   15   213.070 ±  12.299  ns/op
ArrayClone.intArraycopy      100  avgt   15   610.022 ±  57.880  ns/op
ArrayClone.intArraycopy     1000  avgt   15  1774.649 ±  89.373  ns/op
ArrayClone.intClone            0  avgt   15    96.396 ±   7.751  ns/op
ArrayClone.intClone           10  avgt   15   216.224 ±  19.219  ns/op
ArrayClone.intClone          100  avgt   15   585.263 ±  31.196  ns/op
ArrayClone.intClone         1000  avgt   15  1559.673 ± 108.939  ns/op
Finished running test 'micro:java.lang.ArrayClone'

Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8333154: RISC-V: Add support for primitive array C1 clone intrinsic (Enhancement - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/19448/head:pull/19448
$ git checkout pull/19448

Update a local copy of the PR:
$ git checkout pull/19448
$ git pull https://git.openjdk.org/jdk.git pull/19448/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 19448

View PR using the GUI difftool:
$ git pr show -t 19448

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/19448.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented May 29, 2024

👋 Welcome back gcao! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented May 29, 2024

@zifeihan This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8333154: RISC-V: Add support for primitive array C1 clone intrinsic

Reviewed-by: fyang

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@RealFYang) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the rfr Pull request is ready for review label May 29, 2024
@openjdk
Copy link

openjdk bot commented May 29, 2024

@zifeihan The following label will be automatically applied to this pull request:

  • hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-compiler hotspot-compiler-dev@openjdk.org label May 29, 2024
@mlbridge
Copy link

mlbridge bot commented May 29, 2024

Webrevs

Copy link
Member

@RealFYang RealFYang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label May 30, 2024
@zifeihan
Copy link
Member Author

zifeihan commented Jun 3, 2024

@RealFYang : Thanks for the review.
/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Jun 3, 2024
@openjdk
Copy link

openjdk bot commented Jun 3, 2024

@zifeihan
Your change (at version 6cc793f) is now ready to be sponsored by a Committer.

@RealFYang
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented Jun 3, 2024

Going to push as commit 75220da.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jun 3, 2024
@openjdk openjdk bot closed this Jun 3, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Jun 3, 2024
@openjdk
Copy link

openjdk bot commented Jun 3, 2024

@RealFYang @zifeihan Pushed as commit 75220da.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@zifeihan zifeihan deleted the JDK-8333154 branch June 19, 2024 07:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hotspot-compiler hotspot-compiler-dev@openjdk.org integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

2 participants