8258937: Remove JVM IgnoreRewrites flag

[hseigel]

Please review this change to remove the legacy JVM develop flag IgnoreRewrites.

The change was tested with Mach5 tiers 1-2 on Linux, Windows, and Mac OS, and tiers 3-5 on Linux x64.

Thanks, Harold

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8258937: Remove JVM IgnoreRewrites flag

Reviewers

• Coleen Phillimore (@coleenp - Reviewer)

Download

$ git fetch https://git.openjdk.java.net/jdk pull/1947/head:pull/1947
$ git checkout pull/1947

[bridgekeeper]

👋 Welcome back hseigel! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@hseigel The following label will be automatically applied to this pull request:

• hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (43cda4b)

[coleenp]

Wow, terrifying.

[coleenp]

I'd say this is trivial also.

[openjdk]

@hseigel This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8258937: Remove JVM IgnoreRewrites flag

Reviewed-by: coleenp

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 4 new commits pushed to the master branch:

• 4d3d599: 8259223: Simplify boolean expression in the SunJSSE provider
• 1b60acd: 8259252: Shenandoah: Shenandoah build failed on AArch64 after JDK-8258459
• 7ddc2b5: 8258852: Arrays.asList() for single item could be replaced with List.of()
• 85bac8c: 8259021: SharedSecrets should avoid double racy reads from non-volatile fields

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[hseigel]

Thanks Coleen!

/integrate

[openjdk]

@hseigel Since your change was applied there have been 4 commits pushed to the master branch:

• 4d3d599: 8259223: Simplify boolean expression in the SunJSSE provider
• 1b60acd: 8259252: Shenandoah: Shenandoah build failed on AArch64 after JDK-8258459
• 7ddc2b5: 8258852: Arrays.asList() for single item could be replaced with List.of()
• 85bac8c: 8259021: SharedSecrets should avoid double racy reads from non-volatile fields

Your commit was automatically rebased without conflicts.

Pushed as commit cf9908b.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.