8250564: Remove terminally deprecated constructor in GSSUtil

[jddarcy]

Back in JDK 16, two unintended default constructors were identified and deprecated for removal. The time has come to remove them.

Please also review the corresponding CSRs:

JDK-8258521 Remove terminally deprecated constructor in GSSUtil
https://bugs.openjdk.java.net/browse/JDK-8258521

JDK-8258522 Remove terminally deprecated constructor in java.net.URLDecoder
https://bugs.openjdk.java.net/browse/JDK-8258522

Calling a static method using an instance of a class, as done in the test B6463990.java, is a coding anti-pattern that generates a lint warning; that warning in enabled in the JDK build.

Thanks,

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issues

• JDK-8250564: Remove terminally deprecated constructor in GSSUtil
• JDK-8250565: Remove terminally deprecated constructor in java.net.URLDecoder

Reviewers

• Brian Burkhalter (@bplb - Reviewer)
• Stuart Marks (@stuart-marks - Reviewer)
• Alan Bateman (@AlanBateman - Reviewer)
• Sean Mullan (@seanjmullan - Reviewer)

Download

$ git fetch https://git.openjdk.java.net/jdk pull/1948/head:pull/1948
$ git checkout pull/1948

[bridgekeeper]

👋 Welcome back darcy! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[jddarcy]

/issue JDK-8250565

[openjdk]

@jddarcy The following labels will be automatically applied to this pull request:

• net
• security

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

[openjdk]

@jddarcy
Adding additional issue to issue list: 8250565: Remove terminally deprecated constructor in java.net.URLDecoder.

[mlbridge]

Webrevs

• 00: Full (fac1566)

[bplb]

Looks good. CSRs also reviewed.

[openjdk]

@jddarcy This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8250564: Remove terminally deprecated constructor in GSSUtil
8250565: Remove terminally deprecated constructor in java.net.URLDecoder

Reviewed-by: bpb, smarks, alanb, mullan

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 13 new commits pushed to the master branch:

• d20d2fa: 8258143: Update --release 16 symbol information for JDK 16 build 30 or later
• 3be6e06: 8259312: VerifyCACerts.java fails as soneraclass2ca cert will expire in 90 days
• 722f236: 8259231: Epsilon: improve performance under contention during virtual space expansion
• f6cb8c5: 8258908: Remove JVM option CleanChunkPoolAsync
• c0540ff: 8231627: ThreadsListHandleInErrorHandlingTest.java fails in printing all threads
• 7e01bc9: 8255264: Support for identifying the full range of IPv4 localhost addresses on Windows
• 8a05d60: 8259042: Inconsistent use of general primitives loops
• e3b9da1: 8259287: AbstractCompiler marks const in wrong position for is_c1/is_c2/is_jvmci
• 32538b5: 8193942: Regression automated test '/open/test/jdk/javax/swing/JFrame/8175301/ScaledFrameBackgroundTest.java' fails
• 52d3fee: 8258813: [TESTBUG] Fix incorrect Vector API test output message
• ... and 3 more: https://git.openjdk.java.net/jdk/compare/4d3d59912d71a05865b87bb2579571fbda74b668...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[seanjmullan]

The GSSUtil bug needs an appropriate noreg keyword, but otherwise looks fine.

[jddarcy]

/integrate

[openjdk]

@jddarcy Since your change was applied there have been 15 commits pushed to the master branch:

• 940b053: 8259232: Bad JNI lookup during printing
• df721f0: 8259291: Cleanup unnecessary local variables
• d20d2fa: 8258143: Update --release 16 symbol information for JDK 16 build 30 or later
• 3be6e06: 8259312: VerifyCACerts.java fails as soneraclass2ca cert will expire in 90 days
• 722f236: 8259231: Epsilon: improve performance under contention during virtual space expansion
• f6cb8c5: 8258908: Remove JVM option CleanChunkPoolAsync
• c0540ff: 8231627: ThreadsListHandleInErrorHandlingTest.java fails in printing all threads
• 7e01bc9: 8255264: Support for identifying the full range of IPv4 localhost addresses on Windows
• 8a05d60: 8259042: Inconsistent use of general primitives loops
• e3b9da1: 8259287: AbstractCompiler marks const in wrong position for is_c1/is_c2/is_jvmci
• ... and 5 more: https://git.openjdk.java.net/jdk/compare/4d3d59912d71a05865b87bb2579571fbda74b668...master

Your commit was automatically rebased without conflicts.

Pushed as commit 80544e4.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.