Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8258908: Remove JVM option CleanChunkPoolAsync #1949

Closed
wants to merge 1 commit into from

Conversation

hseigel
Copy link
Member

@hseigel hseigel commented Jan 5, 2021

Please review this small change to remove JVM develop option CleanChunkPoolAsync. The option was originally added for embedded builds so they could clean chunk pools synchronouosly.

The change was tested with Mach5 tiers 1-2 on Linux, Mac OS, and Windows, and tiers 3-5 on Linux x64.

Thanks, Harold


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/1949/head:pull/1949
$ git checkout pull/1949

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Jan 5, 2021

👋 Welcome back hseigel! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Jan 5, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jan 5, 2021

@hseigel The following label will be automatically applied to this pull request:

  • hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot label Jan 5, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Jan 5, 2021

Webrevs

coleenp
coleenp approved these changes Jan 6, 2021
Copy link
Contributor

@coleenp coleenp left a comment

Looks good and trivial. Thanks!

@openjdk
Copy link

@openjdk openjdk bot commented Jan 6, 2021

@hseigel This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8258908: Remove JVM option CleanChunkPoolAsync

Reviewed-by: coleenp

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 8 new commits pushed to the master branch:

  • c0540ff: 8231627: ThreadsListHandleInErrorHandlingTest.java fails in printing all threads
  • 7e01bc9: 8255264: Support for identifying the full range of IPv4 localhost addresses on Windows
  • 8a05d60: 8259042: Inconsistent use of general primitives loops
  • e3b9da1: 8259287: AbstractCompiler marks const in wrong position for is_c1/is_c2/is_jvmci
  • 32538b5: 8193942: Regression automated test '/open/test/jdk/javax/swing/JFrame/8175301/ScaledFrameBackgroundTest.java' fails
  • 52d3fee: 8258813: [TESTBUG] Fix incorrect Vector API test output message
  • 8b45497: 8259037: livenmethods cannot find hsdis library
  • 7d76966: 8255757: Javac emits duplicate pool entries on array::clone

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Jan 6, 2021
@hseigel
Copy link
Member Author

@hseigel hseigel commented Jan 6, 2021

Thanks Coleen!

/integrate

@openjdk openjdk bot closed this Jan 6, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Jan 6, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jan 6, 2021

@hseigel Since your change was applied there have been 8 commits pushed to the master branch:

  • c0540ff: 8231627: ThreadsListHandleInErrorHandlingTest.java fails in printing all threads
  • 7e01bc9: 8255264: Support for identifying the full range of IPv4 localhost addresses on Windows
  • 8a05d60: 8259042: Inconsistent use of general primitives loops
  • e3b9da1: 8259287: AbstractCompiler marks const in wrong position for is_c1/is_c2/is_jvmci
  • 32538b5: 8193942: Regression automated test '/open/test/jdk/javax/swing/JFrame/8175301/ScaledFrameBackgroundTest.java' fails
  • 52d3fee: 8258813: [TESTBUG] Fix incorrect Vector API test output message
  • 8b45497: 8259037: livenmethods cannot find hsdis library
  • 7d76966: 8255757: Javac emits duplicate pool entries on array::clone

Your commit was automatically rebased without conflicts.

Pushed as commit f6cb8c5.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Copy link
Member

@dholmes-ora dholmes-ora left a comment

Hi Harold,
Thanks for cleaning this up, it probably should have been done as part of, or a follow up to, 8140723.

Thanks,
David

@hseigel
Copy link
Member Author

@hseigel hseigel commented Jan 8, 2021

Thanks David!
Harold

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot integrated
3 participants