-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
7022325: TEST_BUG: test/java/util/zip/ZipFile/ReadLongZipFileName.java leaks files if it fails #19492
Conversation
…a leaks files if it fails
👋 Welcome back jpai! A progress list of the required criteria for merging this PR into |
@jaikiran This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 31 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
Webrevs
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Jai,
I think the change is fine. I might suggest that we take the opportunity to convert this test to use junit as part of this PR
Hello Lance, I have now updated the PR to convert this test to junit test. While at it, I have also cleaned up the code to use The test continues to pass with these change in our CI against all platforms. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you Jai, changes look good
Thank you Lance for the review. |
/integrate |
Going to push as commit 4785461.
Your commit was automatically rebased without conflicts. |
Can I please get a review of this test-only change which updates a couple of places in the test to use
try-with-resource
?As noted in https://bugs.openjdk.org/browse/JDK-7022325 this change should prevent leaking of resources in case there's any failure in the test. The test continues to pass with this change.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/19492/head:pull/19492
$ git checkout pull/19492
Update a local copy of the PR:
$ git checkout pull/19492
$ git pull https://git.openjdk.org/jdk.git pull/19492/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 19492
View PR using the GUI difftool:
$ git pr show -t 19492
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/19492.diff
Webrev
Link to Webrev Comment