Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8253206: Enforce whitespace checking for additional source files #195

Closed

Conversation

@kevinrushforth
Copy link
Member

@kevinrushforth kevinrushforth commented Sep 15, 2020

This adds the following extensions to the list of source files that git jcheck will check for whitespace errors:

 .cc, .hh, .m, .mm

All files with the above extensions are now white-space clean after the fix for JDK-8240487. This will help them stay that way.

I just integrated a similar fix to jfx (with a few more source extensions that aren't relevant for the JDK) in JDK-8240499.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8253206: Enforce whitespace checking for additional source files

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/195/head:pull/195
$ git checkout pull/195

@kevinrushforth
Copy link
Member Author

@kevinrushforth kevinrushforth commented Sep 15, 2020

/label add build
/label add 2d

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Sep 15, 2020

👋 Welcome back kcr! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added rfr build labels Sep 15, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Sep 15, 2020

@kevinrushforth
The build label was successfully added.

@openjdk openjdk bot added the 2d label Sep 15, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Sep 15, 2020

@kevinrushforth
The 2d label was successfully added.

@openjdk
Copy link

@openjdk openjdk bot commented Sep 15, 2020

@kevinrushforth To determine the appropriate audience for reviewing this pull request, one or more labels corresponding to different subsystems will normally be applied automatically. However, no automatic labelling rule matches the changes in this pull request.

In order to have an RFR email automatically sent to the correct mailing list, you will need to add one or more labels manually using the /label add "label" command. The following labels are valid: 2d awt beans build compiler core-libs hotspot hotspot-compiler hotspot-gc hotspot-jfr hotspot-runtime i18n javadoc jdk jmx kulla net nio security serviceability shenandoah sound swing.

@kevinrushforth
Copy link
Member Author

@kevinrushforth kevinrushforth commented Sep 15, 2020

/reviewers 2

@openjdk
Copy link

@openjdk openjdk bot commented Sep 15, 2020

@kevinrushforth Only Reviewers are allowed to change the number of required reviewers.

@mlbridge
Copy link

@mlbridge mlbridge bot commented Sep 15, 2020

Webrevs

@prrace
prrace approved these changes Sep 15, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Sep 15, 2020

@kevinrushforth This change now passes all automated pre-integration checks. In addition to the automated checks, the change must also fulfill all project specific requirements

After integration, the commit message will be:

8253206: Enforce whitespace checking for additional source files

Reviewed-by: prr, erikj, jdv
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /issue command.

Since the source branch of this PR was last updated there have been 14 commits pushed to the master branch:

  • e2196f8: 8253162: Make frame::oops_do const
  • 300b851: 8253226: Shenandoah: remove unimplemented ShenandoahStrDedupQueue::verify
  • c781594: 8253224: Shenandoah: ShenandoahStrDedupQueue destructor calls virtual num_queues()
  • 33f8e70: 8253173: Print heap before and after GC lacks a newline
  • f509eb0: 8253219: Epsilon: clean up unnecessary includes
  • 7f9b5d9: 8253220: Epsilon: clean up unused code/declarations
  • e0cf023: 8245309: Re-examine use of ThreadLocalCoders in sun.net.www.ParseUtil
  • 60c4902: 8253016: Box.Filler components should be unfocusable by default
  • dd43533: 8253222: Shenandoah: unused AlwaysTrueClosure after JDK-8246591
  • efe3540: 8252966: CI: Remove KILL_COMPILE_ON_FATAL_ and KILL_COMPILE_ON_ANY macros
  • ... and 4 more: https://git.openjdk.java.net/jdk/compare/65bfe0928af3de1811bfc445fa4bfc0b117f3b96...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid automatic rebasing, please merge master into your branch, and then specify the current head hash when integrating, like this: /integrate e2196f8882b9237926c3ff208bc971c5c31faac7.

As you do not have Committer status in this projectan existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@prrace, @erikj79, @jayathirthrao) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready label Sep 15, 2020
@kevinrushforth
Copy link
Member Author

@kevinrushforth kevinrushforth commented Sep 16, 2020

/integrate

@openjdk openjdk bot added the sponsor label Sep 16, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Sep 16, 2020

@kevinrushforth
Your change (at version 87ef312) is now ready to be sponsored by a Committer.

@jayathirthrao
Copy link
Member

@jayathirthrao jayathirthrao commented Sep 16, 2020

/sponsor

@openjdk openjdk bot closed this Sep 16, 2020
@openjdk openjdk bot added integrated and removed sponsor ready rfr labels Sep 16, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Sep 16, 2020

@jayathirthrao @kevinrushforth Since your change was applied there have been 14 commits pushed to the master branch:

  • e2196f8: 8253162: Make frame::oops_do const
  • 300b851: 8253226: Shenandoah: remove unimplemented ShenandoahStrDedupQueue::verify
  • c781594: 8253224: Shenandoah: ShenandoahStrDedupQueue destructor calls virtual num_queues()
  • 33f8e70: 8253173: Print heap before and after GC lacks a newline
  • f509eb0: 8253219: Epsilon: clean up unnecessary includes
  • 7f9b5d9: 8253220: Epsilon: clean up unused code/declarations
  • e0cf023: 8245309: Re-examine use of ThreadLocalCoders in sun.net.www.ParseUtil
  • 60c4902: 8253016: Box.Filler components should be unfocusable by default
  • dd43533: 8253222: Shenandoah: unused AlwaysTrueClosure after JDK-8246591
  • efe3540: 8252966: CI: Remove KILL_COMPILE_ON_FATAL_ and KILL_COMPILE_ON_ANY macros
  • ... and 4 more: https://git.openjdk.java.net/jdk/compare/65bfe0928af3de1811bfc445fa4bfc0b117f3b96...master

Your commit was automatically rebased without conflicts.

Pushed as commit 1086713.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@kevinrushforth kevinrushforth deleted the kevinrushforth:8253206-jcheck-extra branch Sep 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants