-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8327854: Test java/util/stream/test/org/openjdk/tests/java/util/stream/WhileOpStatefulTest.java failed with RuntimeException #19508
Conversation
👋 Welcome back vklang! A progress list of the required criteria for merging this PR into |
@viktorklang-ora This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 384 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
@viktorklang-ora The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
@viktorklang-ora This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration! |
@AlanBateman @stuart-marks @PaulSandoz This is a PR which improves debug-ability if the test fails, please review at your discretion if possible. |
/integrate |
Going to push as commit 27982c8.
Your commit was automatically rebased without conflicts. |
@viktorklang-ora Pushed as commit 27982c8. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
This PR improves the test failure output for the failing test case, and the underlying issue is likely going to be addressed by #19131 /cc @DougLea
Progress
Issue
Backport <hash>
with the hash of the original commit. See Backports.Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/19508/head:pull/19508
$ git checkout pull/19508
Update a local copy of the PR:
$ git checkout pull/19508
$ git pull https://git.openjdk.org/jdk.git pull/19508/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 19508
View PR using the GUI difftool:
$ git pr show -t 19508
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/19508.diff
Webrev
Link to Webrev Comment