Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8327854: Test java/util/stream/test/org/openjdk/tests/java/util/stream/WhileOpStatefulTest.java failed with RuntimeException #19508

Closed
wants to merge 1 commit into from

Conversation

viktorklang-ora
Copy link
Contributor

@viktorklang-ora viktorklang-ora commented Jun 1, 2024

This PR improves the test failure output for the failing test case, and the underlying issue is likely going to be addressed by #19131 /cc @DougLea


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8327854: Test java/util/stream/test/org/openjdk/tests/java/util/stream/WhileOpStatefulTest.java failed with RuntimeException (Bug - P4) ⚠️ Issue is already resolved. Consider making this a "backport pull request" by setting the PR title to Backport <hash> with the hash of the original commit. See Backports.

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/19508/head:pull/19508
$ git checkout pull/19508

Update a local copy of the PR:
$ git checkout pull/19508
$ git pull https://git.openjdk.org/jdk.git pull/19508/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 19508

View PR using the GUI difftool:
$ git pr show -t 19508

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/19508.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 1, 2024

👋 Welcome back vklang! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jun 1, 2024

@viktorklang-ora This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8327854: Test java/util/stream/test/org/openjdk/tests/java/util/stream/WhileOpStatefulTest.java failed with RuntimeException

Reviewed-by: psandoz

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 384 new commits pushed to the master branch:

  • 2f4f6cc: 8317721: RISC-V: Implement CRC32 intrinsic
  • 3ca2bcd: 8335060: ClassCastException after JDK-8294960
  • 747e1e4: 8334295: CTW: update modules
  • 0a6ffa5: 8261242: [Linux] OSContainer::is_containerized() returns true when run outside a container
  • 71e3798: 8335308: compiler/uncommontrap/DeoptReallocFailure.java times out with SerialGC on Windows
  • c7e9ebb: 8331732: [PPC64] Unify and optimize code which converts != 0 to 1
  • 53242cd: 8335283: Build failure due to 'no_sanitize' attribute directive ignored
  • d9bcf06: 8335217: Fix memory ordering in ClassLoaderData::ChunkedHandleList
  • bb18498: 8335349: jcmd VM.classloaders "fold" option should be optional
  • 8350b1d: 8335294: Fix simple -Wzero-as-null-pointer-constant warnings in gc code
  • ... and 374 more: https://git.openjdk.org/jdk/compare/1e04ee6d57d5fe84e1d202b16e8d13dc13c002ff...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jun 1, 2024
@openjdk
Copy link

openjdk bot commented Jun 1, 2024

@viktorklang-ora The following label will be automatically applied to this pull request:

  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the core-libs core-libs-dev@openjdk.org label Jun 1, 2024
@mlbridge
Copy link

mlbridge bot commented Jun 1, 2024

Webrevs

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 29, 2024

@viktorklang-ora This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@viktorklang-ora
Copy link
Contributor Author

@AlanBateman @stuart-marks @PaulSandoz This is a PR which improves debug-ability if the test fails, please review at your discretion if possible.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jul 1, 2024
@viktorklang-ora
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Jul 2, 2024

Going to push as commit 27982c8.
Since your change was applied there have been 394 commits pushed to the master branch:

  • a347957: 8335291: Problem list all SA core file tests on macosx-aarch64 due to JDK-8318754
  • 153b12b: 8331560: Refactor Hotspot container detection code so that subsystem delegates to controllers
  • 685e587: 8334816: compiler/c2/irTests/TestIfMinMax.java fails after 8334629
  • dd74e7f: 8335147: Serial: Refactor TenuredGeneration::promote
  • a537e87: 8335530: Java file extension missing in AuthenticatorTest
  • 4060b35: 8335298: Fix -Wzero-as-null-pointer-constant warning in G1CardSetContainers
  • 9046d7a: 8335390: C2 MergeStores: wrong result with Unsafe
  • 318d9ac: 8335369: Fix -Wzero-as-null-pointer-constant warnings in ImmutableOopMapBuilder
  • 5fe07b3: 5021949: JSplitPane setEnabled(false) shouldn't be partially functional
  • ee4720a: 8333306: gc/arguments/TestParallelGCErgo.java fails when largepage are enabled
  • ... and 384 more: https://git.openjdk.org/jdk/compare/1e04ee6d57d5fe84e1d202b16e8d13dc13c002ff...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jul 2, 2024
@openjdk openjdk bot closed this Jul 2, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jul 2, 2024
@openjdk
Copy link

openjdk bot commented Jul 2, 2024

@viktorklang-ora Pushed as commit 27982c8.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core-libs core-libs-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants