-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8206447: InflaterInputStream.skip receives long but it's limited to Integer.MAX_VALUE #19515
Conversation
👋 Welcome back jpai! A progress list of the required criteria for merging this PR into |
@jaikiran This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 58 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
Webrevs
|
The CSR is available for review at https://bugs.openjdk.org/browse/JDK-8333400 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This went through a few iterations in the CSR issue, looking good now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
latest update looks good. Thank you and Alan for the additional wordsmithing
Thank you all for the reviews and the inputs to the specification text. The CSR has been approved, so I'll integrate this now. |
/integrate |
Going to push as commit d7d1afb.
Your commit was automatically rebased without conflicts. |
Can I please get a review of this change which updates the API specification of
java.util.zip.InflaterInputStream.skip()
method to match its current implementation?InflaterInputStream.skip()
, just likeDeflaterInputStream.skip()
, takes along
valuen
representing the number of bytes to skip. When a value greater thanInteger.MAX_VALUE
is passed to thisInflaterInputStream.skip()
method, the current implementation in that method only skips at mostInteger.MAX_VALUE
bytes.DeflaterInputStream.skip()
too has the same behaviour. However, in the case ofDeflaterInputStream.skip()
, this semantic is clearly noted in that method's API documentation.InflaterInputStream.skip()
currently doesn't specify this behaviour.The commit in this PR updates the
InflaterInputStream.skip()
to specify the current implementation.I'll open a CSR for this change.
Progress
Issues
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/19515/head:pull/19515
$ git checkout pull/19515
Update a local copy of the PR:
$ git checkout pull/19515
$ git pull https://git.openjdk.org/jdk.git pull/19515/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 19515
View PR using the GUI difftool:
$ git pr show -t 19515
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/19515.diff
Webrev
Link to Webrev Comment