8333410: [AArch64] Clean unused classes in nativeInst_aarch64.hpp

[kuaiwei]

Some classes in nativeInst_aarch64.hpp are unused and can be removed.

I checked with tier1 tests.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8333410: [AArch64] Clean unused classes in nativeInst_aarch64.hpp (Enhancement - P4)

Reviewers

• Andrew Haley (@theRealAph - Reviewer)
• Christian Hagedorn (@chhagedorn - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/19518/head:pull/19518
$ git checkout pull/19518

Update a local copy of the PR:
$ git checkout pull/19518
$ git pull https://git.openjdk.org/jdk.git pull/19518/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 19518

View PR using the GUI difftool:
$ git pr show -t 19518

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/19518.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back kuaiwei! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@kuaiwei This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8333410: [AArch64] Clean unused classes in nativeInst_aarch64.hpp

Reviewed-by: aph, chagedorn

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 65 new commits pushed to the master branch:

• 6f690a5: 8333177: Invalid value used for enum Cell in ciTypeFlow::get_start_state
• b351b5f: 8331736: C2: Live Node limit exceeded limit after JDK-8316991
• b3f540d: 8332921: Ctrl+C does not call shutdown hooks after JLine upgrade
• 3089412: 8326716: JVMTI spec: clarify what nullptr means for C/C++ developers
• ca93907: 8256828: ostream::print_cr() truncates buffer in copy-through case
• 60ea17e: 8311177: Switching to interpreter only mode in carrier thread can lead to crashes
• 7564949: 8291643: Consider omitting type annotations from type error diagnostics
• 4c09d9f: 8332119: Incorrect IllegalArgumentException for C2 compiled permute kernel
• f7dbb98: 8333086: Using Console.println is unnecessarily slow due to JLine initalization
• 9b3694c: 8319822: Use a linear-time algorithm for assert_different_registers()
• ... and 55 more: https://git.openjdk.org/jdk/compare/91101f0d4fc8e06d0d74e06361db6ac87efeeb8e...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@theRealAph, @chhagedorn) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[openjdk]

@kuaiwei The following label will be automatically applied to this pull request:

• hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (ea97921e)

[theRealAph]

Mmm, interesting. Let me have a look at why these are there.

[theRealAph]

OK, it's some remnants of the Graal-based jaotc. Patch approved.

[kuaiwei]

OK, it's some remnants of the Graal-based jaotc. Patch approved.

Thanks for quick review. Wait for another approve.

[chhagedorn]

Looks good to me, too.

[kuaiwei]

Looks good to me, too.

Thanks.

[kuaiwei]

/integrate

[openjdk]

@kuaiwei
Your change (at version ea97921) is now ready to be sponsored by a Committer.

[kuaiwei]

@theRealAph @chhagedorn Could you help to sponsor it? Thanks.

[TheShermanTanker]

I'll help sponsor, but I'm a little concerned about the "⚠️ Found leading lowercase letter in issue title for 8333410: [AArch64] clean unused classes in nativeInst_aarch64.hpp" - Is that an issue?

[offamitkumar]

"⚠️ Found leading lowercase letter in issue title for 8333410: [AArch64] clean unused classes in nativeInst_aarch64.hpp" - Is that an issue?

I think it's complaining because instead of clean it should have been Clean; That should not be a problem.

[kuaiwei]

I'll help sponsor, but I'm a little concerned about the "⚠️ Found leading lowercase letter in issue title for 8333410: [AArch64] clean unused classes in nativeInst_aarch64.hpp" - Is that an issue?

I didn't noticed the warning before. It can be fixed after changing title. Thanks.

[TheShermanTanker]

/sponsor

[openjdk]

Going to push as commit 8f07853.
Since your change was applied there have been 65 commits pushed to the master branch:

• 6f690a5: 8333177: Invalid value used for enum Cell in ciTypeFlow::get_start_state
• b351b5f: 8331736: C2: Live Node limit exceeded limit after JDK-8316991
• b3f540d: 8332921: Ctrl+C does not call shutdown hooks after JLine upgrade
• 3089412: 8326716: JVMTI spec: clarify what nullptr means for C/C++ developers
• ca93907: 8256828: ostream::print_cr() truncates buffer in copy-through case
• 60ea17e: 8311177: Switching to interpreter only mode in carrier thread can lead to crashes
• 7564949: 8291643: Consider omitting type annotations from type error diagnostics
• 4c09d9f: 8332119: Incorrect IllegalArgumentException for C2 compiled permute kernel
• f7dbb98: 8333086: Using Console.println is unnecessarily slow due to JLine initalization
• 9b3694c: 8319822: Use a linear-time algorithm for assert_different_registers()
• ... and 55 more: https://git.openjdk.org/jdk/compare/91101f0d4fc8e06d0d74e06361db6ac87efeeb8e...master

Your commit was automatically rebased without conflicts.

[openjdk]

@TheShermanTanker @kuaiwei Pushed as commit 8f07853.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

[kuaiwei]

/sponsor

Thanks