Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8259232: Bad JNI lookup during printing #1952

Closed
wants to merge 1 commit into from
Closed

8259232: Bad JNI lookup during printing #1952

wants to merge 1 commit into from

Conversation

prrace
Copy link
Contributor

@prrace prrace commented Jan 6, 2021

Didn't hit this because all the print testing I conducted used the swing print + page dialog but the logging made it easy to find the source of the problem.
I've also done an audit of GET_METHOD_* usages for this pattern - I had previously done it for DECLARE_METHOD* which is the bulk.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/1952/head:pull/1952
$ git checkout pull/1952

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 6, 2021

👋 Welcome back prr! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jan 6, 2021
@openjdk
Copy link

openjdk bot commented Jan 6, 2021

@prrace The following label will be automatically applied to this pull request:

  • awt

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the awt client-libs-dev@openjdk.org label Jan 6, 2021
@mlbridge
Copy link

mlbridge bot commented Jan 6, 2021

Webrevs

@prrace
Copy link
Contributor Author

prrace commented Jan 6, 2021

/label add 2d

@openjdk openjdk bot added the 2d client-libs-dev@openjdk.org label Jan 6, 2021
@openjdk
Copy link

openjdk bot commented Jan 6, 2021

@prrace
The 2d label was successfully added.

@openjdk
Copy link

openjdk bot commented Jan 6, 2021

@prrace This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8259232: Bad JNI lookup during printing

Reviewed-by: psadhukhan

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 8 new commits pushed to the master branch:

  • 32538b5: 8193942: Regression automated test '/open/test/jdk/javax/swing/JFrame/8175301/ScaledFrameBackgroundTest.java' fails
  • 52d3fee: 8258813: [TESTBUG] Fix incorrect Vector API test output message
  • 8b45497: 8259037: livenmethods cannot find hsdis library
  • 7d76966: 8255757: Javac emits duplicate pool entries on array::clone
  • cf9908b: 8258937: Remove JVM IgnoreRewrites flag
  • 4d3d599: 8259223: Simplify boolean expression in the SunJSSE provider
  • 1b60acd: 8259252: Shenandoah: Shenandoah build failed on AArch64 after JDK-8258459
  • 7ddc2b5: 8258852: Arrays.asList() for single item could be replaced with List.of()

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jan 6, 2021
@prrace
Copy link
Contributor Author

prrace commented Jan 6, 2021

/integrate

@openjdk openjdk bot closed this Jan 6, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jan 6, 2021
@openjdk
Copy link

openjdk bot commented Jan 6, 2021

@prrace Since your change was applied there have been 17 commits pushed to the master branch:

  • df721f0: 8259291: Cleanup unnecessary local variables
  • d20d2fa: 8258143: Update --release 16 symbol information for JDK 16 build 30 or later
  • 3be6e06: 8259312: VerifyCACerts.java fails as soneraclass2ca cert will expire in 90 days
  • 722f236: 8259231: Epsilon: improve performance under contention during virtual space expansion
  • f6cb8c5: 8258908: Remove JVM option CleanChunkPoolAsync
  • c0540ff: 8231627: ThreadsListHandleInErrorHandlingTest.java fails in printing all threads
  • 7e01bc9: 8255264: Support for identifying the full range of IPv4 localhost addresses on Windows
  • 8a05d60: 8259042: Inconsistent use of general primitives loops
  • e3b9da1: 8259287: AbstractCompiler marks const in wrong position for is_c1/is_c2/is_jvmci
  • 32538b5: 8193942: Regression automated test '/open/test/jdk/javax/swing/JFrame/8175301/ScaledFrameBackgroundTest.java' fails
  • ... and 7 more: https://git.openjdk.java.net/jdk/compare/85bac8c415070992a9807599fe1ec07e4ed0c562...master

Your commit was automatically rebased without conflicts.

Pushed as commit 940b053.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@@ -58,7 +58,7 @@

#define GET_CPRINTERDIALOG_METHOD_RETURN(ret) \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess the name of the macro should be renamed as well?

@prrace prrace deleted the pj_get_field branch February 10, 2021 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2d client-libs-dev@openjdk.org awt client-libs-dev@openjdk.org integrated Pull request has been integrated
3 participants