8331731: ubsan: relocInfo.cpp:155:30: runtime error: applying non-zero offset to null pointer

[vnkozlov]

Avoid iterations on empty relocation info. Found by running ubsan.

Tested tier1-4, stress, xcomp.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8331731: ubsan: relocInfo.cpp:155:30: runtime error: applying non-zero offset to null pointer (Bug - P4)

Reviewers

• Martin Doerr (@TheRealMDoerr - Reviewer)
• Tobias Hartmann (@TobiHartmann - Reviewer)
• Matthias Baesken (@MBaesken - Reviewer)

Contributors

• Axel Boldt-Christmas <aboldtch@openjdk.org>
• Dean Long <dlong@openjdk.org>

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/19525/head:pull/19525
$ git checkout pull/19525

Update a local copy of the PR:
$ git checkout pull/19525
$ git pull https://git.openjdk.org/jdk.git pull/19525/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 19525

View PR using the GUI difftool:
$ git pr show -t 19525

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/19525.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back kvn! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[vnkozlov]

/contributor add @xmas92

[openjdk]

@vnkozlov This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8331731: ubsan: relocInfo.cpp:155:30: runtime error: applying non-zero offset to null pointer

Co-authored-by: Axel Boldt-Christmas <aboldtch@openjdk.org>
Co-authored-by: Dean Long <dlong@openjdk.org>
Reviewed-by: mdoerr, thartmann, mbaesken

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 27 new commits pushed to the master branch:

• 8d3de45: 8325168: JShell should support Markdown comments
• 9ee741d: 8332015: since-checker - Add @ since tags to jdk.httpserver
• 0f4154a: 8331193: Return references when possible in GrowableArray
• 64bbae7: 8333394: C2: assert(bol->is_Opaque4() || bol->is_OpaqueInitializedAssertionPredicate()) failed: Opaque node of non-null-check or of Initialized Assertion Predicate
• c7495fb: 8333444: Parallel: Inline PSParallelCompact::mark_obj
• 454660d: 8332900: RISC-V: refactor nativeInst_riscv.cpp and macroAssembler_riscv.cpp
• 67d6f3c: 8332905: C2 SuperWord: bad AD file, with RotateRightV and first operand not a pack
• ca30726: 8332866: Crash in ImageIO JPEG decoding when MEM_STATS in enabled
• 29e10e4: 8332547: Unloaded signature classes in DirectMethodHandles
• c7d2a5c: 8314070: javax.print: Support IPP output-bin attribute extension
• ... and 17 more: https://git.openjdk.org/jdk/compare/a4c7be862cc6dc121efb6c1c283236a588259c8f...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@vnkozlov
Contributor Axel Boldt-Christmas <aboldtch@openjdk.org> successfully added.

[vnkozlov]

/contributor add @dean-long

[openjdk]

@vnkozlov
Contributor Dean Long <dlong@openjdk.org> successfully added.

[openjdk]

@vnkozlov The following label will be automatically applied to this pull request:

• hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (c23bf6c8)

[TheRealMDoerr]

LGTM. Thanks! @MBaesken: Can you verify it, please?

[MBaesken]

LGTM. Thanks! @MBaesken: Can you verify it, please?

Worked with ubsan enabled (Linux x86_64 fastdebug build) .

[TobiHartmann]

Looks good to me too.

[vnkozlov]

Thank you for reviews.

[vnkozlov]

/integrate

[openjdk]

Going to push as commit 664c993.
Since your change was applied there have been 27 commits pushed to the master branch:

• 8d3de45: 8325168: JShell should support Markdown comments
• 9ee741d: 8332015: since-checker - Add @ since tags to jdk.httpserver
• 0f4154a: 8331193: Return references when possible in GrowableArray
• 64bbae7: 8333394: C2: assert(bol->is_Opaque4() || bol->is_OpaqueInitializedAssertionPredicate()) failed: Opaque node of non-null-check or of Initialized Assertion Predicate
• c7495fb: 8333444: Parallel: Inline PSParallelCompact::mark_obj
• 454660d: 8332900: RISC-V: refactor nativeInst_riscv.cpp and macroAssembler_riscv.cpp
• 67d6f3c: 8332905: C2 SuperWord: bad AD file, with RotateRightV and first operand not a pack
• ca30726: 8332866: Crash in ImageIO JPEG decoding when MEM_STATS in enabled
• 29e10e4: 8332547: Unloaded signature classes in DirectMethodHandles
• c7d2a5c: 8314070: javax.print: Support IPP output-bin attribute extension
• ... and 17 more: https://git.openjdk.org/jdk/compare/a4c7be862cc6dc121efb6c1c283236a588259c8f...master

Your commit was automatically rebased without conflicts.

[openjdk]

@vnkozlov Pushed as commit 664c993.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.