JDK-8333360 : PrintNullString.java doesn't use float arguments #19540

Renjithkannath · 2024-06-04T12:07:40Z

Hi Reviewers,
I have updated the test case with passing float value for evaluation and a typo. Please review and let me know your suggestions if any.

Progress

Change must be properly reviewed (1 review required, with at least 1 Reviewer)
Change must not contain extraneous whitespace
Commit message must refer to an issue

Issue

JDK-8333360: PrintNullString.java doesn't use float arguments (Bug - P4)

Reviewers

Alexey Ivanov (@aivanov-jdk - Reviewer)
Abhishek Kumar (@kumarabhi006 - Committer)
Alisen Chung (@alisenchung - Committer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/19540/head:pull/19540
$ git checkout pull/19540

Update a local copy of the PR:
$ git checkout pull/19540
$ git pull https://git.openjdk.org/jdk.git pull/19540/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 19540

View PR using the GUI difftool:
$ git pr show -t 19540

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/19540.diff

Webrev

Link to Webrev Comment

bridgekeeper · 2024-06-04T12:08:23Z

👋 Welcome back rkannathpari! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

openjdk · 2024-06-04T12:09:19Z

@Renjithkannath This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8333360: PrintNullString.java doesn't use float arguments

Reviewed-by: aivanov, abhiscxk, achung

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 102 new commits pushed to the master branch:

9691153: 8329141: Obsolete RTM flags and code
13642cb: 8333828: Use value javadoc tag in java.lang.{Float, Double}
b254762: 8333829: ProblemList sun/security/pkcs11/sslecc/ClientJSSEServerJSSE.java due to JDK-8333317
b68609f: 8333779: Parallel: Remove Summary phase related debug print during Full GC
6ea28fb: 8333641: Serial: Remove Generation::supports_tlab_allocation
ce5727d: 8333652: RISC-V: compiler/vectorapi/VectorGatherMaskFoldingTest.java fails when using RVV
e0afe0b: 8326085: Remove unnecessary UpcallContext constructor
2a242db: 8325821: [REDO] use "dmb.ishst+dmb.ishld" for release barrier
e7dc76b: 8333849: (dc) DatagramChannel send/receive fails with UOE if buffer backed by memory segment allocated from shared arena
ec1664e: 8333804: java/net/httpclient/ForbiddenHeadTest.java threw an exception with 0 failures
... and 92 more: https://git.openjdk.org/jdk/compare/0f4154a9e9805534595feccc53a4a1abf20f99ae...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@aivanov-jdk, @kumarabhi006, @alisenchung) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

openjdk · 2024-06-04T12:09:48Z

@Renjithkannath The following label will be automatically applied to this pull request:

client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

mlbridge · 2024-06-04T12:14:18Z

Webrevs

00: Full (1233e2e2)

Renjithkannath · 2024-06-05T03:19:40Z

/integrate

openjdk · 2024-06-05T03:19:57Z

@Renjithkannath
Your change (at version 1233e2e) is now ready to be sponsored by a Committer.

kumarabhi006 · 2024-06-05T04:53:56Z

test/jdk/java/awt/print/PrinterJob/PrintNullString.java


            try {
-                g2d.drawString(emptyIterator, 20, 180);
+                g2d.drawString(emptyIterator, 20.0f, 180.0f);


Does the line below also need to change ?
g2d.drawString("FAILURE: No IAE for empty iterator, float", 20.0f 180.0f);

No, it does not. It may though.

The test declares it verifies drawString(Iterator, float, float) — the test does it now. How the error message is output on the screen isn't important: either int or float version will do the same thing.

@aivanov-jdk Thank you for clarification.

kumarabhi006

Ran the updated test and looks good to me.

alisenchung

Maybe outside the scope of this issue, but could this test be automated?

aivanov-jdk · 2024-06-10T20:33:05Z

Maybe outside the scope of this issue, but could this test be automated?

I've been thinking about it, too.

No, it can't be automated completely: the tester has to click Print / OK button in the Print dialog.

Yes, other aspects of the test can be automated. The test code already detects a failure and reports it on the screen or on paper, thus the test can fail automatically if a failure condition is found.

However, the first part where it paints on the screen can be fully automated. It could be moved to an independent test.

These improvements to the test can be combined with fixing JDK-8333026, or the test can be updated separately.

I'll submit a new bug to track this activity. Thank you for bringing it up.

alisenchung

small typo and typing change, LGTM

aivanov-jdk · 2024-06-11T11:45:45Z

/sponsor

openjdk · 2024-06-11T11:47:20Z

Going to push as commit aaaa86b.
Since your change was applied there have been 112 commits pushed to the master branch:

ef101f1: 8332920: C2: Partial Peeling is wrongly applied for CmpU with negative limit
2843745: 8333972: Parallel: Remove unused methods in PSOldGen
93f3918: 8333954: Parallel: Remove unused arguments of type ParCompactionManager*
788b876: 8333917: G1: Refactor G1CollectedHeap::register_old_region_with_region_attr
0e4d4a0: 8320725: AArch64: C2: Add "requires_strict_order" flag for floating-point add and mul reduction
badf1cb: 8331675: gtest CollectorPolicy.young_min_ergo_vm fails after 8272364
4d6064a: 8333649: Allow different NativeCall encodings
fe9c63c: 8333931: Problemlist serviceability/jvmti/vthread/CarrierThreadEventNotification
41c88bc: 8333756: java/lang/instrument/NativeMethodPrefixApp.java failed due to missing intrinsic
3a01b47: 8330205: Initial troff manpage generation for JDK 24
... and 102 more: https://git.openjdk.org/jdk/compare/0f4154a9e9805534595feccc53a4a1abf20f99ae...master

Your commit was automatically rebased without conflicts.

openjdk · 2024-06-11T11:47:27Z

@aivanov-jdk @Renjithkannath Pushed as commit aaaa86b.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

aivanov-jdk · 2024-06-11T12:42:52Z

These improvements to the test can be combined with fixing JDK-8333026, or the test can be updated separately.

I'll submit a new bug to track this activity. Thank you for bringing it up.

I've submitted JDK-8334016: Make PrintNullString.java semi-automatic.

JDK-8333360 : PrintNullString.java doesn't use float arguments

1233e2e

openjdk bot added the rfr Pull request is ready for review label Jun 4, 2024

openjdk bot added the client client-libs-dev@openjdk.org label Jun 4, 2024

aivanov-jdk approved these changes Jun 4, 2024

View reviewed changes

openjdk bot added the ready Pull request is ready to be integrated label Jun 4, 2024

openjdk bot added the sponsor Pull request is ready to be sponsored label Jun 5, 2024

kumarabhi006 reviewed Jun 5, 2024

View reviewed changes

kumarabhi006 approved these changes Jun 5, 2024

View reviewed changes

alisenchung reviewed Jun 10, 2024

View reviewed changes

alisenchung approved these changes Jun 10, 2024

View reviewed changes

openjdk bot added the integrated Pull request has been integrated label Jun 11, 2024

openjdk bot closed this Jun 11, 2024

openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Jun 11, 2024

Renjithkannath deleted the 8333360-v1 branch April 8, 2025 04:13

JDK-8333360 : PrintNullString.java doesn't use float arguments #19540

JDK-8333360 : PrintNullString.java doesn't use float arguments #19540

Uh oh!

Conversation

Renjithkannath commented Jun 4, 2024 • edited by openjdk bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Progress

Issue

Reviewers

Reviewing

Webrev

Uh oh!

bridgekeeper bot commented Jun 4, 2024

Uh oh!

openjdk bot commented Jun 4, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openjdk bot commented Jun 4, 2024

Uh oh!

mlbridge bot commented Jun 4, 2024

Webrevs

Uh oh!

Renjithkannath commented Jun 5, 2024

Uh oh!

openjdk bot commented Jun 5, 2024

Uh oh!

kumarabhi006 Jun 5, 2024

Choose a reason for hiding this comment

Uh oh!

aivanov-jdk Jun 5, 2024

Choose a reason for hiding this comment

Uh oh!

kumarabhi006 Jun 5, 2024

Choose a reason for hiding this comment

Uh oh!

kumarabhi006 left a comment

Choose a reason for hiding this comment

Uh oh!

alisenchung left a comment

Choose a reason for hiding this comment

Uh oh!

aivanov-jdk commented Jun 10, 2024

Uh oh!

alisenchung left a comment

Choose a reason for hiding this comment

Uh oh!

aivanov-jdk commented Jun 11, 2024

Uh oh!

openjdk bot commented Jun 11, 2024

Uh oh!

openjdk bot commented Jun 11, 2024

Uh oh!

aivanov-jdk commented Jun 11, 2024

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

4 participants

Renjithkannath commented Jun 4, 2024 •

edited by openjdk bot

Loading

openjdk bot commented Jun 4, 2024 •

edited

Loading