8326705: Test CertMsgCheck.java fails to find alert certificate_required

[ascarpino]

Hi,

I need a review for this simple change to fix a threading problem with the test. The server thread was not completing before the check occurred on the main thread. The failure showed up in windows and macos, but not linux. With this fix, running 100 times, windows & macos showed no failures.

Tony

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8326705: Test CertMsgCheck.java fails to find alert certificate_required (Bug - P3)

Reviewers

• Sibabrata Sahoo (@sisahoo - Committer)
• Rajan Halade (@rhalade - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/19553/head:pull/19553
$ git checkout pull/19553

Update a local copy of the PR:
$ git checkout pull/19553
$ git pull https://git.openjdk.org/jdk.git pull/19553/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 19553

View PR using the GUI difftool:
$ git pr show -t 19553

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/19553.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back ascarpino! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@ascarpino This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8326705: Test CertMsgCheck.java fails to find alert certificate_required

Reviewed-by: ssahoo, rhalade

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 273 new commits pushed to the master branch:

• 57f8b91: 8333658: NMT: Use an allocator with 4-byte pointers to save memory in NativeCallStackStorage
• 6c67933: 8334899: Test runtime/cds/appcds/javaldr/ExceptionDuringDumpAtObjectsInitPhase.java failed after JDK-8306580
• cae94b2: 8334397: RISC-V: verify perf of ReverseBytesS/US
• 75a2afa: 8248981: Specify list of standard message digest and mgf algorithms for RSASSA-PSS signature
• baafa66: 8334287: Man page update for jstatd deprecation
• c30e040: 8331911: Reconsider locking for recently disarmed nmethods
• 974dca8: 8334223: Make Arena MEMFLAGs immutable
• e527e1c: 8334580: Deprecate no-arg constructor BasicSliderUI() for removal
• 3a26bbc: 8185429: [macos] After a modal dialog is closed, no window becomes active
• 4b153e5: 8306580: Propagate CDS dumping errors instead of directly exiting the VM
• ... and 263 more: https://git.openjdk.org/jdk/compare/9686e804a2b058955ff88149c54a0a7896c0a2eb...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@ascarpino The following label will be automatically applied to this pull request:

• security

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (0fc5d554)

[ascarpino]

/integrate

[openjdk]

@ascarpino This pull request has not yet been marked as ready for integration.

[ascarpino]

/integrate

[openjdk]

Going to push as commit 4ffc5e6.
Since your change was applied there have been 292 commits pushed to the master branch:

• efb905e: 8334618: ubsan: support setting additional ubsan check options
• b2ac725: 8327380: Add tests for Shenandoah barrier expansion optimization
• f23295e: 8334600: TEST java/net/MulticastSocket/IPMulticastIF.java fails on linux-aarch64
• 741a0f3: 8334241: Adjust API docs side bar dimensions
• 4ce8822: 8334037: Local class creation in lambda in pre-construction context crashes javac
• 7f6804c: 8334872: BigEndian: java/lang/invoke/condy Tests failing since JDK-8294960
• e139005: 8333994: NMT: call stacks should show source information
• b88af94: 8269870: PS: Membar in PSPromotionManager::copy_unmarked_to_survivor_space could be relaxed
• a5f401f: 8334650: Add debug information about whether an Assertion Predicate is for the init or last value
• 25c3845: 8333133: Simplify QuickSort::sort
• ... and 282 more: https://git.openjdk.org/jdk/compare/9686e804a2b058955ff88149c54a0a7896c0a2eb...master

Your commit was automatically rebased without conflicts.

[openjdk]

@ascarpino Pushed as commit 4ffc5e6.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

[ascarpino]

/backport jdk jdk23

[openjdk]

@ascarpino the backport was successfully created on the branch backport-ascarpino-4ffc5e60-jdk23 in my personal fork of openjdk/jdk. To create a pull request with this backport targeting openjdk/jdk:jdk23, just click the following link:

➡️ Create pull request

The title of the pull request is automatically filled in correctly and below you find a suggestion for the pull request body:

Hi all,

This pull request contains a backport of commit 4ffc5e60 from the openjdk/jdk repository.

The commit being backported was authored by Anthony Scarpino on 26 Jun 2024 and was reviewed by Sibabrata Sahoo and Rajan Halade.

Thanks!

If you need to update the source branch of the pull then run the following commands in a local clone of your personal fork of openjdk/jdk:

$ git fetch https://github.com/openjdk-bots/jdk.git backport-ascarpino-4ffc5e60-jdk23:backport-ascarpino-4ffc5e60-jdk23
$ git checkout backport-ascarpino-4ffc5e60-jdk23
# make changes
$ git add paths/to/changed/files
$ git commit --message 'Describe additional changes made'
$ git push https://github.com/openjdk-bots/jdk.git backport-ascarpino-4ffc5e60-jdk23

⚠️ @ascarpino You are not yet a collaborator in my fork openjdk-bots/jdk. An invite will be sent out and you need to accept it before you can proceed.