8333590: UnmodifiableHeaders.toString() returns a value that represents empty headers

[jaikiran]

Can I please get a review of this change which proposes to fix the issue noted in https://bugs.openjdk.org/browse/JDK-8333590?

As noted in that issue the sun.net.httpserver.UnmodifiableHeaders, an internal class, within the jdk.httpserver module doesn't override the toString() method. UnmodifiableHeaders is of type com.sun.net.httpserver.Headers which is a public API in the jdk.httpserver module.

When applications call Headers.toString(), if the instance is of type UnmodifiableHeaders, then the returned String representation shows empty headers, even when it isn't empty. The commit in this PR fixes the issue by implementing toString() in the UnmodifiableHeaders to return the correct representation of the headers.

An existing jtreg test has been updated to reproduce this issue and verify the fix.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8333590: UnmodifiableHeaders.toString() returns a value that represents empty headers (Bug - P4)

Reviewers

• Daniel Fuchs (@dfuch - Reviewer)
• Michael McMahon (@Michael-Mc-Mahon - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/19555/head:pull/19555
$ git checkout pull/19555

Update a local copy of the PR:
$ git checkout pull/19555
$ git pull https://git.openjdk.org/jdk.git pull/19555/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 19555

View PR using the GUI difftool:
$ git pr show -t 19555

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/19555.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back jpai! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@jaikiran This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8333590: UnmodifiableHeaders.toString() returns a value that represents empty headers

Reviewed-by: dfuchs, michaelm

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 8 new commits pushed to the master branch:

• 789f704: 8322732: ForkJoinPool may underutilize cores in async mode
• 2c1b311: 8331854: ubsan: copy.hpp:218:10: runtime error: addition of unsigned offset to 0x7fc2b4024518 overflowed to 0x7fc2b4024510
• 765ad0e: 8331947: Preview creates checkbox for JEP-less preview feature
• 8e903ee: 8331896: JFR: Improve check for JDK classes
• 3cbdf8d: 8333554: Parallel: Remove unused PSParallelCompact::is_in
• 3944e67: 8312132: Add tracking of multiple address spaces in NMT
• d0052c0: 8333326: Linux Alpine build fails after 8302744
• 4369856: 8333130: MakeJAR2.sh uses hard-coded JDK version

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@jaikiran The following label will be automatically applied to this pull request:

• net

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (29a42d97)
• 00: Full (c4713380)

[dfuch]

LGTM

[Michael-Mc-Mahon]

Looks fine.

[jaikiran]

Thank you Daniel and Michael for the reviews. CI tier tests came back fine. I'll go ahead with the integration shortly.

[jaikiran]

/integrate

[openjdk]

Going to push as commit 6882b38.
Since your change was applied there have been 9 commits pushed to the master branch:

• cbb6747: 8329581: Java launcher no longer prints a stack trace
• 789f704: 8322732: ForkJoinPool may underutilize cores in async mode
• 2c1b311: 8331854: ubsan: copy.hpp:218:10: runtime error: addition of unsigned offset to 0x7fc2b4024518 overflowed to 0x7fc2b4024510
• 765ad0e: 8331947: Preview creates checkbox for JEP-less preview feature
• 8e903ee: 8331896: JFR: Improve check for JDK classes
• 3cbdf8d: 8333554: Parallel: Remove unused PSParallelCompact::is_in
• 3944e67: 8312132: Add tracking of multiple address spaces in NMT
• d0052c0: 8333326: Linux Alpine build fails after 8302744
• 4369856: 8333130: MakeJAR2.sh uses hard-coded JDK version

Your commit was automatically rebased without conflicts.

[openjdk]

@jaikiran Pushed as commit 6882b38.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.