8322568: JFR: Improve metadata for IEEE rounding mode fields

[egahlin]

Could I have review of a couple of changes that align the style of the new event fields with other events, no abbreviations (env) and headline-style capitalization for the label.

Testring: jdk/jdk/jfr

Thanks
Erik

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8322568: JFR: Improve metadata for IEEE rounding mode fields (Bug - P3)

Reviewers

• Markus Grönlund (@mgronlun - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/19560/head:pull/19560
$ git checkout pull/19560

Update a local copy of the PR:
$ git checkout pull/19560
$ git pull https://git.openjdk.org/jdk.git pull/19560/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 19560

View PR using the GUI difftool:
$ git pr show -t 19560

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/19560.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back egahlin! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@egahlin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8322568: JFR: Improve metadata for IEEE rounding mode fields

Reviewed-by: mgronlun

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 87 new commits pushed to the master branch:

• f73922b: 8333235: vmTestbase/nsk/jdb/kill/kill001/kill001.java fails with C1
• 5dcb7a6: 8160755: bug6492108.java test fails with exception Image comparison failed at (0, 0) for image 4 in GTK L&F
• 438121b: 8332785: Replace naked uses of UseSharedSpaces with CDSConfig::is_using_archive
• d7d1afb: 8206447: InflaterInputStream.skip receives long but it's limited to Integer.MAX_VALUE
• 7acfba2: 8327650: Test java/nio/channels/DatagramChannel/StressNativeSignal.java timed out
• c5c0867: 8333252: C2: assert(assertion_predicate_has_loop_opaque_node(iff)) failed: must find OpaqueLoop* nodes
• d85b0ca: 8332457: Examine startup overheads from JDK-8294961
• 326dbb1: 8312436: CompletableFuture never completes when 'Throwable.toString()' method throws Exception
• 9a8096f: 8330047: ASAN build error with gcc 13
• 6882b38: 8333590: UnmodifiableHeaders.toString() returns a value that represents empty headers
• ... and 77 more: https://git.openjdk.org/jdk/compare/a7864af08acbe63d09f770ca66780738260faac4...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@egahlin The following label will be automatically applied to this pull request:

• hotspot-jfr

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (1352a451)

[egahlin]

/integrate

[openjdk]

Going to push as commit 1a50bd0.
Since your change was applied there have been 101 commits pushed to the master branch:

• 880c6b4: 8333178: ubsan: jvmti_tools.cpp:149:16: runtime error: null pointer passed as argument 2, which is declared to never be null
• c7d2841: 8332070: Convert package.html files in java.management to package-info.java
• 7ef2831: 8333644: C2: assert(is_Bool()) failed: invalid node class: Phi
• 8f07853: 8333410: [AArch64] Clean unused classes in nativeInst_aarch64.hpp
• 6f690a5: 8333177: Invalid value used for enum Cell in ciTypeFlow::get_start_state
• b351b5f: 8331736: C2: Live Node limit exceeded limit after JDK-8316991
• b3f540d: 8332921: Ctrl+C does not call shutdown hooks after JLine upgrade
• 3089412: 8326716: JVMTI spec: clarify what nullptr means for C/C++ developers
• ca93907: 8256828: ostream::print_cr() truncates buffer in copy-through case
• 60ea17e: 8311177: Switching to interpreter only mode in carrier thread can lead to crashes
• ... and 91 more: https://git.openjdk.org/jdk/compare/a7864af08acbe63d09f770ca66780738260faac4...master

Your commit was automatically rebased without conflicts.

[openjdk]

@egahlin Pushed as commit 1a50bd0.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.