Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8333674: Disable CollectorPolicy.young_min_ergo_vm for PPC64 #19566

Conversation

TheRealMDoerr
Copy link
Contributor

@TheRealMDoerr TheRealMDoerr commented Jun 5, 2024

The test doesn't work on PPC64 and should be disabled until it is fixed. Subtask of JDK-8331675.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8333674: Disable CollectorPolicy.young_min_ergo_vm for PPC64 (Sub-task - P3)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/19566/head:pull/19566
$ git checkout pull/19566

Update a local copy of the PR:
$ git checkout pull/19566
$ git pull https://git.openjdk.org/jdk.git pull/19566/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 19566

View PR using the GUI difftool:
$ git pr show -t 19566

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/19566.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 5, 2024

👋 Welcome back mdoerr! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jun 5, 2024

@TheRealMDoerr This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8333674: Disable CollectorPolicy.young_min_ergo_vm for PPC64

Reviewed-by: mbaesken, zgu

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 223 new commits pushed to the master branch:

  • 8de5d20: 8332865: ubsan: os::attempt_reserve_memory_between reports overflow
  • f15d423: 6942632: Hotspot should be able to use more than 64 logical processors on Windows
  • 1a50bd0: 8322568: JFR: Improve metadata for IEEE rounding mode fields
  • 880c6b4: 8333178: ubsan: jvmti_tools.cpp:149:16: runtime error: null pointer passed as argument 2, which is declared to never be null
  • c7d2841: 8332070: Convert package.html files in java.management to package-info.java
  • 7ef2831: 8333644: C2: assert(is_Bool()) failed: invalid node class: Phi
  • 8f07853: 8333410: [AArch64] Clean unused classes in nativeInst_aarch64.hpp
  • 6f690a5: 8333177: Invalid value used for enum Cell in ciTypeFlow::get_start_state
  • b351b5f: 8331736: C2: Live Node limit exceeded limit after JDK-8316991
  • b3f540d: 8332921: Ctrl+C does not call shutdown hooks after JLine upgrade
  • ... and 213 more: https://git.openjdk.org/jdk/compare/e19a421c30534566ba0dea0fa84f812ebeecfc87...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@TheRealMDoerr
Copy link
Contributor Author

@zhengyu123: Please take a look. This should allow backporting JDK-8272364.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jun 5, 2024
@openjdk
Copy link

openjdk bot commented Jun 5, 2024

@TheRealMDoerr The following label will be automatically applied to this pull request:

  • hotspot-gc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-gc hotspot-gc-dev@openjdk.org label Jun 5, 2024
@mlbridge
Copy link

mlbridge bot commented Jun 5, 2024

Webrevs

Copy link
Member

@MBaesken MBaesken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jun 6, 2024
@TheRealMDoerr
Copy link
Contributor Author

The GHA test failure must be unrelated because this PR only affects PPC.

Copy link
Contributor

@zhengyu123 zhengyu123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TheRealMDoerr
Copy link
Contributor Author

Thanks for the reviews!

@TheRealMDoerr
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Jun 6, 2024

Going to push as commit 9b436d0.
Since your change was applied there have been 228 commits pushed to the master branch:

  • 487c477: 8333647: C2 SuperWord: some additional PopulateIndex tests
  • d02cb74: 8333270: HandlersOnComplexResetUpdate and HandlersOnComplexUpdate tests fail with "Unexpected reference" if timeoutFactor is less than 1/3
  • 02f2404: 8333560: -Xlint:restricted does not work with --release
  • 606df44: 8332670: C1 clone intrinsic needs memory barriers
  • 33fd6ae: 8333622: ubsan: relocInfo_x86.cpp:101:56: runtime error: pointer index expression with base (-1) overflowed
  • 8de5d20: 8332865: ubsan: os::attempt_reserve_memory_between reports overflow
  • f15d423: 6942632: Hotspot should be able to use more than 64 logical processors on Windows
  • 1a50bd0: 8322568: JFR: Improve metadata for IEEE rounding mode fields
  • 880c6b4: 8333178: ubsan: jvmti_tools.cpp:149:16: runtime error: null pointer passed as argument 2, which is declared to never be null
  • c7d2841: 8332070: Convert package.html files in java.management to package-info.java
  • ... and 218 more: https://git.openjdk.org/jdk/compare/e19a421c30534566ba0dea0fa84f812ebeecfc87...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jun 6, 2024
@openjdk openjdk bot closed this Jun 6, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jun 6, 2024
@openjdk
Copy link

openjdk bot commented Jun 6, 2024

@TheRealMDoerr Pushed as commit 9b436d0.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@TheRealMDoerr TheRealMDoerr deleted the 8333674_PPC64_CollectorPolicy.young_min_ergo branch June 6, 2024 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-gc hotspot-gc-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

3 participants