Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8233555: [TESTBUG] JRadioButton tests failing on MacoS #1957

Closed
wants to merge 1 commit into from

Conversation

@prsadhuk
Copy link
Contributor

@prsadhuk prsadhuk commented Jan 6, 2021

These radiobutton tests were failing on macos in nightly testing. However recent run of these test are working fine on local mac10.14.6, 10.15.7 systems as well as mach5 macos systems, so we can deproblemlist these tests. Mach5 job link is in JBS.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8233555: [TESTBUG] JRadioButton tests failing on MacoS

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/1957/head:pull/1957
$ git checkout pull/1957

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Jan 6, 2021

👋 Welcome back psadhukhan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

Loading

@openjdk openjdk bot added the rfr label Jan 6, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jan 6, 2021

@prsadhuk To determine the appropriate audience for reviewing this pull request, one or more labels corresponding to different subsystems will normally be applied automatically. However, no automatic labelling rule matches the changes in this pull request. In order to have an "RFR" email sent to the correct mailing list, you will need to add one or more applicable labels manually using the /label pull request command.

Applicable Labels
  • 2d
  • awt
  • beans
  • build
  • compiler
  • core-libs
  • hotspot
  • hotspot-compiler
  • hotspot-gc
  • hotspot-jfr
  • hotspot-runtime
  • i18n
  • javadoc
  • jdk
  • jmx
  • kulla
  • net
  • nio
  • security
  • serviceability
  • shenandoah
  • sound
  • swing

Loading

@prsadhuk
Copy link
Contributor Author

@prsadhuk prsadhuk commented Jan 6, 2021

/label add swing

Loading

@openjdk openjdk bot added the swing label Jan 6, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jan 6, 2021

@prsadhuk
The swing label was successfully added.

Loading

@mlbridge
Copy link

@mlbridge mlbridge bot commented Jan 6, 2021

Webrevs

Loading

@mrserb
Copy link
Member

@mrserb mrserb commented Jan 6, 2021

At least two of those tests were failed due to JDK-8226892. If they work fine now does it mean that some other fixes resolved the problem?

Loading

@prsadhuk
Copy link
Contributor Author

@prsadhuk prsadhuk commented Jan 6, 2021

Not sure but the code added by JDK-8226892 is reworked by JDK-8249548 and we dont see the issue now as can be seen by mach5 run.

Loading

@mrserb
Copy link
Member

@mrserb mrserb commented Jan 6, 2021

Not sure but the code added by JDK-8226892 is reworked by JDK-8249548 and we dont see the issue now as can be seen by mach5 run.

So the tests will fail on the builds before jdk16 b14?

Loading

@prsadhuk
Copy link
Contributor Author

@prsadhuk prsadhuk commented Jan 6, 2021

Yes, maybe not all but bug8033699 fails before 16b14

Loading

@pankaj-bansal
Copy link

@pankaj-bansal pankaj-bansal commented Jan 6, 2021

The JDK-8249548 may be backed out soon as it has caused some other issue JDK-8259237. I am working on it.

Loading

@mrserb
Copy link
Member

@mrserb mrserb commented Jan 7, 2021

The JDK-8249548 may be backed out soon as it has caused some other issue JDK-8259237. I am working on it.

So please take care of these tests, so we do not break them again.

Loading

mrserb
mrserb approved these changes Jan 7, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jan 7, 2021

@prsadhuk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8233555: [TESTBUG] JRadioButton tests failing on MacoS

Reviewed-by: serb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 40 new commits pushed to the master branch:

  • 67c2211: 8259045: Exception message from saproc.dll is garbled on Windows with Japanese locale
  • 28e1f4d: 8247957: remove doclint support for HTML 4
  • 80544e4: 8250564: Remove terminally deprecated constructor in GSSUtil
  • 940b053: 8259232: Bad JNI lookup during printing
  • df721f0: 8259291: Cleanup unnecessary local variables
  • d20d2fa: 8258143: Update --release 16 symbol information for JDK 16 build 30 or later
  • 3be6e06: 8259312: VerifyCACerts.java fails as soneraclass2ca cert will expire in 90 days
  • 722f236: 8259231: Epsilon: improve performance under contention during virtual space expansion
  • f6cb8c5: 8258908: Remove JVM option CleanChunkPoolAsync
  • c0540ff: 8231627: ThreadsListHandleInErrorHandlingTest.java fails in printing all threads
  • ... and 30 more: https://git.openjdk.java.net/jdk/compare/a2a3f4a3dcdf3aa7eb9f17d892d1ffe729733330...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

Loading

@openjdk openjdk bot added the ready label Jan 7, 2021
@prsadhuk
Copy link
Contributor Author

@prsadhuk prsadhuk commented Jan 7, 2021

/integrate

Loading

@openjdk openjdk bot closed this Jan 7, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Jan 7, 2021
@prsadhuk prsadhuk deleted the JDK-8233555 branch Jan 7, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jan 7, 2021

@prsadhuk Since your change was applied there have been 40 commits pushed to the master branch:

  • 67c2211: 8259045: Exception message from saproc.dll is garbled on Windows with Japanese locale
  • 28e1f4d: 8247957: remove doclint support for HTML 4
  • 80544e4: 8250564: Remove terminally deprecated constructor in GSSUtil
  • 940b053: 8259232: Bad JNI lookup during printing
  • df721f0: 8259291: Cleanup unnecessary local variables
  • d20d2fa: 8258143: Update --release 16 symbol information for JDK 16 build 30 or later
  • 3be6e06: 8259312: VerifyCACerts.java fails as soneraclass2ca cert will expire in 90 days
  • 722f236: 8259231: Epsilon: improve performance under contention during virtual space expansion
  • f6cb8c5: 8258908: Remove JVM option CleanChunkPoolAsync
  • c0540ff: 8231627: ThreadsListHandleInErrorHandlingTest.java fails in printing all threads
  • ... and 30 more: https://git.openjdk.java.net/jdk/compare/a2a3f4a3dcdf3aa7eb9f17d892d1ffe729733330...master

Your commit was automatically rebased without conflicts.

Pushed as commit 227f99d.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Loading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants