8333680: com/sun/tools/attach/BasicTests.java fails with "SocketException: Permission denied: connect"

[alexmenkov]

The fix updates com/sun/tools/attach/BasicTests.java to listen and connect using loopback addresses

Testing: run the test on all Oracle-supported platforms

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8333680: com/sun/tools/attach/BasicTests.java fails with "SocketException: Permission denied: connect" (Bug - P4)

Reviewers

• Serguei Spitsyn (@sspitsyn - Reviewer)
• Kevin Walls (@kevinjwalls - Reviewer)
• Leonid Mesnik (@lmesnik - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/19571/head:pull/19571
$ git checkout pull/19571

Update a local copy of the PR:
$ git checkout pull/19571
$ git pull https://git.openjdk.org/jdk.git pull/19571/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 19571

View PR using the GUI difftool:
$ git pr show -t 19571

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/19571.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back amenkov! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@alexmenkov This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8333680: com/sun/tools/attach/BasicTests.java fails with "SocketException: Permission denied: connect"

Reviewed-by: sspitsyn, kevinw, lmesnik

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 39 new commits pushed to the master branch:

• 512b2b4: 8330420: Inverted use of DisplayVMOutputToStderr in ostream_exit
• 8e72d7c: 8320448: Accelerate IndexOf using AVX2
• 25ad862: 8332161: Test restoring echo in the Console implementation (java.base)
• ee82346: 8325984: 4 jcstress tests are failing in Tier6 4 times each
• d744059: 8333774: Avoid eagerly loading various EmptySpliterator classes
• d130d2f: 8333477: Delete extra empty spaces in Makefiles
• 486dee2: 8333653: Remove MallocHeader::get_stack
• 40b2fbd: 8331733: [PPC64] saving and restoring CR is not needed at most places
• 6968770: 8331935: Add support for primitive array C1 clone intrinsic in PPC
• a2030ff: 8332516: Serial: Always sample promoted bytes to avoid getting stuck in Full GCs
• ... and 29 more: https://git.openjdk.org/jdk/compare/60ea17e8482936a6acbc442bb1be199e01008072...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@alexmenkov The following labels will be automatically applied to this pull request:

• core-libs
• serviceability

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

[alexmenkov]

/label remove core-libs

[openjdk]

@alexmenkov
The core-libs label was successfully removed.

[mlbridge]

Webrevs

• 00: Full (e7c213fa)

[sspitsyn]

Looks good.

[plummercj]

You have an interesting warning about the fixVersion being 24 but .jcheck/conf is 23. I'm not sure, but you may need to merge with the current master in order to avoid a 23 backport being created.

[plummercj]

Actually it looks like .jcheck/conf in master has not been updated to 24 yet. Not sure if once it is updated this warning will automatically go away or if you will also have to merge with master.

[alexmenkov]

/integrate

[openjdk]

Going to push as commit 17bd483.
Since your change was applied there have been 39 commits pushed to the master branch:

• 512b2b4: 8330420: Inverted use of DisplayVMOutputToStderr in ostream_exit
• 8e72d7c: 8320448: Accelerate IndexOf using AVX2
• 25ad862: 8332161: Test restoring echo in the Console implementation (java.base)
• ee82346: 8325984: 4 jcstress tests are failing in Tier6 4 times each
• d744059: 8333774: Avoid eagerly loading various EmptySpliterator classes
• d130d2f: 8333477: Delete extra empty spaces in Makefiles
• 486dee2: 8333653: Remove MallocHeader::get_stack
• 40b2fbd: 8331733: [PPC64] saving and restoring CR is not needed at most places
• 6968770: 8331935: Add support for primitive array C1 clone intrinsic in PPC
• a2030ff: 8332516: Serial: Always sample promoted bytes to avoid getting stuck in Full GCs
• ... and 29 more: https://git.openjdk.org/jdk/compare/60ea17e8482936a6acbc442bb1be199e01008072...master

Your commit was automatically rebased without conflicts.

[openjdk]

@alexmenkov Pushed as commit 17bd483.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.