Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8333743: Change .jcheck/conf branches property to match valid branches #19584

Conversation

kevinrushforth
Copy link
Member

@kevinrushforth kevinrushforth commented Jun 6, 2024

Clean backport of .jcheck/conf change to jdk23.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8333743: Change .jcheck/conf branches property to match valid branches (Bug - P2)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/19584/head:pull/19584
$ git checkout pull/19584

Update a local copy of the PR:
$ git checkout pull/19584
$ git pull https://git.openjdk.org/jdk.git pull/19584/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 19584

View PR using the GUI difftool:
$ git pr show -t 19584

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/19584.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 6, 2024

👋 Welcome back kcr! A progress list of the required criteria for merging this PR into jdk23 will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jun 6, 2024

@kevinrushforth This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8333743: Change .jcheck/conf branches property to match valid branches

Reviewed-by: iris, erikj

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the jdk23 branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@irisclark, @erikj79) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot changed the title Backport 2a37764e7428d579a3080e62681f1c9c9f816c1e 8333743: Change .jcheck/conf branches property to match valid branches Jun 6, 2024
@openjdk
Copy link

openjdk bot commented Jun 6, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport clean rfr Pull request is ready for review labels Jun 6, 2024
@openjdk
Copy link

openjdk bot commented Jun 6, 2024

@kevinrushforth The following label will be automatically applied to this pull request:

  • build

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the build build-dev@openjdk.org label Jun 6, 2024
@mlbridge
Copy link

mlbridge bot commented Jun 6, 2024

Webrevs

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jun 6, 2024
@kevinrushforth
Copy link
Member Author

Test comment to check that Skara now prefixes the RFR email with the target branch (if not master).

@kevinrushforth
Copy link
Member Author

Test comment to check that Skara now prefixes the RFR email with the target branch (if not master).

It should work now.

@kevinrushforth
Copy link
Member Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Jun 6, 2024
@openjdk
Copy link

openjdk bot commented Jun 6, 2024

@kevinrushforth
Your change (at version 0d150a5) is now ready to be sponsored by a Committer.

@irisclark
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented Jun 6, 2024

Going to push as commit 31696a4.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jun 6, 2024
@openjdk openjdk bot closed this Jun 6, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Jun 6, 2024
@openjdk
Copy link

openjdk bot commented Jun 6, 2024

@irisclark @kevinrushforth Pushed as commit 31696a4.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport build build-dev@openjdk.org clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

3 participants