-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8333743: Change .jcheck/conf branches property to match valid branches #19584
8333743: Change .jcheck/conf branches property to match valid branches #19584
Conversation
👋 Welcome back kcr! A progress list of the required criteria for merging this PR into |
@kevinrushforth This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@irisclark, @erikj79) but any other Committer may sponsor as well. ➡️ To flag this PR as ready for integration with the above commit message, type |
This backport pull request has now been updated with issue from the original commit. |
@kevinrushforth The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
Test comment to check that Skara now prefixes the RFR email with the target branch (if not master). |
It should work now. |
/integrate |
@kevinrushforth |
/sponsor |
Going to push as commit 31696a4. |
@irisclark @kevinrushforth Pushed as commit 31696a4. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Clean backport of
.jcheck/conf
change to jdk23.Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/19584/head:pull/19584
$ git checkout pull/19584
Update a local copy of the PR:
$ git checkout pull/19584
$ git pull https://git.openjdk.org/jdk.git pull/19584/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 19584
View PR using the GUI difftool:
$ git pr show -t 19584
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/19584.diff
Webrev
Link to Webrev Comment